Bug 2004158

Summary:	Sat 6.9.5: foreman-rake facts:clean aborts due to foreign key in database
Product:	Red Hat Satellite	Reporter:	Vincent S. Cojot <vcojot>
Component:	Fact	Assignee:	Tomer Brisker <tbrisker>
Status:	CLOSED ERRATA	QA Contact:	Peter Ondrejka <pondrejk>
Severity:	medium	Docs Contact:
Priority:	high
Version:	6.9.0	CC:	apatel, egolov, jkrajice, kgaikwad, mhulan, pcreech, pmoravec, shwsingh, tbrisker
Target Milestone:	6.11.0	Keywords:	Triaged, Upgrades
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-07-05 14:29:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vincent S. Cojot 2021-09-14 15:17:19 UTC

Description of problem:

On Satellite 6.9.5, I'm getting this failure:

[root@sat6 ~]# foreman-rake facts:clean COMMIT=true --trace
** Invoke facts:clean (first_time)
** Invoke environment (first_time)
** Execute environment
** Execute facts:clean
Starting orphaned facts clean up
rake aborted!
ActiveRecord::InvalidForeignKey: PG::ForeignKeyViolation: ERROR:  update or delete on table "fact_names" violates foreign key constraint "fact_values_fact_name_id_fk" on table "fact_values"
DETAIL:  Key (id)=(5153) is still referenced from table "fact_values".
/opt/theforeman/tfm/root/usr/share/gems/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:675:in `async_exec_params'
/opt/theforeman/tfm/root/usr/share/gems/gems/activerecord-6.0.3.4/lib/active_record/connection_adapters/postgresql_adapter.rb:675:in `block (2 levels) in exec_no_cache'
/opt/theforeman/tfm/root/usr/share/gems/gems/activesupport-6.0.3.4/lib/active_support/dependencies
[......]


Version-Release number of selected component (if applicable):
satellite 6.9.5 (fresh upgrade from 6.8.6)

Comment 1 Tomer Brisker 2021-10-18 13:30:58 UTC

Connecting redmine issue https://projects.theforeman.org/issues/30028 from this bug

Comment 2 Bryan Kearney 2021-11-04 13:51:26 UTC

Upstream bug assigned to tbrisker

Comment 3 Bryan Kearney 2021-11-04 13:51:27 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/30028 has been resolved.

Comment 4 Peter Ondrejka 2022-04-26 13:37:02 UTC

Checked on Satellite 6.11 snap 17, I inserted several entries into the fact_names table: compose/non-compse, without matching fact_values, with null fact values, etc. When running "foreman-rake facts:clean COMMIT=true --trace":
- fact_names without fact_values are removed
- non-compose fact_name with fact_value is left alone without error 
- compose fact_name with empty fact_value is removed 
- compose fact_name with non-empty fact_value is left alone without error

Comment 7 errata-xmlrpc 2022-07-05 14:29:38 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.11 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5498