Bug 2004201

Summary: Review Request: python-system-calls - Simple interface to get system call numbers for any architecture.
Product: [Fedora] Fedora Reporter: Marcin Juszkiewicz <mjuszkie>
Component: Package ReviewAssignee: Ben Beasley <code>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: code, package-review
Target Milestone: ---Flags: code: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-21 09:47:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Hand-written man page none

Description Marcin Juszkiewicz 2021-09-14 17:02:11 UTC 
Spec URL: https://fedora.juszkiewicz.com.pl/python-system-calls/python-system-calls.spec
SRPM URL: https://fedora.juszkiewicz.com.pl/python-system-calls/python-system-calls-5.15.3-1.fc36.src.rpm
Description: Simple interface to get system call numbers for any architecture.
Fedora Account System Username: hrw
Comment 1 Marcin Juszkiewicz 2021-09-14 17:05:53 UTC 
From automated fedora-review run + set of my marks:


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "*No copyright* MIT License", "Unknown or
     generated". 53 files have unknown license. Detailed output of
     licensecheck in
     /home/hrw/devel/moje/syscalls/python/packaging/fedora/python-system-
     calls/ licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[ ]: A package which is used by another package via an egg interface should
     provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).


Rpmlint
-------
Cannot parse rpmlint output:


Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://files.pythonhosted.org/packages/source/s/system-calls/system-calls-5.15.3.tar.gz :
  CHECKSUM(SHA256) this package     : 584e3b29a6342526d2d9696ba3d05456734266f6e0eda217289acf9d8b4dd36a
  CHECKSUM(SHA256) upstream package : 584e3b29a6342526d2d9696ba3d05456734266f6e0eda217289acf9d8b4dd36a


Requires
--------
python3-system-calls (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)



Provides
--------
python3-system-calls:
    python-system-calls
    python3-system-calls
    python3.10-system-calls
    python3.10dist(system-calls)
    python3dist(system-calls)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review --rpm-spec -n python-system-calls-5.15.3-1.fc36.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Python, Generic
Disabled plugins: fonts, Haskell, Perl, Ocaml, C/C++, Java, R, PHP, SugarActivity
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comment 2 Ben Beasley 2021-09-15 12:14:18 UTC 
Created attachment 1823279 [details]
Hand-written man page

A man page is always wanted for a CLI executable (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages). If you are willing to maintain it with any small changes it might need in the future, please consider this hand-written man page in groff_man(7) format.

> Source1:        syscall.1 

> %install
> […]
> install -t '%{buildroot}%{_mandir}/man1' -D -p -m 0644 '%{SOURCE1}'

> %files python3-syscalls -f %{pyproject_files}
> […]
> %{_mandir}/man1/syscall.1*
Comment 3 Ben Beasley 2021-09-15 12:25:02 UTC 
(In reply to Ben Beasley from comment #2)
> Created attachment 1823279 [details]
> Hand-written man page
> 
> A man page is always wanted for a CLI executable
> (https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages). If
> you are willing to maintain it with any small changes it might need in the
> future, please consider this hand-written man page in groff_man(7) format.

Even better — upstream came out with 5.15.4 two hours ago, and it contains a similar man page.
Comment 4 Marcin Juszkiewicz 2021-09-15 13:24:20 UTC 
As I released new version upstream (which includes man page) an update comes:

Spec URL: https://fedora.juszkiewicz.com.pl/python-system-calls/python-system-calls.spec
SRPM URL: https://fedora.juszkiewicz.com.pl/python-system-calls/python-system-calls-5.15.4-1.fc36.src.rpm
Description: Simple interface to get system call numbers for any architecture.
Fedora Account System Username: hrw
Comment 5 Marcin Juszkiewicz 2021-09-15 13:26:33 UTC 
Ben: can I take your man page under MIT license? Would improve upstream one a bit.
Comment 6 Ben Beasley 2021-09-15 13:32:08 UTC 
Thanks! (I had just figured out you were the upstream author as well.) I’ll go ahead and re-start the review using the latest submission.

You may take the man page under MIT. Alternatively, I disclaim all rights to it, and you may consider it public-domain.
Comment 7 Ben Beasley 2021-09-15 14:13:00 UTC 
The latest SRPM URL is 404.
Comment 8 Marcin Juszkiewicz 2021-09-15 14:22:01 UTC 
Oops. 

Spec URL: https://fedora.juszkiewicz.com.pl/python-system-calls/python-system-calls.spec
SRPM URL: https://fedora.juszkiewicz.com.pl/python-system-calls/python-system-calls-5.15.4-1.fc35.src.rpm
Description: Simple interface to get system call numbers for any architecture.
Fedora Account System Username: hrw
Comment 9 Ben Beasley 2021-09-15 16:12:03 UTC 
Thanks for providing this, and for packaging it in Fedora. It’s a clean package
with only a couple of things to adjust before it can be approved.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== Issues =====

- Thanks for adding a man page. The glob must not assume gzip as the
  compression format, so please change

    %{_mandir}/man1/syscall.1.gz

  to

    %{_mandir}/man1/syscall.1*
  
  https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages

- The %python3_pkgversion macro is obsolete in Fedora. It’s really only
  required for EPEL7, as its value is, and probably always will be, “3” on
  EPEL8. Since you’re using the new Python guidelines (pyproject-rpm-macros), I
  know you’re not building for either EPEL with this version of the spec file.

  Please replace each occurrence of “%{python3_pkgversion}” with “3”.

  Additionally, the resulting

    BuildRequires:  python3-pytest

  would be better expressed as

    BuildRequires:  python3dist(pytest)

  or

    BuildRequires:  %{py3_dist pytest}

  (If you want to branch this package for EPEL8 or EPEL7, you will need to
  rewrite a version of it under the old guidelines for those platforms, as
  pyproject-rpm-macros does not exist there. If you want to do this, feel free
  to ask for help.)

- Since system_calls/__init__.py and system_calls/tables/*.py are for importing
  rather than for running as scripts, there is no reason for them to have
  shebang lines. See the many “non-executable-script” diagnostics from rpmlint.

  You could remove these shebangs upstream, if you agree with doing so. That
  would be my suggestion.

  If you want to keep them upstream for some reason, or in the general case
  with an arbitrary and perhaps unresponsive upstream, you could patch them out
  downstream by adding something like this to %prep:

    # Remove shebangs from non-script sources
    find system_calls -type f -name '*.py' \
        -exec gawk '/^#!/ { print FILENAME }; { nextfile }' '{}' '+' |
        xargs -r sed -r -i '1{/^#!/d}'

  A simpler script could be something like 

    find system_calls -type f -name '*.py' -execdir sed -r -i '1{/^#!/d}' '{}' '+'

  but this would fail to preserve the upstream mtimes on any files that did not
  need to be modified.

===== Notes/suggestions (no change required) =====

- As a recent change in all Fedora releases, python3-devel now requires
  pyproject-rpm-macros, so this is no longer required and you may remove it:

    BuildRequires:  pyproject-rpm-macros

- In most cases, pyproject-rpm-macros can now handle marking the license file
  in the dist-info/egg-info, as part of the %{pyproject_files} list. This
  depends on a lot of details, so it’s best to verify with
  “rpm -qL -p /path/to/python3-whatever.rpm”. See
  https://src.fedoraproject.org/rpms/python-pandas-flavor/pull-request/1#comment-85125
  for details.

  In this case, you may—if you choose—drop

    %license LICENSE

  but you may also choose to leave it in.

- Personally, I would write

    %{_bindir}/*

  as

    %{_bindir}/syscall

  to make it easier for a reader of the spec file to know what to expect from
  the package. This would also keep you from being surprised by any changes in
  entry points, if you weren’t the upstream author.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "Unknown or generated", "*No copyright* MIT
     License". 54 files have unknown license. Detailed output of
     licensecheck in /home/reviewer/2004201-python-system-
     calls/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines

     (except as mentioned)

[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-system-calls-5.15.4-1.fc36.noarch.rpm
          python-system-calls-5.15.4-1.fc36.src.rpm
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/__init__.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/alpha.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/arc.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/arm.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/arm64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/armoabi.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/avr32.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/blackfin.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/c6x.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/cris.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/csky.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/frv.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/h8300.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/hexagon.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/i386.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/ia64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/loongarch64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/m32r.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/m68k.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/metag.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/microblaze.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/mips64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/mips64n32.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/mipso32.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/mn10300.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/names.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/nds32.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/nios2.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/openrisc.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/parisc.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/powerpc.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/powerpc64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/riscv32.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/riscv64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/s390.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/s390x.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/score.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/sh.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/sh64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/sparc.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/sparc64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/tile.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/tile64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/unicore32.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/x32.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/x86_64.py 644 /usr/bin/python3 
python3-system-calls.noarch: E: non-executable-script /usr/lib/python3.10/site-packages/system_calls/tables/xtensa.py 644 /usr/bin/python3 
2 packages and 0 specfiles checked; 47 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://files.pythonhosted.org/packages/source/s/system-calls/system-calls-5.15.4.tar.gz :
  CHECKSUM(SHA256) this package     : 4322c0d84babe9b332e5655b762d7d89a7f11e4d948f09b8edf45774d703baab
  CHECKSUM(SHA256) upstream package : 4322c0d84babe9b332e5655b762d7d89a7f11e4d948f09b8edf45774d703baab


Requires
--------
python3-system-calls (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)



Provides
--------
python3-system-calls:
    python-system-calls
    python3-system-calls
    python3.10-system-calls
    python3.10dist(system-calls)
    python3dist(system-calls)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 2004201
Buildroot used: fedora-rawhide-aarch64
Active plugins: Generic, Python, Shell-api
Disabled plugins: R, PHP, Java, C/C++, Perl, fonts, SugarActivity, Haskell, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comment 10 Marcin Juszkiewicz 2021-09-15 17:04:34 UTC 
Thanks Ben for review and hints!

New upstream release 5.15.5 got improved manpage and dropped shebangs. 

Changed Fedora spec to apply your suggestions. rpmlint does not complain.

Spec URL: https://fedora.juszkiewicz.com.pl/python-system-calls/python-system-calls.spec
SRPM URL: https://fedora.juszkiewicz.com.pl/python-system-calls/python-system-calls-5.15.5-1.fc35.src.rpm
Description: Simple interface to get system call numbers for any architecture.
Fedora Account System Username: hrw
Comment 11 Ben Beasley 2021-09-15 17:36:19 UTC 
Thanks! Two small things before I do the full re-review, and, I expect, approve the package:

Could you please make sure the SRPM is built with the exact same tarball that is at the Source URL? It looks like the contents were the same, but the checksums were different.

Please change
> cp man/syscall.1 %{buildroot}%{_mandir}/man1/
to
> cp -p man/syscall.1 %{buildroot}%{_mandir}/man1/
in order to preserve the original timestamps.
Comment 12 Marcin Juszkiewicz 2021-09-16 08:15:09 UTC 
Refreshed both spec and srpm - both include your suggestions.
Comment 13 Ben Beasley 2021-09-16 13:32:50 UTC 
Great, thanks! Package approved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT License", "Unknown or generated", "*No copyright* MIT
     License". 54 files have unknown license. Detailed output of
     licensecheck in /home/reviewer/2004201-python-system-
     calls/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.

     Upstream does not provide any tests.

[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-system-calls-5.15.5-1.fc36.noarch.rpm
          python-system-calls-5.15.5-1.fc36.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://files.pythonhosted.org/packages/source/s/system-calls/system-calls-5.15.5.tar.gz :
  CHECKSUM(SHA256) this package     : 6fe4b4e67b21954f62016f48c03b6a0324154d97441c66897a19fc58e1854d1b
  CHECKSUM(SHA256) upstream package : 6fe4b4e67b21954f62016f48c03b6a0324154d97441c66897a19fc58e1854d1b


Requires
--------
python3-system-calls (rpmlib, GLIBC filtered):
    /usr/bin/python3
    python(abi)



Provides
--------
python3-system-calls:
    python-system-calls
    python3-system-calls
    python3.10-system-calls
    python3.10dist(system-calls)
    python3dist(system-calls)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 2004201
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: SugarActivity, Java, Haskell, Ocaml, fonts, C/C++, PHP, Perl, R
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Comment 14 Gwyn Ciesla 2021-09-20 16:46:16 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-system-calls
Comment 15 Marcin Juszkiewicz 2021-09-21 09:47:15 UTC 
Package built.

python-system-calls-5.15.5-1.fc36 reached the stable testing threshold
	https://bodhi.fedoraproject.org/updates/FEDORA-2021-77700e6937