Bug 2004246

Summary: adding -j option to MAKEFLAGS no longer works
Product: Red Hat Enterprise Linux 8 Reporter: Carlos Santos <casantos>
Component: makeAssignee: DJ Delorie <dj>
make sub component: system-version QA Contact: Lenka Špačková <lkuprova>
Status: CLOSED ERRATA Docs Contact: Petr Hybl <phybl>
Severity: low    
Priority: low CC: codonell, dj, jvaldez, mcermak, pete.perfetti, phybl
Version: 8.4Keywords: Bugfix, Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: make-4.2.1-11.el8 Doc Type: Bug Fix
Doc Text:
.The `-j` flag now works when used in a Makefile Previously, when you added the `-j` flag to MAKEFLAGS inside the Makefile, the targets were built sequentially instead of in parallel. This bug has been fixed, and now the targets are built at the same time when you use the `-j` flag in the Makefile.
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-10 15:19:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Carlos Santos 2021-09-14 19:20:35 UTC
Description of problem:

The make command does not recognize the -j option in MAKEFLAGS.

Version-Release number of selected component (if applicable):

make-4.2.1-10.el8.x86_64

How reproducible:

Always

Steps to Reproduce:

$ cat Makefile 
MAKEFLAGS := -j -s -B

all: t1 t2 t3 t4 t5 t6 t7 t8

t1 t2 t3 t4 t5 t6 t7 t8:
	+echo begin
	+sleep 10
	+echo end

$ make

Actual results:

begin
end
begin
end
begin
end
begin
end
begin
end
begin
end
begin
end
begin
end

Expected results:

begin
begin
begin
begin
begin
begin
begin
begin
end
end
end
end
end
end
end
end

Additional info:

Using "make -j" produces the expected result, of course.

This has been upstream a long time ago:

    https://savannah.gnu.org/bugs/?48274

The fix is also included in the Ubuntu package (also make v. 4.2.1).

Comment 1 DJ Delorie 2021-09-14 19:34:39 UTC
This seems to be the key upstream commit:
https://git.savannah.gnu.org/cgit/make.git/commit/?id=0c5a9f9b92af1634dc60fa21e9ac86ed50e5d595

Comment 7 Petr Hybl 2022-03-17 10:10:16 UTC
Hi, can you do an SME review, please?

Comment 8 DJ Delorie 2022-03-21 20:17:00 UTC
I tweaked it a bit but it's basically correct.

Comment 12 Jacob Taylor Valdez 2022-03-30 11:10:55 UTC
This has been acked from peer-review.

Comment 15 errata-xmlrpc 2022-05-10 15:19:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (make bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2015