Bug 200499
Summary: | Review Request: <btsco-kmod-common> | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Daniel Rindt <drindt> | ||||
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||
Status: | CLOSED WONTFIX | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | djuran, kevin, panemade, work.eric | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-01-25 16:10:03 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 200498 | ||||||
Attachments: |
|
Description
Daniel Rindt
2006-07-28 07:51:20 UTC
Mock build for rawhide i386 is failed. aclocal:configure.in:44: warning: macro `AM_PATH_ALSA' not found in library configure.in:44: error: possibly undefined macro: AM_PATH_ALSA If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. Package is missing 3 more BRs Add libtool,automake,alsa-lib-devel to BuildRequires and update package As per given in kernel module packaging guidelines MUST items present are MUST: This package have the belonging kernel-module with something like 'Requires: %{name}- kmod = %{version}' MUST: This package have its name as %{name}-kmod-common Issues should be fixed now. Spec URL: http://daniel.rindt.name/fileadmin/download/fedora/SPECS/btsco-kmod-common.spec SRPM URL: http://rindt.name/fileadmin/download/fedora/SRPMS/btsco-kmod-common-0.42-2.src.rpm rpmlint is not silent W: btsco-kmod-common incoherent-version-in-changelog 0.42.fc5.2 0.42-2.fc6 Your last entry in %changelog contains a version that is not coherent with the current version of your package. You Changelog entries are wrong. Change 0.42.fc5.1 to 0.42.1.fc5 and 0.42.fc.2 to 0.42.2.fc5 E: btsco-kmod-common zero-length /usr/share/doc/btsco-kmod-common-0.42/NEWS E: btsco-kmod-common zero-length /usr/share/doc/btsco-kmod-common-0.42/ChangeLog E: btsco-kmod-common zero-length /usr/share/doc/btsco-kmod-common-0.42/AUTHORS if there is no content in all above 3 files then rpmlint will show error Note that FESCo needs to approve this module before reviews begin, and before that can happen we need several pieces of information, including a statement from the upstream developer as to why this is not in the main kernel tree and when it is planned to be added. Please see http://fedoraproject.org/wiki/Packaging/KernelModules for more information. the reason why it isnt in the mainline kernel included yet is that the code is still beta and in heavy development. If you are still willing to submit this package, upload new version of this package. I got following rpmlint output Review on this package => On SRPM i got W: btsco-kmod-common mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 1) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both. =>USE sed -i -e 's|\t| |g' on SPEC file on RPM i got W: btsco-kmod-common incoherent-version-in-changelog 0.42.fc5.2 0.42-2.fc6 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. => update Changelog entry E: btsco-kmod-common zero-length /usr/share/doc/btsco-kmod-common-0.42/NEWS E: btsco-kmod-common zero-length /usr/share/doc/btsco-kmod-common-0.42/ChangeLog E: btsco-kmod-common zero-length /usr/share/doc/btsco-kmod-common-0.42/AUTHORS =>Remove files in SPEC if they are zero-length files Created attachment 140877 [details]
BTSCO init script
Here is an init script I made to get btsco running and also saves the alsa
mixer values. You just need to create the file /etc/sysconfig/btsco with the
line:
BTADDR="XX:XX:XX:XX:XX:XX"
I thought this might be nice to add to your package.
It appears that btsco is depreciated now... the new 'plugz' bluetooth-alsa project no longer requires a kernel module. See: http://bluetooth-alsa.sourceforge.net/history.html Perhaps this should be closed now? Might you consider packaging the new 'plugz' and 'sbc' packages? Closing due to Comment #10. Please consider packaging the new software instead of this. |