Bug 2005529

Summary: compression cannot be requested when defragmenting
Product: [Fedora] Fedora Reporter: Laszlo Ersek <lersek>
Component: btrfs-progsAssignee: Josef Bacik <josef>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 34CC: bugzilla, esandeen, igor.raits, josef, ngompa13, rjones
Target Milestone: ---Keywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: btrfs-progs-5.14.1-1.fc34 btrfs-progs-5.14.1-1.fc35 btrfs-progs-5.14.1-1.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-22 16:30:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Laszlo Ersek 2021-09-17 23:14:31 UTC
* Description of problem:
Upstream commit f3a132fa1b8c ("btrfs-progs: factor out compression type name parsing to common utils", 2021-09-07), part of the v5.14 upstream release, broke the parsing of the compression algorithm in 

$ btrfs filesystem defragment -c[<algo>]

regardless of the particular <algo> specified (assuming an <algo> *is* specified).

* Version-Release number of selected component (if applicable):
btrfs-progs-5.14-2.fc34.x86_64

* How reproducible:
100%

* Steps to Reproduce:
$ fallocate -l 512M mydisk
$ LOOP=$(losetup --show -f mydisk)
$ mkfs.btrfs -- "$LOOP"
$ mount -- "$LOOP" /mnt
$ btrfs filesystem defragment -czlib /mnt

* Actual results:
ERROR: unknown compression type: zlib

* Expected results:
WARNING: directory specified but recursive mode not requested: /mnt
WARNING: a directory passed to the defrag ioctl will not process the files
recursively but will defragment the subvolume tree and the extent tree.
If this is not intended, please use option -r .

* Additional info:
- Downgrading to btrfs-progs-5.13.1-1.fc34 mitigates the issue.
- 5.14 comes from bug 2003211.
- upstream ticket: https://github.com/kdave/btrfs-progs/issues/403

Comment 1 Laszlo Ersek 2021-09-17 23:29:19 UTC
(This breaks the "btrfs_filesystem_defragment" check in the libguestfs c-api self-test; see in "generator/actions_core.ml" at commit f47e0bb67254.)

Comment 2 Chris Murphy 2021-09-18 16:58:27 UTC
User report on #fedora similar error:
>ERROR: unknown compression type: zstd

Comment 3 Chris Murphy 2021-09-18 17:00:19 UTC
There's a fix upstream, and it will be in 5.14.1 tentatively scheduled for SEP 20. Fedora will pick that up soon after that.

Comment 4 Chris Murphy 2021-09-20 16:59:48 UTC
New upstream release fixes this.
https://lore.kernel.org/linux-btrfs/20210920162224.27927-1-dsterba@suse.com/T/#u

Comment 5 Fedora Update System 2021-09-20 19:36:11 UTC
FEDORA-2021-2225202282 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-2225202282

Comment 6 Fedora Update System 2021-09-20 19:37:39 UTC
FEDORA-2021-2225202282 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-2225202282

Comment 7 Fedora Update System 2021-09-20 19:39:11 UTC
FEDORA-2021-d1fcf999b9 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d1fcf999b9

Comment 8 Fedora Update System 2021-09-20 19:39:54 UTC
FEDORA-2021-e63926a1bb has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e63926a1bb

Comment 9 Fedora Update System 2021-09-20 19:39:57 UTC
FEDORA-2021-e63926a1bb has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e63926a1bb

Comment 10 Fedora Update System 2021-09-20 20:55:22 UTC
FEDORA-2021-2225202282 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-2225202282`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2225202282

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-09-21 15:23:30 UTC
FEDORA-2021-d1fcf999b9 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-d1fcf999b9`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d1fcf999b9

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-09-21 16:07:40 UTC
FEDORA-2021-e63926a1bb has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-e63926a1bb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e63926a1bb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2021-09-22 16:30:29 UTC
FEDORA-2021-d1fcf999b9 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2021-09-24 20:31:23 UTC
FEDORA-2021-2225202282 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2021-10-06 16:53:20 UTC
FEDORA-2021-e63926a1bb has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.