Bug 2005674

Approved.

Please fix before import:

1. Source0:        %url/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
   ->
   Source0:        %{url}/archive/v%{version}/%{name}-%{version}.tar.gz

2. Own this dirs:

/usr/share/help/pt_BR
/usr/share/help/ru
/usr/share/help/it_IT
/usr/share/help/C
/usr/share/help/de

---

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: There is no build directory. Running licensecheck on vanilla
     upstream sources. Licenses found: "Unknown or generated", "*No
     copyright* GNU General Public License, Version 3", "GNU General Public
     License v3.0 or later". 214 files have unknown license. Detailed
     output of licensecheck in /home/tim/rpmbuild/fedora-
     review/2005674-easyeffects/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/help/it_IT
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/help/pt_BR,
     /usr/share/help/ru, /usr/share/help/it_IT, /usr/share/help/C,
     /usr/share/help/de
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
     Note: Especially check following dirs for bundled code:
     /home/tim/rpmbuild/fedora-review/2005674-easyeffects/upstream-
     unpacked/Source0/easyeffects-6.1.1/include
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 1300480 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: easyeffects-6.1.1-1.fc36.x86_64.rpm
          easyeffects-debuginfo-6.1.1-1.fc36.x86_64.rpm
          easyeffects-debugsource-6.1.1-1.fc36.x86_64.rpm
          easyeffects-6.1.1-1.fc36.src.rpm
easyeffects.x86_64: W: no-manual-page-for-binary easyeffects
4 packages and 0 specfiles checked; 0 errors, 1 warnings.




Rpmlint (debuginfo)
-------------------
Checking: easyeffects-debuginfo-6.1.1-1.fc36.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/wwmm/easyeffects/archive/v6.1.1.tar.gz#/easyeffects-6.1.1.tar.gz :
  CHECKSUM(SHA256) this package     : 7e4f8401a5138396c80548c8fca9635831515b17fe7e19d3330d75cb352a3cb6
  CHECKSUM(SHA256) upstream package : 7e4f8401a5138396c80548c8fca9635831515b17fe7e19d3330d75cb352a3cb6


Requires
--------
easyeffects (rpmlib, GLIBC filtered):
    dbus-common
    hicolor-icon-theme
    ladspa-calf-plugins
    libbs2b.so.0()(64bit)
    libc.so.6()(64bit)
    libcairomm-1.16.so.1()(64bit)
    libebur128.so.1()(64bit)
    libfftw3f.so.3()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.3.1)(64bit)
    libgio-2.0.so.0()(64bit)
    libgiomm-2.68.so.1()(64bit)
    libglib-2.0.so.0()(64bit)
    libglibmm-2.68.so.1()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-4.so.1()(64bit)
    libgtkmm-4.0.so.0()(64bit)
    liblilv-0.so.0()(64bit)
    libm.so.6()(64bit)
    libpangomm-2.48.so.1()(64bit)
    libpipewire-0.3.so.0()(64bit)
    librnnoise.so.0()(64bit)
    librubberband.so.2()(64bit)
    libsamplerate.so.0()(64bit)
    libsamplerate.so.0(libsamplerate.so.0.0)(64bit)
    libsigc-3.0.so.0()(64bit)
    libsndfile.so.1()(64bit)
    libsndfile.so.1(libsndfile.so.1.0)(64bit)
    libspeexdsp.so.1()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    libstdc++.so.6(CXXABI_1.3.8)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libzita-convolver.so.4()(64bit)
    lsp-plugins-lv2
    lv2-calf-plugins
    lv2-mdala-plugins
    rtld(GNU_HASH)

easyeffects-debuginfo (rpmlib, GLIBC filtered):

easyeffects-debugsource (rpmlib, GLIBC filtered):



Provides
--------
easyeffects:
    application()
    application(com.github.wwmm.easyeffects.desktop)
    easyeffects
    easyeffects(x86-64)
    metainfo()
    metainfo(com.github.wwmm.easyeffects.metainfo.xml)
    pulseeffects

easyeffects-debuginfo:
    debuginfo(build-id)
    easyeffects-debuginfo
    easyeffects-debuginfo(x86-64)

easyeffects-debugsource:
    easyeffects-debugsource
    easyeffects-debugsource(x86-64)



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 2005674
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, C/C++, Shell-api
Disabled plugins: Perl, Haskell, R, fonts, Python, SugarActivity, Java, Ocaml, PHP
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/easyeffects