Bug 200665
| Summary: | Review Request: ltris | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael J Knox <michael> |
| Component: | Package Review | Assignee: | Thorsten Leemhuis (ignored mailbox) <bugzilla-sink> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cq92j9y+rlkr0w, cweyl, wart |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-09-16 20:32:59 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Michael J Knox
2006-07-30 09:12:19 UTC
Hi Michael,
I haven't tried your package, but are you sure you need to run the
'gtk-update-icon-cache' scriptlet? LTris doesn't install icons into
%{_datadir}/icons/hicolor.
Please correct me if I'm mistaken ;)
no, you are quiet right. fixed Spec URL: http://www.knox.net.nz/~michael/ltris.spec SRPM URL: http://www.knox.net.nz/~michael/ltris-1.0.11-2.src.rpm According to http://fedoraproject.org/wiki/Extras/SIGs/Games you should package data files and game files separately. Please read whole site and make necessary changes required by Games Packaging Guidelines. The SIG guide states "if possible" not "must". ltris is less than half a meg in total size. The idea behind splitting the packages, to reduce size, is not really a concern here IMHO. SIG guide also states that this "should be done even if upstream uses one tarball for game source and data". But for ltris you're probably right. Requires: SDL_mixer can be dropped. The package already requires
libSDL_mixer-1.2.so.0()(64bit), which is provided by SDL_mixer.
ltris.png is a 48x48 color icon. Why not put it in the
$RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/48x48/apps/ directory? I've seem
packages use both, and I'm not sure which is the preferred location for desktop
icons.
You define _localstatedir, but never use it. Drop the %define.
World writable scoreboard files are bad. I would suggest either of the following:
1) Make the game setgid 'games' and make the scoreboard file 'games' group
writable. Be sure to audit and modify the code to make sure that it's setgid safe.
2) Move the scoreboard file to $HOME so that it's private for each user. This
removes the need to use a setgid binary, but also disables having a shared
scoreboard file.
Package creates but doesn't own '/var/games/%{name}'. Since there's only one
file in this directory, it's acceptable (but not required) to put the scoreboard
file directly in /var/games without the %{name} subdirectory. I'll update the
Games packaging guidelines to reflect this.
_localstatedir defines where the scoreboard gets put. I will see how much work is need to make the scoreboard private to each user. (In reply to comment #7) > _localstatedir defines where the scoreboard gets put. I see. Instead of redefining _localstatedir, it would be better just to add --localstatedir /var/games/%{name} at the end of %configure, instead of redefining a standard rpm variable which might have unforseen side effects (though it doesn't seem to in this case). Sorry. Due to my stepping out for a while, I am unable to complete this submission. |