Bug 2007550

Summary:	Change type of disk write/read rate from integer to long
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Martin Perina <mperina>
Component:	ovirt-engine-dwh	Assignee:	Aviv Litman <alitman>
Status:	CLOSED ERRATA	QA Contact:	Pavel Novotny <pnovotny>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.4.7	CC:	bzlotnik, emarcus, eshenitz, gdeolive, jspanko, lsurette, mavital, mhicks, mperina, srevivo
Target Milestone:	ovirt-4.4.9	Keywords:	ZStream
Target Release:	4.4.9
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-dwh-4.4.9.1	Doc Type:	Enhancement
Doc Text:	In this release, the data type for the virtual machines disk write/read rate was changed from integer to long.	Story Points:	---
Clone Of:	2007384	Environment:
Last Closed:	2021-11-16 14:46:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Metrics	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2007384
Bug Blocks:

Description Martin Perina 2021-09-24 08:40:34 UTC

+++ This bug was initially created as a clone of Bug #2007384 +++

Description of problem:
engine.log is flooded with following messages
-----
2021-07-24 09:20:23,033+03 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.VdsBrokerObjectsBuilder] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-73) [] Failed to parse 'writeRate' value '2649267647' to integer: For input string: "2649267647"
2021-07-25 05:31:32,021+03 ERROR [org.ovirt.engine.core.vdsbroker.vdsbroker.VdsBrokerObjectsBuilder] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-38) [] Failed to parse 'readRate' value '2243888802' to integer: For input string: "2243888802"
-----

$ grep "Failed to parse" engine.log| wc -l
74256

Version-Release number of selected component (if applicable):
ovirt-engine-4.4.7

How reproducible:
100% in customer environments, found during architecture reviews 

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Similar to https://bugzilla.redhat.com/show_bug.cgi?id=1929211 but looking to the fix only read/write ops was fixed to bigint, not write/read rate

Comment 4 Pavel Novotny 2021-10-26 23:32:13 UTC

Verified in
ovirt-engine-4.4.9.3-0.3.el8ev.noarch
ovirt-engine-dwh-4.4.9.1-1.el8ev.noarch


Verified that corresponding columns have been updated from integer to bigint:
~~~
                                           Table "public.vm_disk_samples_history"
 read_rate_bytes_per_second    | bigint                   |           |          | 
 write_rate_bytes_per_second   | bigint                   |           |          | 

                                             Table "public.vm_disk_hourly_history"
 read_rate_bytes_per_second      | bigint                   |           |          | 
 max_read_rate_bytes_per_second  | bigint                   |           |          | 
 write_rate_bytes_per_second     | bigint                   |           |          | 
 max_write_rate_bytes_per_second | bigint                   |           |          | 

                                        Table "public.vm_disk_daily_history"
 read_rate_bytes_per_second      | bigint        |           |          | 
 max_read_rate_bytes_per_second  | bigint        |           |          | 
 write_rate_bytes_per_second     | bigint        |           |          | 
 max_write_rate_bytes_per_second | bigint        |           |          | 
```

Also no 'Failed to parse...' messages were found in the engine.log file.

Comment 8 errata-xmlrpc 2021-11-16 14:46:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: RHV Manager (ovirt-engine) security update [ovirt-4.4.9]), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4626