Bug 200820

Summary: mknod in anaconda shell is broken
Product: [Fedora] Fedora Reporter: Roland McGrath <roland>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED RAWHIDE QA Contact: Mike McLean <mikem>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-07-31 20:31:47 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
fix for isys.makedev wrapper none

Description Roland McGrath 2006-07-31 20:23:04 UTC 
Description of problem:

The mknod written in python for the anaconda emergency shell is broken.

Version-Release number of selected component (if applicable):
anaconda-11.1.0.73-1

How reproducible:
100%

Steps to Reproduce:
1. mknod sda15 b 8 15
2.
3.
  
Actual results:

sh-3.1# mknod sda15 b 8 15
/usr/bin/mknod:50: DeprecationWarning: isys.makedev is deprecated.  Use
os.makedev instead.
  isys.mknod(path, 0644 | type, isys.makedev(major, minor))
/usr/bin/mknod:50: DeprecationWarning: isys.mknod is deprecated.  Use os.mknod
instead.
  isys.mknod(path, 0644 | type, isys.makedev(major, minor))
Traceback (most recent call last):
  File "/usr/bin/mknod", line 53, in ?
    main()
  File "/usr/bin/mknod", line 50, in main
    isys.mknod(path, 0644 | type, isys.makedev(major, minor))
  File "/usr/lib/anaconda/isys.py", line 388, in mknod
    return os.mknod(pathname, mode, dev)
TypeError: an integer is required


Expected results:

no error, create the node

Additional info:

The script should be fixed not to use the deprecated interfaces.
It fails because isys.makedev is broken.  Patch attached.
Comment 1 Roland McGrath 2006-07-31 20:23:04 UTC 
Created attachment 133350 [details]
fix for isys.makedev wrapper
Comment 2 Peter Jones 2006-07-31 20:31:47 UTC 
Will be fixed in the next rawhide build