Bug 2010111
| Summary: | Review Request: gdnativegamerzilla - Godot native interface to gamerzilla | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Payne <dulsi> |
| Component: | Package Review | Assignee: | Sandro Mani <manisandro> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | manisandro, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: |
If this bug requires documentation, please select an appropriate Doc Type value.
|
|
| Last Closed: | 2022-03-29 07:13:08 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2025318 | ||
| Bug Blocks: | |||
|
Description
Dennis Payne
2021-10-03 19:37:02 UTC
I'll take this, can you take one of [1] in exchange? [1] https://bugzilla.redhat.com/buglist.cgi?bug_status=NEW&classification=Fedora&component=Package%20Review&email1=manisandro%40gmail.com&emailreporter1=1&emailtype1=substring&list_id=12272348&product=Fedora&query_format=advanced I'd suggest to simplify as
%prep
%setup -q -T -a0 -a1 -a2
%build
mv godot-cpp-godot-3.3.4-stable godot-cpp
rmdir godot-cpp/godot-headers
mv godot-headers-godot-3.3.4-stable godot-cpp/godot-headers
cd godot-cpp
scons platform=linux generate_bindings=yes -j4
cd ../%{name}-%{version}
mkdir bin
scons platform=linux
Spec URL: https://raw.githubusercontent.com/dulsi/gdnativegamerzilla/master/gdnativegamerzilla.spec SRPM URL: http://identicalsoftware.com/gamerzilla/gdnativegamerzilla-0.1-2.fc35.src.rpm I decided to combine your change with some changes suggested on fedora magazine. There is a godot package in fedora, can it be used rather then the separate sources? If not: * You could set a macro %global godot_ver 3.4 and use it for the source URLs and in %setup. The source URLs could be simplified to Source1: https://github.com/godotengine/godot-cpp/archive/godot-%{godot_ver}-stable/godot-cpp-%{godot_ver}-stable.tar.gz Source2: https://github.com/godotengine/godot-headers/archive/godot-%{godot_ver}-stable/godot-headers-%{godot_ver}-stable.tar.gz * The license should be zlib and MIT, as godot-cpp and headers is MIT, and include the godot LICENSE files in %license * You'll need to add Provides: bundled(godot) = %{godot_ver} Furthermore, you could replace mkdir -p %{buildroot}%{_libdir} cp %{name}-%{version}/bin/x11/libgdgamerzilla.so %{buildroot}%{_libdir}/libgdgamerzilla.so with install -Dpm 0755 %{name}-%{version}/bin/x11/libgdgamerzilla.so %{buildroot}%{_libdir}/libgdgamerzilla.so Spec URL: https://raw.githubusercontent.com/dulsi/gdnativegamerzilla/master/gdnativegamerzilla.spec SRPM URL: http://identicalsoftware.com/gamerzilla/gdnativegamerzilla-0.2-1.fc35.src.rpm I didn't want to separate the godot-cpp stuff into a separate package but I knew that was the right solution so I've done that now. @dulsi Still interested in pursuing this? Closed per stalled review policy. The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days |