Bug 2010116
Summary: | Review Request: vim-surround - Delete/change/add parentheses/quotes/XML-tags/much more with ease | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Magnus Morton <magnus> |
Component: | Package Review | Assignee: | Carl George 🤠<carl> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | carl, maxwell, package-review, rcallicotte |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-05-30 00:45:21 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 177841, 201449 |
Description
Magnus Morton
2021-10-03 21:00:01 UTC
I don't have any pointers, but I am hopeful that you find a sponsor and get your package approved soon, because I would really like to have this packaged in Fedora! Unfortunately, I am also a new packager, so I can't sponsor you myself. -- Maxwell Hello, I am a new packager, so this is a an unofficial review. > %install > mkdir -p %{buildroot}%{vimfiles_root} > cp -pr doc plugin %{buildroot}%{vimfiles_root} > > # Install AppData. > mkdir -p %{buildroot}%{appdata_dir} > install -m 644 %{SOURCE1} %{buildroot}%{appdata_dir} I believe this section should reference the macros where applicable. (ie %{__mkdir_p}, %{__cp}, %{__install}). This is a stylistic choice. > %files > %doc README.markdown > %{vimfiles_root}/doc/* > %{vimfiles_root}/plugin/* > %{appdata_dir}/vim-surround.metainfo.xml The contents of the tarball look like this: vim-surround-2.1 ├── doc │  └── surround.txt ├── plugin │  └── surround.vim └── README.markdown The %files section looks like it would assign ownership of all files under %{vimfiles_root}/doc/ and %{vimfiles_root}/plugin/ to this package. The spec should directly reference the names of these files. This will prevent file ownership conflicts. Try this: %{vimfiles_root}/doc/surround.txt %{vimfiles_root}/plugin/surround.vim --Robby > I believe this section should reference the macros where applicable. (ie %{__mkdir_p}, %{__cp}, %{__install}). This is a stylistic choice. Macro forms of system executables SHOULD NOT be used except when there is a need to allow the location of those executables to be configurable. mkdir, cp, and install are the right choice here. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_macros > The spec should directly reference the names of these files. Agreed. The Python guidelines state this explicitly, but it's also a good general guideline. I'm probably going to work on getting a generic form into the main guidelines. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_explicit_lists Here are a few additional things I noticed that should be fixed. The metainfo file should be installed into %{_metainfodir}. -%{appdata_dir}/vim-surround.metainfo.xml +%{_metainfodir}/vim-surround.metainfo.xml https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ It's not directly mentioned in the guidelines, but similar to the patch status guideline, there should be a comment for Source1 linking to where the metainfo file was submitted upstream. https://docs.fedoraproject.org/en-US/packaging-guidelines/PatchUpstreamStatus/ The %post and %postun scriptlets are no longer necessary on Fedora or EPEL8+ due to file triggers in the main vim package. If and only if you plan to add this package to EPEL7, you can keep them with a conditional so they only apply on EPEL7. I suggest following the example of the docfiletriggers conditional in the vim-fugitive spec file. If you remove them, make sure to also remove the corresponding Requires(post) and Requires(postun). https://src.fedoraproject.org/rpms/vim/c/d76e3c95ac644b1ab577bf4db79fb055f218724d https://src.fedoraproject.org/rpms/vim-fugitive/blob/rawhide/f/vim-fugitive.spec Since the review was submitted, upstream has released version 2.2, so the spec file should be updated to that. https://github.com/tpope/vim-surround/releases/tag/v2.2 > I'm probably going to work on getting a generic form into the main guidelines. This is now in the main guidelines. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists Magnus, have you had a chance to incorporate the fixes suggested here to the spec file yet? This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |