Bug 2010259

Summary:

[abrt] dnf: _revert_transaction(): history.py:233:_revert_transaction:KeyError: 'Reason Change'

Product:

[Fedora] Fedora

Reporter:

Kamil Páral <kparal>

Component:

dnf

Assignee:

Lukáš Hrázký <lhrazky>

Status:

CLOSED ERRATA

QA Contact:

Fedora Extras Quality Assurance <extras-qa>

Severity:

unspecified

Docs Contact:

Priority:

unspecified

Version:

CC:

anatoli, brentrbrian, dmach, jmracek, jrohel, kingorgg, kynde, lhrazky, mblaha, mhatina, ogajduse, orion, packaging-team-maint, pkratoch, robatino, rpm-software-management, rrosmanov, saturns_rings, tjamadeira, vmukhame, yann

Target Milestone:

---

Keywords:

Triaged

Target Release:

---

Hardware:

x86_64

OS:

Unspecified

URL:

https://retrace.fedoraproject.org/faf/reports/bthash/c1d7c875b65fb64a600a89eada767ca133ad21ca

Whiteboard:

abrt_hash:f478f4211d9e2ac868426f469f1e0a61d7c074d1;VARIANT_ID=workstation; RejectedBlocker RejectedFreezeException

Fixed In Version:

dnf-4.11.1-1.fc37

Doc Type:

If docs needed, set a value

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2022-03-14 13:09:35 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Attachments:

Description	Flags
File: _var_log_dnf.log	none
File: backtrace	none
File: cpuinfo	none
File: dnf-makecache.log	none
File: environ	none
File: mountinfo	none
File: namespaces	none
File: open_fds	none

Description Kamil Páral 2021-10-04 11:10:27 UTC

Description of problem:
This happens when you try to do "history undo" of a particular transaction. It doesn't affect all transactions. However, the same crash was also reproduced by a colleague of mine, on a similar transaction. I believe it's related to some property of a certain package that was included in both our transactions.

Version-Release number of selected component:
dnf-4.9.0-1.fc35

Additional info:
reporter:       libreport-2.15.2
cgroup:         0::/user.slice/user-1000.slice/user/app.slice/app-org.gnome.Terminal.slice/vte-spawn-e7fed6d0-5710-44dc-9e2f-98c5039d8823.scope
cmdline:        /usr/bin/python3 /usr/bin/dnf history undo 308
crash_function: _revert_transaction
exception_type: KeyError
executable:     /usr/bin/dnf
interpreter:    python3-3.10.0~rc2-1.fc35.x86_64
kernel:         5.14.9-300.fc35.x86_64
runlevel:       N 5
type:           Python3
uid:            0

Truncated backtrace:
#1 [/usr/lib/python3.10/site-packages/dnf/cli/commands/history.py:233] _revert_transaction
#2 [/usr/lib/python3.10/site-packages/dnf/cli/commands/history.py:190] _hcmd_undo
#3 [/usr/lib/python3.10/site-packages/dnf/cli/commands/history.py:342] run
#4 [/usr/lib/python3.10/site-packages/dnf/cli/cli.py:1055] run
#5 [/usr/lib/python3.10/site-packages/dnf/cli/main.py:122] cli_run
#6 [/usr/lib/python3.10/site-packages/dnf/cli/main.py:106] _main
#7 [/usr/lib/python3.10/site-packages/dnf/cli/main.py:67] main
#8 [/usr/lib/python3.10/site-packages/dnf/cli/main.py:201] user_main
#9 [/usr/bin/dnf:58] <module>

Potential duplicate: bug 1966550

Comment 1 Kamil Páral 2021-10-04 11:10:32 UTC

Created attachment 1828907 [details]
File: _var_log_dnf.log

Comment 2 Kamil Páral 2021-10-04 11:10:33 UTC

Created attachment 1828908 [details]
File: backtrace

Comment 3 Kamil Páral 2021-10-04 11:10:35 UTC

Created attachment 1828909 [details]
File: cpuinfo

Comment 4 Kamil Páral 2021-10-04 11:10:37 UTC

Created attachment 1828910 [details]
File: dnf-makecache.log

Comment 5 Kamil Páral 2021-10-04 11:10:38 UTC

Created attachment 1828911 [details]
File: environ

Comment 6 Kamil Páral 2021-10-04 11:10:40 UTC

Created attachment 1828912 [details]
File: mountinfo

Comment 7 Kamil Páral 2021-10-04 11:10:41 UTC

Created attachment 1828913 [details]
File: namespaces

Comment 8 Kamil Páral 2021-10-04 11:10:43 UTC

Created attachment 1828914 [details]
File: open_fds

Comment 9 Kamil Páral 2021-10-04 11:13:25 UTC

The traceback I see in terminal is:

$ sudo dnf history undo 308
Last metadata expiration check: 1:49:41 ago on Mon 04 Oct 2021 11:17:53 AM CEST.
Traceback (most recent call last):
  File "/usr/bin/dnf", line 58, in <module>
    main.user_main(sys.argv[1:], exit_code=True)
  File "/usr/lib/python3.10/site-packages/dnf/cli/main.py", line 201, in user_main
    errcode = main(args)
  File "/usr/lib/python3.10/site-packages/dnf/cli/main.py", line 67, in main
    return _main(base, args, cli_class, option_parser_class)
  File "/usr/lib/python3.10/site-packages/dnf/cli/main.py", line 106, in _main
    return cli_run(cli, base)
  File "/usr/lib/python3.10/site-packages/dnf/cli/main.py", line 122, in cli_run
    cli.run()
  File "/usr/lib/python3.10/site-packages/dnf/cli/cli.py", line 1055, in run
    return self.command.run()
  File "/usr/lib/python3.10/site-packages/dnf/cli/commands/history.py", line 342, in run
    self._hcmd_undo(tids)
  File "/usr/lib/python3.10/site-packages/dnf/cli/commands/history.py", line 190, in _hcmd_undo
    self._revert_transaction(old)
  File "/usr/lib/python3.10/site-packages/dnf/cli/commands/history.py", line 233, in _revert_transaction
    ti["action"] = action_map[ti["action"]]
KeyError: 'Reason Change'


Transaction 308 is:

$ sudo dnf history info 308
Transaction ID : 308
Begin time     : Mon 04 Oct 2021 10:26:26 AM CEST
Begin rpmdb    : 2193:00e73f59d4e0c170898722ea4a0693255b1e5a39
End time       : Mon 04 Oct 2021 10:27:39 AM CEST (73 seconds)
End rpmdb      : 2193:88e7605a2dcfd84bb7c94f5755d7f9b06a2705ba
User           : System <unset>
Return-Code    : Success
Releasever     : 35
Command Line   : system-upgrade upgrade
Comment        : 
Packages Altered:
    Reason Change AtomicParsley-0.9.5-18.fc35.x86_64                      @fedora
    Install       kernel-5.14.9-300.fc35.x86_64                           @fedora
    Install       kernel-core-5.14.9-300.fc35.x86_64                      @fedora
    Install       kernel-modules-5.14.9-300.fc35.x86_64                   @fedora
    Upgrade       audit-3.0.6-1.fc35.x86_64                               @fedora
    Upgraded      audit-3.0.5-1.fc35.x86_64                               @@System
    Upgrade       audit-libs-3.0.6-1.fc35.x86_64                          @fedora
    Upgraded      audit-libs-3.0.5-1.fc35.x86_64                          @@System
    Upgrade       dbus-1:1.12.20-5.fc35.x86_64                            @fedora
    Upgraded      dbus-1:1.12.20-4.fc35.x86_64                            @@System
    Upgrade       dbus-broker-29-4.fc35.x86_64                            @fedora
    Upgraded      dbus-broker-29-3.fc35.x86_64                            @@System
    Upgrade       dbus-common-1:1.12.20-5.fc35.noarch                     @fedora
    Upgraded      dbus-common-1:1.12.20-4.fc35.noarch                     @@System
    Upgrade       dbus-daemon-1:1.12.20-5.fc35.x86_64                     @fedora
    Upgraded      dbus-daemon-1:1.12.20-4.fc35.x86_64                     @@System
    Upgrade       dbus-libs-1:1.12.20-5.fc35.x86_64                       @fedora
    Upgraded      dbus-libs-1:1.12.20-4.fc35.x86_64                       @@System
    Upgrade       dbus-tools-1:1.12.20-5.fc35.x86_64                      @fedora
    Upgraded      dbus-tools-1:1.12.20-4.fc35.x86_64                      @@System
    Upgrade       geoclue2-2.5.7-5.fc35.x86_64                            @fedora
    Upgraded      geoclue2-2.5.7-4.fc35.x86_64                            @@System
    Upgrade       geoclue2-libs-2.5.7-5.fc35.x86_64                       @fedora
    Upgraded      geoclue2-libs-2.5.7-4.fc35.x86_64                       @@System
    Upgrade       glibc-2.34-7.fc35.x86_64                                @fedora
    Upgraded      glibc-2.34-6.fc35.x86_64                                @@System
    Upgrade       glibc-all-langpacks-2.34-7.fc35.x86_64                  @fedora
    Upgraded      glibc-all-langpacks-2.34-6.fc35.x86_64                  @@System
    Upgrade       glibc-common-2.34-7.fc35.x86_64                         @fedora
    Upgraded      glibc-common-2.34-6.fc35.x86_64                         @@System
    Upgrade       glibc-devel-2.34-7.fc35.x86_64                          @fedora
    Upgraded      glibc-devel-2.34-6.fc35.x86_64                          @@System
    Upgrade       glibc-gconv-extra-2.34-7.fc35.x86_64                    @fedora
    Upgraded      glibc-gconv-extra-2.34-6.fc35.x86_64                    @@System
    Upgrade       glibc-headers-x86-2.34-7.fc35.noarch                    @fedora
    Upgraded      glibc-headers-x86-2.34-6.fc35.noarch                    @@System
    Upgrade       glibc-langpack-cs-2.34-7.fc35.x86_64                    @fedora
    Upgraded      glibc-langpack-cs-2.34-6.fc35.x86_64                    @@System
    Upgrade       glibc-langpack-en-2.34-7.fc35.x86_64                    @fedora
    Upgraded      glibc-langpack-en-2.34-6.fc35.x86_64                    @@System
    Upgrade       gnome-terminal-3.42.0-1.fc35.x86_64                     @fedora
    Upgraded      gnome-terminal-3.40.3-1.fc35.x86_64                     @@System
    Upgrade       gnome-terminal-nautilus-3.42.0-1.fc35.x86_64            @fedora
    Upgraded      gnome-terminal-nautilus-3.40.3-1.fc35.x86_64            @@System
    Upgrade       kernel-headers-5.14.9-300.fc35.x86_64                   @fedora
    Upgraded      kernel-headers-5.14.7-300.fc35.x86_64                   @@System
    Upgrade       libcanberra-0.30-26.fc35.x86_64                         @fedora
    Upgraded      libcanberra-0.30-25.fc35.x86_64                         @@System
    Upgrade       libcanberra-gtk2-0.30-26.fc35.x86_64                    @fedora
    Upgraded      libcanberra-gtk2-0.30-25.fc35.x86_64                    @@System
    Upgrade       libcanberra-gtk3-0.30-26.fc35.x86_64                    @fedora
    Upgraded      libcanberra-gtk3-0.30-25.fc35.x86_64                    @@System
    Upgrade       mesa-dri-drivers-21.2.3-1.fc35.x86_64                   @fedora
    Upgraded      mesa-dri-drivers-21.2.2-1.fc35.x86_64                   @@System
    Upgrade       mesa-filesystem-21.2.3-1.fc35.x86_64                    @fedora
    Upgraded      mesa-filesystem-21.2.2-1.fc35.x86_64                    @@System
    Upgrade       mesa-libEGL-21.2.3-1.fc35.x86_64                        @fedora
    Upgraded      mesa-libEGL-21.2.2-1.fc35.x86_64                        @@System
    Upgrade       mesa-libGL-21.2.3-1.fc35.x86_64                         @fedora
    Upgraded      mesa-libGL-21.2.2-1.fc35.x86_64                         @@System
    Upgrade       mesa-libgbm-21.2.3-1.fc35.x86_64                        @fedora
    Upgraded      mesa-libgbm-21.2.2-1.fc35.x86_64                        @@System
    Upgrade       mesa-libglapi-21.2.3-1.fc35.x86_64                      @fedora
    Upgraded      mesa-libglapi-21.2.2-1.fc35.x86_64                      @@System
    Upgrade       mesa-libxatracker-21.2.3-1.fc35.x86_64                  @fedora
    Upgraded      mesa-libxatracker-21.2.2-1.fc35.x86_64                  @@System
    Upgrade       mesa-vulkan-drivers-21.2.3-1.fc35.x86_64                @fedora
    Upgraded      mesa-vulkan-drivers-21.2.2-1.fc35.x86_64                @@System
    Upgrade       mlocate-0.26-31.fc35.x86_64                             @fedora
    Upgraded      mlocate-0.26-30.fc35.x86_64                             @@System
    Upgrade       pipewire-0.3.38-1.fc35.x86_64                           @fedora
    Upgraded      pipewire-0.3.37-1.fc35.x86_64                           @@System
    Upgrade       pipewire-alsa-0.3.38-1.fc35.x86_64                      @fedora
    Upgraded      pipewire-alsa-0.3.37-1.fc35.x86_64                      @@System
    Upgrade       pipewire-gstreamer-0.3.38-1.fc35.x86_64                 @fedora
    Upgraded      pipewire-gstreamer-0.3.37-1.fc35.x86_64                 @@System
    Upgrade       pipewire-jack-audio-connection-kit-0.3.38-1.fc35.x86_64 @fedora
    Upgraded      pipewire-jack-audio-connection-kit-0.3.37-1.fc35.x86_64 @@System
    Upgrade       pipewire-libs-0.3.38-1.fc35.x86_64                      @fedora
    Upgraded      pipewire-libs-0.3.37-1.fc35.x86_64                      @@System
    Upgrade       pipewire-pulseaudio-0.3.38-1.fc35.x86_64                @fedora
    Upgraded      pipewire-pulseaudio-0.3.37-1.fc35.x86_64                @@System
    Upgrade       pipewire-utils-0.3.38-1.fc35.x86_64                     @fedora
    Upgraded      pipewire-utils-0.3.37-1.fc35.x86_64                     @@System
    Upgrade       python3-audit-3.0.6-1.fc35.x86_64                       @fedora
    Upgraded      python3-audit-3.0.5-1.fc35.x86_64                       @@System
    Upgrade       vte-profile-0.66.0-2.fc35.x86_64                        @fedora
    Upgraded      vte-profile-0.64.2-3.fc35.x86_64                        @@System
    Upgrade       vte291-0.66.0-2.fc35.x86_64                             @fedora
    Upgraded      vte291-0.64.2-3.fc35.x86_64                             @@System
    Upgrade       ImageMagick-1:6.9.11.27-7.fc35.x86_64                   @updates-testing
    Upgraded      ImageMagick-1:6.9.11.27-6.fc35.x86_64                   @@System
    Upgrade       ImageMagick-libs-1:6.9.11.27-7.fc35.x86_64              @updates-testing
    Upgraded      ImageMagick-libs-1:6.9.11.27-6.fc35.x86_64              @@System
    Upgrade       cairomm-1.14.2-19.fc35.x86_64                           @updates-testing
    Upgraded      cairomm-1.14.2-17.fc35.x86_64                           @@System
    Upgrade       copr-cli-1.96-1.fc35.noarch                             @updates-testing
    Upgraded      copr-cli-1.95-1.fc35.noarch                             @@System
    Upgrade       distribution-gpg-keys-1.58-1.fc35.noarch                @updates-testing
    Upgraded      distribution-gpg-keys-1.57-1.fc35.noarch                @@System
    Upgrade       gegl04-0.4.30-5.fc35.x86_64                             @updates-testing
    Upgraded      gegl04-0.4.30-4.fc35.x86_64                             @@System
    Upgrade       gimp-2:2.10.24-1.fc35.3.x86_64                          @updates-testing
    Upgraded      gimp-2:2.10.24-1.fc35.2.x86_64                          @@System
    Upgrade       gimp-jxl-plugin-0.5-3.fc35.x86_64                       @updates-testing
    Upgraded      gimp-jxl-plugin-0.5-1.fc35.x86_64                       @@System
    Upgrade       gimp-libs-2:2.10.24-1.fc35.3.x86_64                     @updates-testing
    Upgraded      gimp-libs-2:2.10.24-1.fc35.2.x86_64                     @@System
    Upgrade       gstreamer1-plugins-bad-free-1.19.2-1.fc35.1.x86_64      @updates-testing
    Upgraded      gstreamer1-plugins-bad-free-1.19.2-1.fc35.x86_64        @@System
    Upgrade       ibus-typing-booster-2.14.13-1.fc35.noarch               @updates-testing
    Upgraded      ibus-typing-booster-2.14.12-1.fc35.noarch               @@System
    Upgrade       imath-3.1.2-1.fc35.x86_64                               @updates-testing
    Upgraded      imath-3.0.2-6.fc35.x86_64                               @@System
    Upgrade       intel-mediasdk-21.3.5-1.fc35.x86_64                     @updates-testing
    Upgraded      intel-mediasdk-21.2.3-1.fc35.x86_64                     @@System
    Upgrade       iwl100-firmware-39.31.5.1-123.fc35.noarch               @updates-testing
    Upgraded      iwl100-firmware-39.31.5.1-122.fc35.noarch               @@System
    Upgrade       iwl1000-firmware-1:39.31.5.1-123.fc35.noarch            @updates-testing
    Upgraded      iwl1000-firmware-1:39.31.5.1-122.fc35.noarch            @@System
    Upgrade       iwl105-firmware-18.168.6.1-123.fc35.noarch              @updates-testing
    Upgraded      iwl105-firmware-18.168.6.1-122.fc35.noarch              @@System
    Upgrade       iwl135-firmware-18.168.6.1-123.fc35.noarch              @updates-testing
    Upgraded      iwl135-firmware-18.168.6.1-122.fc35.noarch              @@System
    Upgrade       iwl2000-firmware-18.168.6.1-123.fc35.noarch             @updates-testing
    Upgraded      iwl2000-firmware-18.168.6.1-122.fc35.noarch             @@System
    Upgrade       iwl2030-firmware-18.168.6.1-123.fc35.noarch             @updates-testing
    Upgraded      iwl2030-firmware-18.168.6.1-122.fc35.noarch             @@System
    Upgrade       iwl3160-firmware-1:25.30.13.0-123.fc35.noarch           @updates-testing
    Upgraded      iwl3160-firmware-1:25.30.13.0-122.fc35.noarch           @@System
    Upgrade       iwl3945-firmware-15.32.2.9-123.fc35.noarch              @updates-testing
    Upgraded      iwl3945-firmware-15.32.2.9-122.fc35.noarch              @@System
    Upgrade       iwl4965-firmware-228.61.2.24-123.fc35.noarch            @updates-testing
    Upgraded      iwl4965-firmware-228.61.2.24-122.fc35.noarch            @@System
    Upgrade       iwl5000-firmware-8.83.5.1_1-123.fc35.noarch             @updates-testing
    Upgraded      iwl5000-firmware-8.83.5.1_1-122.fc35.noarch             @@System
    Upgrade       iwl5150-firmware-8.24.2.2-123.fc35.noarch               @updates-testing
    Upgraded      iwl5150-firmware-8.24.2.2-122.fc35.noarch               @@System
    Upgrade       iwl6000-firmware-9.221.4.1-123.fc35.noarch              @updates-testing
    Upgraded      iwl6000-firmware-9.221.4.1-122.fc35.noarch              @@System
    Upgrade       iwl6000g2a-firmware-18.168.6.1-123.fc35.noarch          @updates-testing
    Upgraded      iwl6000g2a-firmware-18.168.6.1-122.fc35.noarch          @@System
    Upgrade       iwl6000g2b-firmware-18.168.6.1-123.fc35.noarch          @updates-testing
    Upgraded      iwl6000g2b-firmware-18.168.6.1-122.fc35.noarch          @@System
    Upgrade       iwl6050-firmware-41.28.5.1-123.fc35.noarch              @updates-testing
    Upgraded      iwl6050-firmware-41.28.5.1-122.fc35.noarch              @@System
    Upgrade       iwl7260-firmware-1:25.30.13.0-123.fc35.noarch           @updates-testing
    Upgraded      iwl7260-firmware-1:25.30.13.0-122.fc35.noarch           @@System
    Upgrade       jxl-pixbuf-loader-0.5-3.fc35.x86_64                     @updates-testing
    Upgraded      jxl-pixbuf-loader-0.5-1.fc35.x86_64                     @@System
    Upgrade       libertas-usb8388-firmware-2:20210919-123.fc35.noarch    @updates-testing
    Upgraded      libertas-usb8388-firmware-2:20210818-122.fc35.noarch    @@System
    Upgrade       libjxl-0.5-3.fc35.x86_64                                @updates-testing
    Upgraded      libjxl-0.5-1.fc35.x86_64                                @@System
    Upgrade       libjxl-utils-0.5-3.fc35.x86_64                          @updates-testing
    Upgraded      libjxl-utils-0.5-1.fc35.x86_64                          @@System
    Upgrade       libraqm-0.7.0-9.fc35.x86_64                             @updates-testing
    Upgraded      libraqm-0.7.0-7.fc34.x86_64                             @@System
    Upgrade       libva-2.13.0-1.fc35.x86_64                              @updates-testing
    Upgraded      libva-2.12.0-2.fc35.x86_64                              @@System
    Upgrade       libva-utils-2.13.0-1.fc35.x86_64                        @updates-testing
    Upgraded      libva-utils-2.12.0-2.fc35.x86_64                        @@System
    Upgrade       linux-firmware-20210919-123.fc35.noarch                 @updates-testing
    Upgraded      linux-firmware-20210818-122.fc35.noarch                 @@System
    Upgrade       linux-firmware-whence-20210919-123.fc35.noarch          @updates-testing
    Upgraded      linux-firmware-whence-20210818-122.fc35.noarch          @@System
    Upgrade       openexr-libs-3.1.1-1.fc35.x86_64                        @updates-testing
    Upgraded      openexr-libs-3.0.5-3.fc35.x86_64                        @@System
    Upgrade       openldap-2.4.59-3.fc35.x86_64                           @updates-testing
    Upgraded      openldap-2.4.59-2.fc35.x86_64                           @@System
    Upgrade       podman-3:3.4.0-1.fc35.x86_64                            @updates-testing
    Upgraded      podman-3:3.4.0-0.11.rc2.fc35.x86_64                     @@System
    Upgrade       podman-gvproxy-3:3.4.0-1.fc35.x86_64                    @updates-testing
    Upgraded      podman-gvproxy-3:3.4.0-0.11.rc2.fc35.x86_64             @@System
    Upgrade       podman-plugins-3:3.4.0-1.fc35.x86_64                    @updates-testing
    Upgraded      podman-plugins-3:3.4.0-0.11.rc2.fc35.x86_64             @@System
    Upgrade       python3-copr-1.113-1.fc35.noarch                        @updates-testing
    Upgraded      python3-copr-1.112-1.fc35.noarch                        @@System
    Removed       kernel-5.14.3-300.fc35.x86_64                           @@System
    Removed       kernel-core-5.14.3-300.fc35.x86_64                      @@System
    Removed       kernel-modules-5.14.3-300.fc35.x86_64                   @@System
Scriptlet output:
   1 Warning: The unit file, source configuration file or drop-ins of mlocate-updatedb.timer changed on disk. Run 'systemctl daemon-reload' to reload units.


Bug 1966550 is very likely the same issue.

Comment 10 Kamil Páral 2021-10-04 11:16:43 UTC

Even though this was detected only with "history undo/rollback" operations so far (also looking at bug 1966550), a crash in DNF is pretty serious for any installed system. I propose this as an F35 blocker. Let's discuss whether it's OK to have history operations broken in certain cases, and whether we're sure this won't affect install/update/remove operations as well.

Comment 11 František Zatloukal 2021-10-05 10:00:15 UTC

Discussed during the 2021-10-04 blocker review meeting: [1]

The decision to classify this bug as an RejectedBlocker and RejectedFreezeException was made:

"The crash here appears to be non-destructive and limited to revert/rollback transactions. So we don't think it violates the release criteria or otherwise qualifies as a blocker. We also think it does not need a freeze exception - there is no great benefit to getting it in the release media, and any change would benefit from the extra time in testing."

[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2021-10-04/f35-blocker-review.2021-10-04-16.02.log.html

Comment 12 Pavla Kratochvilova 2021-10-15 05:56:18 UTC

*** Bug 1966550 has been marked as a duplicate of this bug. ***

Comment 13 Tommi Kyntola 2021-10-25 07:36:20 UTC

Same thing here.

KeyError: 'Reason Change'

Here's my offending transaction preventing a rollback / undo:

Transaction ID : 77
Begin time     : Fri Oct 22 14:38:23 2021
Begin rpmdb    : 2102:b56379f690ed7b829ad69ae36e5b09159bed8650
End time       : Fri Oct 22 14:39:27 2021 (64 seconds)
End rpmdb      : 2102:fb8615b1908ca3099d0434dd3c4c1aeda513bf8c
User           : Kynde <k>
Return-Code    : Success
Releasever     : 34
Command Line   : --refresh upgrade
Comment        : 
Packages Altered:
    Install       kernel-5.14.13-200.fc34.x86_64                    @updates
    Install       kernel-core-5.14.13-200.fc34.x86_64               @updates
    Install       kernel-modules-5.14.13-200.fc34.x86_64            @updates
    Install       kernel-modules-extra-5.14.13-200.fc34.x86_64      @updates
    Upgrade       ghostscript-9.55.0-1.fc34.x86_64                  @updates
    Upgraded      ghostscript-9.54.0-2.1.fc34.x86_64                @@System
    Upgrade       ghostscript-tools-fonts-9.55.0-1.fc34.x86_64      @updates
    Upgraded      ghostscript-tools-fonts-9.54.0-2.1.fc34.x86_64    @@System
    Upgrade       ghostscript-tools-printing-9.55.0-1.fc34.x86_64   @updates
    Upgraded      ghostscript-tools-printing-9.54.0-2.1.fc34.x86_64 @@System
    Upgrade       libgs-9.55.0-1.fc34.x86_64                        @updates
    Upgraded      libgs-9.54.0-2.1.fc34.x86_64                      @@System
    Upgrade       libgusb-0.3.8-1.fc34.x86_64                       @updates
    Upgraded      libgusb-0.3.7-1.fc34.x86_64                       @@System
    Upgrade       libxmlb-0.3.3-1.fc34.x86_64                       @updates
    Upgraded      libxmlb-0.3.2-1.fc34.x86_64                       @@System
    Upgrade       openblas-0.3.18-1.fc34.x86_64                     @updates
    Upgraded      openblas-0.3.17-1.fc34.x86_64                     @@System
    Upgrade       openblas-openmp-0.3.18-1.fc34.x86_64              @updates
    Upgraded      openblas-openmp-0.3.17-1.fc34.x86_64              @@System
    Upgrade       openblas-openmp64-0.3.18-1.fc34.x86_64            @updates
    Upgraded      openblas-openmp64-0.3.17-1.fc34.x86_64            @@System
    Upgrade       ostree-2021.5-2.fc34.x86_64                       @updates
    Upgraded      ostree-2021.4-2.fc34.x86_64                       @@System
    Upgrade       ostree-libs-2021.5-2.fc34.x86_64                  @updates
    Upgraded      ostree-libs-2021.4-2.fc34.x86_64                  @@System
    Upgrade       python-pip-wheel-21.0.1-4.fc34.noarch             @updates
    Upgraded      python-pip-wheel-21.0.1-3.fc34.noarch             @@System
    Upgrade       python3-pip-21.0.1-4.fc34.noarch                  @updates
    Upgraded      python3-pip-21.0.1-3.fc34.noarch                  @@System
    Upgrade       pgadmin4-desktop-6.1-1.fc34.x86_64                @pgAdmin4
    Upgraded      pgadmin4-desktop-6.0-1.fc34.x86_64                @@System
    Upgrade       pgadmin4-server-6.1-1.fc34.x86_64                 @pgAdmin4
    Upgraded      pgadmin4-server-6.0-1.fc34.x86_64                 @@System
    Upgrade       gdal33-libs-3.3.2-1.f34.x86_64                    @pgdg-common
    Upgraded      gdal33-libs-3.3.1-1.f34.x86_64                    @@System
    Upgrade       proj81-8.1.1-1.f34.x86_64                         @pgdg-common
    Upgraded      proj81-8.1.0-1.f34.x86_64                         @@System
    Reason Change AtomicParsley-0.9.5-17.fc34.x86_64                @fedora
    Removed       kernel-5.14.10-200.fc34.x86_64                    @@System
    Removed       kernel-core-5.14.10-200.fc34.x86_64               @@System
    Removed       kernel-modules-5.14.10-200.fc34.x86_64            @@System
    Removed       kernel-modules-extra-5.14.10-200.fc34.x86_64      @@System


The common line seems to be:
    Reason Change AtomicParsley-0.9.5-17.fc34.x86_64                @fedora


Trying to undo other older transactions fail, some gets to Y/N but some fail and they, too, contain:
    Reason Change AtomicParsley-0.9.5-17.fc34.x86_64                   @fedora

I tried removing the AtomicParsley, but that doesn't help.

As for why I'm keen on rolling back there's some new screen flickering bug causing my laptop screen to go berzerk when I'm doing stuff on the external monitor that is absolutely infuriating.

Comment 14 Kamil Páral 2021-11-01 14:28:44 UTC

I'm removing the CommonBugs tag, because since this only occurs on certain rollback transactions and not all, it probably doesn't have enough impact to include it in the CommonBugs document.

Comment 15 Ian 2021-11-13 15:48:06 UTC

Two things seem to be going on here:

1. It seems the dnf cmd doesn't know how to rollback a REASON CHANGE. A quick look at the code shows it is missing a mapping for this in the action_map defined on line 215 of history.py: https://github.com/rpm-software-management/dnf/blob/master/dnf/cli/commands/history.py#L215. However more code may be needed elsewhere to completely fix this.

2. Making the situation worse for those affected is that once installed the AtomicParsley package shows up in every dnf *upgrade* transaction with "REASON CHANGE" even though it's not been updated in months (https://koji.fedoraproject.org/koji/buildinfo?buildID=1673843). I don't know if this is the intended behaviour but it means that once you have this package you can never rollback any future upgrade transaction. On my system AtomicParsley is a 'recommends' of the `youtube-dl` package. It was made a recommend in March/April to fix a bug: https://bugzilla.redhat.com/show_bug.cgi?id=1951630. The commit was: https://src.fedoraproject.org/rpms/youtube-dl/c/124868c95f72c1fe1f391944534a23a7caec3505?branch=rawhide. Note it AtomicParsley only appears this way in dnf upgrade commands, not in dnf update commands.

In the short-term it might be possible to workaround this if only there was a way to remove AtomicParsley from an historic transaction?

Comment 16 Daniel Taylor 2022-01-17 22:32:58 UTC

Similar problem has been detected:

Tried to undo an update with `sudo dnf history undo`, as my terminal crashed midway through updating the kernel, causing it to not update properly.

Had to boot up into a previous kernel version and then just used `sudo dnf reinstall` to update the kernel instead.

Not sure if this can be reproduced or not though.

reporter:       libreport-2.15.2
cgroup:         0::/user.slice/user-1000.slice/user/app.slice/vte-spawn-8348709a-37ea-4382-9d16-f4f18c9ad718.scope
cmdline:        /usr/bin/python3 /usr/bin/dnf history undo 105
crash_function: _revert_transaction
exception_type: KeyError
executable:     /usr/bin/dnf
interpreter:    python3-3.10.1-2.fc35.x86_64
kernel:         5.15.13-200.fc35.x86_64
package:        dnf-4.9.0-1.fc35
reason:         history.py:233:_revert_transaction:KeyError: 'Reason Change'
runlevel:       N 5
type:           Python3
uid:            0

Comment 17 Nicola Sella 2022-01-24 12:51:48 UTC

*** Bug 2043038 has been marked as a duplicate of this bug. ***

Comment 18 Ruslan Osmanov 2022-02-06 23:12:28 UTC

*** Bug 2051292 has been marked as a duplicate of this bug. ***

Comment 19 Lukáš Hrázký 2022-02-17 11:19:50 UTC

*** Bug 1971292 has been marked as a duplicate of this bug. ***

Comment 20 Lukáš Hrázký 2022-02-21 09:55:10 UTC

PRs:
https://github.com/rpm-software-management/dnf/pull/1814
https://github.com/rpm-software-management/libdnf/pull/1447
https://github.com/rpm-software-management/ci-dnf-stack/pull/1071

Comment 21 Fedora Update System 2022-03-14 13:07:07 UTC

FEDORA-2022-e119fcc7d5 has been submitted as an update to Fedora 37. https://bodhi.fedoraproject.org/updates/FEDORA-2022-e119fcc7d5

Comment 22 Fedora Update System 2022-03-14 13:09:35 UTC

FEDORA-2022-e119fcc7d5 has been pushed to the Fedora 37 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 23 Tiago d'Almeida 2022-11-15 18:33:01 UTC

*** Bug 2143003 has been marked as a duplicate of this bug. ***