Bug 2010409

Summary:	Review Request: icebreaker - package re-review
Product:	[Fedora] Fedora	Reporter:	Matthew Miller <mattdm>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mhroncok, ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-09-17 15:13:45 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Matthew Miller 2021-10-04 15:42:01 UTC

Spec URL: https://src.fedoraproject.org/rpms/icebreaker/raw/76cd19fa8e224cbcba6069d27641a21a31868672/f/icebreaker.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mattdm/icebreaker/fedora-35-x86_64/02873701-icebreaker/icebreaker-2.2.0-1.fc35.src.rpm]

Description: IceBreaker is an action-puzzle game in which you must capture penguins from an Antarctic iceberg so they can be shipped to Finland, where they are essential to a secret plot for world domination. To earn the highest Geek Cred, trap them in the smallest space in the shortest time while losing the fewest lives. IceBreaker was inspired by (but is far from an exact clone of) Jezzball by Dima Pavlovsky.

Fedora Account System Username: mattdm


(Note: this is a re-review due to a neglected ftbfs, but that was actually due to something in the build tooling. Builds and runs just fine now without changes from existing spec file.)

Comment 1 Neal Gompa 2021-10-04 15:43:16 UTC

PACKAGE APPROVED.

Comment 2 Miro Hrončok 2021-10-04 16:12:07 UTC

Since this was already approved, some further comments (I'm coming from https://pagure.io/releng/issue/10325#comment-754577):

MUSTs:

0) validate the metainfo.xml file -- see https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/#_app_data_validate_usage


Suggestions (all optional):


1) if you intend to build this in F35 and not just rawhide, you will need to bump the release, as the current version-release has already been built once in Koji

2) make -> %make_build

3) make install -> %make_install

4) cp metainfo.xml -> cp -p metainfo.xml (to preserve the timestamp)

5) don't mix ${RPM_BUILD_ROOT} with %{buildroot} in one spec file (I'd say %{buildroot} is more common in "nowadays" packages)

6) %files ... %{_datadir}/icebreaker -> consider using %{_datadir}/icebreaker/ to indicate this is a directory, to make it easier for the reader of the spec

Comment 3 Matthew Miller 2021-10-04 17:09:53 UTC

Thanks Miro. My intention is to switch to the auto macros, but I'm waiting for the actual repo to be reopened to work on it. :)

I'll take care of the other things.

Comment 4 Package Review 2022-09-17 15:13:45 UTC

Package is now in repositories, closing review.