Bug 2010540
Summary: | HCO.status.relatedObjects are not getting updated with correct resourceVersion of reconciled resources | ||
---|---|---|---|
Product: | Container Native Virtualization (CNV) | Reporter: | Debarati Basu-Nag <dbasunag> |
Component: | Installation | Assignee: | Simone Tiraboschi <stirabos> |
Status: | CLOSED ERRATA | QA Contact: | Debarati Basu-Nag <dbasunag> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 4.9.0 | CC: | cnv-qe-bugs, ibesso, nunnatsa, stirabos |
Target Milestone: | --- | Flags: | nunnatsa:
needinfo+
|
Target Release: | 4.10.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | v4.10.0-218 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-03-16 15:56:11 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Debarati Basu-Nag
2021-10-04 23:40:18 UTC
A quick question: Which one is correct? Option 1) The resource version of an object in relatedObjects must be the latest resource version that is applied by HCO Option 2) The resource version of an object in relatedObjects must be the latest resource version that is observed by HCO If Option 1 -> I found that we don't update status of HCO when reconcilation is not triggered by HCO. This PR fixes that issue https://github.com/kubevirt/hyperconverged-cluster-operator/pull/1558 If Option 2 -> I think it doesn't make sense. We should state what we applied. Also, to be able to implement it, we should reconcile HCO's status for every status change on secondary CRs even when the changes are unrelated to HCO, which seems waste to me. @stirabos @nunnatsa Could you please confirm that we want Option 1. https://github.com/openshift/custom-resource-status/blob/master/objectreferences/README.md is not that clear on this, but yes I think that option 1 should be enough. Update: Debarati found that hco-operator doesn't update status part for PriorityClass object. I am fixing it with this PR: https://github.com/kubevirt/hyperconverged-cluster-operator/pull/1565 Verified against 4.10.0-221 All resources that are managed by HCO (showing up under hco.status.relatedObjects are now getting reconciled. This has been validated by: 1) updating individual resources - add a label to metadata.label 2) watch it getting overritten 3) resource version of the object is updated 4) updated resource version is seen by hco (hco.status.relatedObjects reflects that) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Virtualization 4.10.0 Images security and bug fix update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:0947 |