Bug 201061
Summary: | Review Request: iserverd - Groupware ICQ server clone | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Andy Shevchenko <andy> |
Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2008-02-23 01:47:44 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 201449 |
Description
Andy Shevchenko
2006-08-02 15:56:23 UTC
Updated version here: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/IServerd-2.4.14-2.src.rpm * Thu Aug 03 2006 Andy Shevchenko <andriy.ua> 2.4.14-2 - use full URL for sources I cannot fetch the spec from the above URL. Sorry, wrong permissons. Now I've fixed their. TODO: use fedora-usermgmt for user creation. * Wed Oct 11 2006 Andy Shevchenko <andy.ua> 2.4.14-3.0 - satisfy rpmlint claim: - disable service by default - remove init scripts from the configuration directory - translate README.sysconfig.ru to English Updated version here: ftp://andriy.asplinux.com.ua/pub/people/andy/extras/IServerd-2.4.14-3.0.src.rpm This is terribly old; I don't know why nobody has even commented. I tried to build, but had no luck. It looks to me like the code is not 64-bit clean: database/contacts_db.cpp: In function 'int db_contact_lookup(long unsigned int, int, long unsigned int**)': database/contacts_db.cpp:255: error: cast from 'long unsigned int*' to 'unsigned int' loses precision database/contacts_db.cpp:255: warning: format '%d' expects type 'int', but argument 2 has type 'long unsigned int' make: *** [database/contacts_db.o] Error 1 make: *** Waiting for unfinished jobs.... Please, try the following version: ftp://toaster.asplinux.com.ua/pub/people/andy/extras/IServerd-2.4.14-3.1.src.rpm This still fails to build for me: config/actions/lex.yy.o: In function `input': /builddir/build/BUILD/IServerd-2.4.14/lex.yy.c:1739: undefined reference to `yywrap' config/actions/lex.yy.o: In function `yylex': /builddir/build/BUILD/IServerd-2.4.14/lex.yy.c:1390: undefined reference to `yywrap' collect2: ld returned 1 exit status make: *** [bin/iserverd] Error 1 If you don't have a mock setup, you can still make sure your packages build by doing scratch builds with koji: koji build --scratch dist-f8 whatever.src.rpm I've pushed new upstreamed version here: ftp://toaster.asplinux.com.ua/pub/people/andy/extras/iserverd-2.5.5-1.src.rpm http://koji.fedoraproject.org/koji/taskinfo?taskID=111570 OK, this does indeed build fine. rpmlint spews a tonne of messages, but many of them are non-standard-uid or non-standard-gid errors, which are acceptable in this case as the daemon runs under a special user. What remains: E: iserverd non-readable /etc/iserverd/iserv.conf 0600 E: iserverd non-readable /etc/iserverd/v7_proto.conf 0600 E: iserverd non-readable /etc/iserverd/actions.conf 0600 E: iserverd non-readable /etc/iserverd/v3_proto.conf 0600 E: iserverd non-readable /etc/iserverd/v5_proto.conf 0600 E: iserverd non-readable /etc/iserverd/aim_proto.conf 0600 Obviously these are protected against reads for security reasons. E: iserverd executable-marked-as-config-file /etc/iserverd/iserverd.sh E: iserverd executable-marked-as-config-file /etc/iserverd/db/icquser E: iserverd executable-marked-as-config-file /etc/iserverd/iserverd.sh.asp I'm not sure what these are. Shell scripts can be config files (like /etc/rc.local) so it's possible that this is OK. E: iserverd non-standard-dir-perm /var/run/iserverd 0770 This should be OK. W: iserverd file-not-utf8 /usr/share/doc/iserverd-2.5.5/isdwm-1.4.1.tar.gz This is obviously bogus; tarballs don't have encodings. E: iserverd non-readable /usr/bin/db_manage.sh 0550 E: iserverd non-standard-executable-perm /usr/bin/db_manage.sh 0550 E: iserverd non-standard-executable-perm /usr/bin/convert_db.sh 0550 I'm not sure about these; what's are they used for? Should they be in /usr/libexec instead? W: iserverd service-default-enabled /etc/rc.d/init.d/iserverd This shouldn't be enabled by default, but I note that you chkconfig it off in %post. I don't think you want to do that as then updates will disable the server. Better to patch the initscript if necessary. E: iserverd-debuginfo empty-debuginfo-package This is bad, and frankly I don't see what's causing it. It looks like everything's being compiled with the proper compiler flags; unfortunately I simply don't know enough about find-debuginfo to comprehend why it doesn't find anything. The %preun and %postun scripts are weird. You should add the proper dependencies on /sbin/service so you can assume it exists, and there shouldn't be any reason not to unconditionally stop the daemon. I'm not really sure if it matters but you might want to stop it before calling chkconfig --del. Any progress? It doesn't seem that there's all that much remaining to be fixed, although of course I have not done a full review. It's been another month; closing this out. |