Bug 2011291

Summary: Discover shows a misleading state of Flatpak repos, can't delete disabled repos
Product: [Fedora] Fedora Reporter: Kamil Páral <kparal>
Component: plasma-discoverAssignee: Rex Dieter <rdieter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 35CC: awilliam, bcotton, fzatlouk, geraldo.simiao.kutz, kde-sig, rdieter, robatino
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedBlocker
Fixed In Version: plasma-discover-5.23.0-2.fc35 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-10-21 00:55:06 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1891955    
Attachments:
Description Flags
flatpak repos in Discover
none
error when removing "fedora testing" flatpak repo
none
system journal
none
rpm -qa none

Description Kamil Páral 2021-10-06 10:55:26 UTC 
Description of problem:
I installed a clean system from Fedora-KDE-Live-x86_64-35-20211005.n.0.iso. When I open Discover and go to Settings, I see my flatpak repos under the "Flatpak" section. Both are checked and greyed out (see the screenshot), i.e. I assumed they are both enabled and also can't be configured. But that's not the case:

$ flatpak remotes --show-disabled
fedora	system,oci
fedora-testing	system,disabled,oci

As you can see, only "fedora" is enabled, and "fedora-testing" is disabled. However, Discover shows them both as enabled. That's problem #1.

The fact that they are greyed out seems weird. Why can't I enable/disable them? I'd expect Discover to allow me to do that. Or is that feature not available? That's problem #2.

When I try to delete the repos, I can successfully delete the "fedora" repo. However, if I try to delete "fedora-testing" repo (because disabling doesn't work), I see an error popup:
> Failed to remove fedora-testing remote repository: While opening repository /var/lib/flatpak/repo: opening repo: Can't fetch summary from disabled remote 'fedora-testing'
And in journal it says:
> Oct 06 12:48:10 fedora plasma-discover[2512]: could not list refs in repo "fedora-testing" Can't fetch summary from disabled remote ‘fedora-testing’
> Oct 06 12:48:10 fedora plasma-discover[2512]: ostree_repo_open: assertion 'error == NULL || *error == NULL' failed
> Oct 06 12:48:10 fedora plasma-discover[2512]: qml: Failed to remove the source Fedora Flatpaks (testing)

So while Discover shows a trash icon allowing me to delete a repo, it fails to do so in case of disabled repos. That's problem #3.


Version-Release number of selected component (if applicable):
plasma-discover-5.22.5-1.fc35.x86_64
flatpak-libs-1.11.3-1.fc35.x86_64

How reproducible:
always

Steps to Reproduce:
1. install a clean F35 KDE
2. open Discover -> Settings
3. see that flatpak repos have misleading state (compared to "flatpak remotes --show-disabled")
4. see that flatpak repos can't be enabled/disabled
5. try to remove "fedora testing" flatpak repo, see it fail
Comment 1 Kamil Páral 2021-10-06 10:55:55 UTC 
Created attachment 1829794 [details]
flatpak repos in Discover
Comment 2 Kamil Páral 2021-10-06 10:56:23 UTC 
Created attachment 1829795 [details]
error when removing "fedora testing" flatpak repo
Comment 3 Kamil Páral 2021-10-06 10:56:44 UTC 
Created attachment 1829796 [details]
system journal
Comment 4 Kamil Páral 2021-10-06 10:56:55 UTC 
Created attachment 1829797 [details]
rpm -qa
Comment 5 Kamil Páral 2021-10-06 10:59:19 UTC 
Proposing for a blocker discussion under https://fedoraproject.org/wiki/Fedora_35_Final_Release_Criteria#Default_application_functionality . There are several problems mentioned, perhaps some of them are considered a basic blocking functionality.
Comment 6 Adam Williamson 2021-10-07 19:27:11 UTC 
+4 in https://pagure.io/fedora-qa/blocker-review/issue/512 , marking accepted. Note, we think Kamil's "problem #1" is the worst here. If they can't all be fixed equally easily, that is the one to prioritize; we may not consider the others to be blockers.
Comment 7 Ben Cotton 2021-10-07 20:15:47 UTC 
Does plasma-discover-5.23.0-1.fc35 (update FEDORA-2021-a32a5c05d4) fix this? I know there was a hope that Discover 5.23 would fix several of our Discover blockers.
Comment 8 Adam Williamson 2021-10-07 23:42:55 UTC 
I just tested, and 5.23.0 seems to behave exactly the same as Kamil described, so far as I can tell.
Comment 9 Geraldo Simião 2021-10-10 12:05:20 UTC 
tested here and find same behaviour described by Kamil:

plasma-discover-libs-5.23.0-1.fc35.x86_64
plasma-discover-flatpak-5.23.0-1.fc35.x86_64
plasma-discover-offline-updates-5.23.0-1.fc35.x86_64
plasma-discover-5.23.0-1.fc35.x86_64
plasma-discover-packagekit-5.23.0-1.fc35.x86_64
plasma-discover-notifier-5.23.0-1.fc35.x86_64

flatpak-libs-1.12.0-1.fc35.x86_64
Comment 10 Fedora Update System 2021-10-18 18:37:13 UTC 
FEDORA-2021-3797fcf296 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3797fcf296
Comment 11 František Zatloukal 2021-10-18 19:24:05 UTC 
FEDORA-2021-3797fcf296 fixes problems #1 and #3 . Marking verified for blocker purposes.
Comment 12 Kamil Páral 2021-10-19 07:01:56 UTC 
(In reply to František Zatloukal from comment #11)
> FEDORA-2021-3797fcf296 fixes problems #1 and #3 .

Confirmed.
Comment 13 Fedora Update System 2021-10-21 00:55:06 UTC 
FEDORA-2021-3797fcf296 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.