Bug 2011312

Summary:	Misspelled word in tooltip "Toggel" instead of "Toggle"
Product:	Red Hat Satellite	Reporter:	Ondrej Gajdusek <ogajduse>
Component:	Provisioning Templates	Assignee:	Ron Lavi <rlavi>
Status:	CLOSED ERRATA	QA Contact:	sganar
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.10.0	CC:	gtalreja, mhulan, ofedoren, rlavi
Target Milestone:	6.12.0	Keywords:	EasyFix, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-11-16 13:32:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ondrej Gajdusek 2021-10-06 11:53:36 UTC

Description of problem:
Searchbox of the Ace editor shows a tooltip with the misspelled word "Toggel".

Version-Release number of selected component (if applicable):
6.10.0

How reproducible:
always

Steps to Reproduce:
1. Edit Provisioning/Job template or any other entity editable by the Ace editor.
2. Press Ctrl+F to open the search box
3. Hover over the "+" button in the search bar.

Actual results:
"Toggel replace mode" is shown.

Expected results:
"Toggle replace mode" should be shown instead

Additional info:
This bug comes with the ace editor itself. https://github.com/theforeman/foreman-js/blob/fa2a95042e69c1b4ba6f90809fc255c0eb4e81a0/packages/vendor-core/lib/modules.js#L75
There is an open issue for that upstream: https://github.com/thlorenz/brace/issues/175
PR is opened as well: https://github.com/thlorenz/brace/pull/187

Comment 1 Oleh Fedorenko 2021-11-03 15:35:50 UTC

Well, this is due to brace library that we use for Ace editor [1] and it was fixed in the newer version of react-ace, which uses ace-builds.


[1] - https://github.com/thlorenz/brace/blob/032404bee863470d8fd81a860c227466d48206e2/ext/searchbox.js#L179

@Ron, would it make sense to migrate to a newer version? And can we do that?

Comment 3 Ron Lavi 2021-12-01 19:27:55 UTC

Created redmine issue https://projects.theforeman.org/issues/34062 from this bug

Comment 4 Bryan Kearney 2022-01-24 16:04:49 UTC

Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/34062 has been resolved.

Comment 6 sganar 2022-09-05 16:35:10 UTC

Verified.

Tested on Satellite 6.12.0 Snap 9.0

Steps followed: 
1. Edit Provisioning/Job template or any other entity editable by the Ace editor.
2. Press Ctrl+F to open the search box
3. Hover over the "+" button in the search bar.

Observation: 
"Toggle replace mode" is shown.

Comment 10 errata-xmlrpc 2022-11-16 13:32:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Satellite 6.12 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:8506