Bug 2011335

Summary:	[Machines] Oops in VM's "Network Interface": TypeError: Cannot read properties of undefined (reading 'name')
Product:	Red Hat Enterprise Linux 8	Reporter:	Ulhas Surse <usurse>
Component:	cockpit-appstream	Assignee:	Simon Kobyda <skobyda>
Status:	NEW ---	QA Contact:	Xianghua Chen <xchen>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	8.4	CC:	kkoukiou, mmarusak, sbarcomb, yunyang
Target Milestone:	rc	Flags:	xchen: needinfo? (kkoukiou)
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ulhas Surse 2021-10-06 12:57:16 UTC

Description of problem:
- Edit or new network configuration in guest's interfaces gives the Ooops! error in cockpit. 
- As a result, the VM and the host both hangs and had to reboot. 

Version-Release number of selected component (if applicable):
RHEL 8.2/8.4
KVM host

How reproducible:
Always

Steps to Reproduce:
1. Configure a KVM environment. 
2. Access cockpit interface in any browser. Configure new network interface on a bridge or remove or edit any configuration on KVM cockpit for VM.  
3. The host will be hung

Actual results:
KVM host hangs after changing network configuration from the cockpit. 

Expected results:
Host should not hang. 

Additional info:
Tried with RHVH 4.4.8 and RHVH 4.4.7 (RHEL 8.4) versions.

Comment 3 Martin Pitt 2021-10-07 13:13:24 UTC

Hello Ulhas,

I am afraid this is too vague for investigating. Can you please 

 - describe exactly what you did
 - make a screenshot right before you press the action button that causes the crash, and attach the screenshot here, and open the developer console (Ctrl+Shift+J)
 - after the oops happens: please copy all output from the developer console here; if you still see anything more interesting than a blank page, please add another screenshot.

Which browser are you using? Which RHEL version and architecture?

Thanks!

Comment 4 Ulhas Surse 2021-10-07 14:16:30 UTC

(In reply to Martin Pitt from comment #3)
> Hello Ulhas,
> 
> I am afraid this is too vague for investigating. Can you please 
> 
>  - describe exactly what you did
>  - make a screenshot right before you press the action button that causes
> the crash, and attach the screenshot here, and open the developer console
> (Ctrl+Shift+J)
>  - after the oops happens: please copy all output from the developer console
> here; if you still see anything more interesting than a blank page, please
> add another screenshot.
> 
> Which browser are you using? Which RHEL version and architecture?
> 
> Thanks!

Hi Martin,

The server I was testing crashed after this and i had to rebuild that KVM guest (nested VM) to keep the environment running. This was my test lab env. 
So basically, from the cockpit of KVM host, try to edit any network configuration (try to add or modify the network of the VMs) the Oops page will be displayed. 
I will attach screenshots.

Comment 6 Martin Pitt 2021-10-08 04:34:37 UTC

Thanks! So this is really the "Virtual Machines" page, not the "Networking" one. Can you please still check `rpm -q cockpit-system cockpit-machines`?

Katerina: The stack trace is hard to decipher (due to minimized code), but it seems to me that this crashes somewhere here:
https://github.com/cockpit-project/cockpit/blob/211.3/pkg/machines/reducers.js#L112
That part of the code has not changed significantly, but of course the question is what actually called interfaces()/networks() with that invalid network interface. Any ideas for debugging/reproducing?

Comment 7 Katerina Koukiou 2021-10-08 07:53:34 UTC

In order to reproduce the crash it would be very useful to add here as attachment the XML files of the VMs on your system. (So for each VM virsh -c qemu:///$CONNECTION_NAME dumpxml $VM_NAME > $VM_NAME.xml, or copy them from /etc/libvirt/qemu/ directory if these are on system connection)

Comment 9 Ulhas Surse 2021-12-23 11:26:32 UTC

One more observation is to set the locale from cockpit to "it_IT.UTF-8" and tried to configure the network.