Bug 2011626

Proposed an initial version of the fix for review/discussion: https://review.opendev.org/c/openstack/ironic/+/812795

Fix pulled in https://github.com/openshift/ironic-image/pull/226

Hi Dave. As you now we don't have Supermicro to verify the fix. Could you, please, verify it?

What version of OpenShift contains the fix, so I can plan?

Looking at https://bugzilla.redhat.com/show_bug.cgi?id=2014630, it is not immediately obvious.

the latest 4.10 nightly

[QA Summary]

- Specs of the testing BMC used:

~~~
 Firmware Version	01.00.03
 Firmware Build Time	04/21/2021
 Redfish Version	1.8.0
 BIOS Firmware Version	1.1
 BIOS Build Time	04/29/2021
 CPLD Version	        F1.00.02
~~~

- Confirmed the failure against the API with the old format:

~~~
$ curl --user ADMIN:<PASS> -k -X POST https://192.168.11.82/redfish/v1/Managers/1/VirtualMedia/CD1/Actions/VirtualMedia.InsertMedia -H "Content-Type: application/json" -d '{"Image": "http://192.168.10.96:8080/rhcos-410.84.202201251210-0-live.x86_64.iso?filename=rhcos-410.84.202201251210-0-live.x86_64.iso", "UserName": "", "Password": ""}'
{"error":{"code":"Base.v1_4_0.GeneralError","Message":"A general error has occurred. See ExtendedInfo for more information.","@Message.ExtendedInfo":[{"MessageId":"Base.1.4.PropertyValueFormatError","Severity":"Warning","Resolution":"Correct the value for the property in the request body and resubmit the request if the operation failed.","Message":"The value http://192.168.10.96:8080/rhcos-410.84.202201251210-0-live.x86_64.iso?filename=rhcos-410.84.202201251210-0-live.x86_64.iso for the property Image is of a different format than the property can accept.","MessageArgs":["http://192.168.10.96:8080/rhcos-410.84.202201251210-0-live.x86_64.iso?filename=rhcos-410.84.202201251210-0-live.x86_64.iso","Image"],"RelatedProperties":["[`~#$%&*()=+{}| \t;\"',<>?]"]}]}}
~~~

- Confirmed the successful mount operation (even with very long file names) when using the new format (without `?filename=file.iso` suffix) fixed via[1][2]:

~~~
$ curl --user ADMIN:<PASS> -k -X POST https://192.168.11.82/redfish/v1/Managers/1/VirtualMedia/CD1/Actions/VirtualMedia.InsertMedia -H "Content-Type: application/json" -d '{"Image": "http://192.168.10.96:8080/boot-3aa29d26-c7ea-4c10-8097-99d752297f84-c880f56c-53fa-4c6c-a880-63c7985342f0-4c10-8097-99d752297f84-c880f56c-53fa-4c6c.iso", "UserName": "", "Password": ""}'
{"Accepted":{"code":"Base.v1_4_0.Accepted","Message":"Successfully Accepted Request. Please see the location header and ExtendedInfo for more information.","@Message.ExtendedInfo":[{"MessageId":"SMC.1.0.OemRequestAcceptedMessage","Severity":"Ok","Resolution":"No resolution was required.","Message":"Please also check Task Resource /redfish/v1/TaskService/Tasks/5 to see more information.","MessageArgs":["/redfish/v1/TaskService/Tasks/5"],"RelatedProperties":["VirtualMediaMountAccepted"]}]}}

$ curl --user ADMIN:<PASS> -k -X POST https://192.168.11.82/redfish/v1/Managers/1/VirtualMedia/CD1/Actions/VirtualMedia.EjectMedia -H "Content-Type: application/json" -d '{}'
{"Success":{"code":"Base.v1_4_0.Success","Message":"Successfully Completed Request. See ExtendedInfo for more information.","@Message.ExtendedInfo":[{"MessageId":"SMC.1.0.OemVmUnmounted","Severity":"Ok","Resolution":"No resolution was required.","Message":"The Virtual Media was unmounted successfully.","MessageArgs":[""],"RelatedProperties":[""]}]}}
~~~

[1] - https://github.com/openshift/ironic-image/pull/226
[2] - https://opendev.org/openstack/ironic/commit/e05f74c623d53aecc4a2e097595da8cdbd2607ef

*** PASSED ***

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.10.12 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1601