Bug 2012502
| Summary: | gnome-settings-daemon: subman plugin is disabled incorrectly in CentOS spec | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Andrew Lukoshko <andrew.lukoshko> |
| Component: | gnome-settings-daemon | Assignee: | Carl George 🤠<carl> |
| Status: | CLOSED UPSTREAM | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | CentOS Stream | CC: | bberg, bstinson, carl, feborges, jwboyer, klember, tpopela |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | gnome-settings-daemon-3.32.0-16.el8.0.1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-10-20 12:42:42 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
Possible duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1993424 ? Related, but not a duplicate. I've adjusted the patch ranges to properly conditionalize only the subman patches [0]. Adding this change and the one from bug 1993424 [1] into the RHEL spec file (rather than relying on CentOS to apply the changes after export) will resolve bug 1993424. [0] https://git.centos.org/rpms/gnome-settings-daemon/c/d08116eba7bea3ae2b7f203d295224f619f1e8fd?branch=c8s [1] https://git.centos.org/rpms/gnome-settings-daemon/c/ba1e8ca1339da57aec8238d3529b9e9305541175?branch=c8s @carl why was this bug moved to ON_QA? Who should do the QA work there? I'm trying to look for the build you've mentioned there in internal brew and I fail to find it. The build is done in CentOS koji [0]. My intent was to close this bug out once this was shipped in CentOS Stream 8, and leave bug 1993424 for the RHEL process. We can use both bugs for RHEL if you like. [0] https://koji.mbox.centos.org/koji/buildinfo?buildID=19505 Let's close this ticket then and leave the other one for the RHEL process. Thanks, Carl! |
Description of problem: CentOS spec for gnome-settings-daemon uses %autopatch to skip subman patches this way: %autopatch -p 1 -M 50000 %if %{with subman} %autopatch -p 1 -m 50001 %endif This causes situation where the following non-subman patches are skipped during build: Patch50017: 0017-Update-translations.patch Patch60001: 0001-power-Only-disable-Suspend-Hibernate-actions-inside-.patch Version-Release number of selected component (if applicable): gnome-settings-daemon >= 3.32.0-14.el8 How reproducible: 100% Steps to Reproduce: 1. Take a look at build logs: https://koji.mbox.centos.org/pkgs/packages/gnome-settings-daemon/3.32.0/16.el8/data/logs/x86_64/build.log Actual results: The following patches are missing: Patch50017: 0017-Update-translations.patch Patch60001: 0001-power-Only-disable-Suspend-Hibernate-actions-inside-.patch Expected results: The following patches are applied: Patch50017: 0017-Update-translations.patch Patch60001: 0001-power-Only-disable-Suspend-Hibernate-actions-inside-.patch Additional info: