Bug 2012630

Summary:	ExcludeArch: s390x in libraw1394
Product:	[Fedora] Fedora	Reporter:	Ben Beasley <code>
Component:	libraw1394	Assignee:	Nils Philippsen <nphilipp>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	dan, fenlason, nphilipp
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-10-13 18:01:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	485231

Description Ben Beasley 2021-10-10 20:04:38 UTC

Description of problem:

The spec file for libraw1394 has “ExcludeArch: s390 s390x”.

These exclusions were added in https://src.fedoraproject.org/rpms/libraw1394/c/889042b43f87c8b4cecb508d468f5e04c6f53a31 (in 2002!) and no justification or explanation survives.

The library builds successfully on s390x. If no current justification for the exclusion is known, I request that it be removed.

Version-Release number of selected component (if applicable): 2.1.2-14 (and earlier)


How reproducible:


Steps to Reproduce:
1. Examine the spec file for libraw1394.
2. Observe “ExcludeArch: s390 s390x”

Actual results:

ExcludeArch is present.

Expected results:

ExcludeArch is not present, or is clearly justified.

Additional info:

I have prepared a PR, https://src.fedoraproject.org/rpms/libraw1394/pull-request/4, that would resolve this and take care of a handful of minor housekeeping changes.

This bug is of interest to me because of the vxl → libdc1394 → libraw1394 dependency chain.

Comment 1 Dan Horák 2021-10-13 16:11:44 UTC

The reason for exclusion is that you can't have a Firewire (IEEE 1394) interface on a s390x system. So ideally you should hide the libdc1394 BuildRequire in a %ifnarch condition, if it's an optional dependency (I hope so). If not, then we can build the Firewire libs on s390x.

Comment 2 Ben Beasley 2021-10-13 18:01:46 UTC

Hmm… it looks like the vxl spec file already conditionalizes the libdc1394 dependency as you suggested, and the vxl build failures reported for s390x on the Packager Dashboard are spurious (successful scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=77181927). I’m not sure what to do about that.

Still, I’m glad I asked the question, even if it was half-baked, and I appreciate your answer. It’s helpful to have your response as a clear explanation for the architecture-dependent exclusion.