Bug 2012934

Summary:	[NMCI] ovs_cloned_mac_set_on_iface test fail
Product:	Red Hat Enterprise Linux 9	Reporter:	Vladimir Benes <vbenes>
Component:	NetworkManager	Assignee:	Lubomir Rintel <lrintel>
Status:	CLOSED ERRATA	QA Contact:	Matej Berezny <mberezny>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	9.0	CC:	bgalvani, ferferna, fge, lrintel, mberezny, rkhan, sukulkar, till, wenliang
Target Milestone:	rc	Keywords:	Reopened, Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	NetworkManager-1.36.0-0.4.el9	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	2092212 (view as bug list)		Environment:
Last Closed:	2022-05-17 15:48:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2092212

Description Vladimir Benes 2021-10-11 16:29:22 UTC

Description of problem:
probably a race visible once in 10 or so runs.

Backtrace attached.

Version-Release number of selected component (if applicable):
openvswitch-2.15.0-7.el9.x86_64
NetworkManager-1.33.3-29331.copr.0718c5209b.fc34.x86_64
glib2-2.68.4-1.el9.x86_64

How reproducible:
1/10

Steps to Reproduce:
1. git clone https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci
2. cd NetworkManager-ci
3. test=ovs_cloned_mac_set_on_iface; a=0; while ./test_run.sh $test; do :;((a++)); echo "ATTEMPT $a"; if [ $a -eq 100 ]; then break; fi ; done

Actual results:
crash in a while

Expected results:
robustness

Additional info:

Comment 2 Lubomir Rintel 2021-11-30 12:21:33 UTC

The crash occurred becquse a NDP packet (perhaps a RA) was received on a physical interface while the platform didn't yet see the OVS interface appear.

This has been reworked in NetworkManager/main and _dev_ipac6_ndisc_config_changed() no longer seems to assume we've got an ifindex since this commit:

commit 58287cbcc0c8a4964309e6d528aa65ea508b70d2
Author: Thomas Haller <thaller>
Date:   Fri Aug 6 15:17:05 2021 +0200

    core: rework IP configuration in NetworkManager using layer 3 configuration
    
    Completely rework IP configuration in the daemon. Use NML3Cfg as layer 3
    manager for the IP configuration of an interface. Use NML3ConfigData as
    pieces of configuration that the various components collect and
    configure. NMDevice is managing most of the IP configuration at a higher
    level, that is, it starts DHCP and other IP methods. Rework the state
    handling there.
    
    This is a huge rework of how NetworkManager daemon handles IP
    configuration. Some fallout is to be expected.
    
    It appears the patch deletes many lines of code. That is not accurate, because
    you also have to count the files `src/core/nm-l3*`, which were unused previously.
    
    Co-authored-by: Beniamino Galvani <bgalvani>

The test now seems to work reliably.

Comment 3 Vladimir Benes 2021-12-02 12:07:43 UTC

(In reply to Lubomir Rintel from comment #2)
> The crash occurred becquse a NDP packet (perhaps a RA) was received on a
> physical interface while the platform didn't yet see the OVS interface
> appear.
> 
> This has been reworked in NetworkManager/main and
> _dev_ipac6_ndisc_config_changed() no longer seems to assume we've got an
> ifindex since this commit:
> 
<snip>
closing as current release

Comment 4 Vladimir Benes 2021-12-08 17:16:04 UTC

Sorry the fail is still present,
check it here:
https://desktopqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/beaker-NetworkManager-main-veth-rhel8-upstream/680/artifact/artifacts/FAIL_report_NetworkManager-ci_Test0759_ovs_cloned_mac_set_on_iface.html
https://desktopqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/beaker-NetworkManager-main-veth-rhel8-upstream/715/artifact/artifacts/FAIL_report_NetworkManager-ci_Test0759_ovs_cloned_mac_set_on_iface.html
https://desktopqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/beaker-NetworkManager-main-veth-rhel9-upstream/727/artifact/artifacts/FAIL_report_NetworkManager-ci_Test0759_ovs_cloned_mac_set_on_iface.html
https://desktopqe-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/beaker-NetworkManager-main-veth-rhel9-upstream/734/artifact/artifacts/FAIL_report_NetworkManager-ci_Test0759_ovs_cloned_mac_set_on_iface.html


moving back to assigned

Comment 6 Vladimir Benes 2021-12-09 10:51:02 UTC

and I am even able to reproduce with the latest copr now manually:
NetworkManager-1.35.2-29464.copr.42307a6a67.el8.x86_64

Comment 9 Thomas Haller 2022-01-18 08:49:41 UTC

*** Bug 2029482 has been marked as a duplicate of this bug. ***

Comment 10 Matej Berezny 2022-01-27 11:21:24 UTC

I tested it again with the newest build and test is acting stable, so the issue seems to be resolved.

Comment 13 errata-xmlrpc 2022-05-17 15:48:15 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (new packages: NetworkManager), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:3915