Bug 2012987

Updated to match other reviews.

Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02908384-python-google-cloud-containeranalysis/python-google-cloud-containeranalysis.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02908384-python-google-cloud-containeranalysis/python-google-cloud-containeranalysis-2.6.0-1.fc36.src.rpm

Preliminary finding:

- The metapackage for the [libcst] extra is missing. See
  https://fedoraproject.org/wiki/Changes/PythonExtras#Extras_metapackages.

  Add, somewhere after the base package’s %description (or later):

    %pyproject_extras_subpkg -n python3-%{srcname} libcst

I’ll look at the rest after https://bugzilla.redhat.com/show_bug.cgi?id=2012997.

It looks like this one needs the same fastavro treatment as the -bigquery-storage package. I'll adjust that too.

Okay nevermind on the fastavro changes. My eyes were crossed with the other spec.

However, when I try to add the libcst package to this one, I get a bunch of errors:

----------
Error: The package name contains an extras name `libcst` that was not found in the metadata.
Check if the extras were removed from the project. If so, consider removing the subpackage and obsoleting it from another.

error: Dependency tokens must begin with alpha-numeric, '_' or '/': *** PYTHON_EXTRAS_NOT_FOUND_ERROR___SEE_STDERR ***

Error: The package name contains an extras name `libcst` that was not found in the metadata.
Check if the extras were removed from the project. If so, consider removing the subpackage and obsoleting it from another.

error: Dependency tokens must begin with alpha-numeric, '_' or '/': *** PYTHON_EXTRAS_NOT_FOUND_ERROR___SEE_STDERR ***
Provides: python-google-cloud-containeranalysis+libcst = 2.6.0-1.fc36 python3-google-cloud-containeranalysis+libcst = 2.6.0-1.fc36 python3.10-google-cloud-containeranalysis+libcst = 2.6.0-1.fc36
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1


RPM build errors:
    Dependency tokens must begin with alpha-numeric, '_' or '/': *** PYTHON_EXTRAS_NOT_FOUND_ERROR___SEE_STDERR ***
    Dependency tokens must begin with alpha-numeric, '_' or '/': *** PYTHON_EXTRAS_NOT_FOUND_ERROR___SEE_STDERR ***
----------

A pip install with the [libcst] extra seems to work just fine. I'm still digging in to understand why the subpackage fails.

Well wait, a local install with the libcst extra *does* fail.

➜ pip install ".[libcst]"
Processing /home/major/git/googleapis/python-containeranalysis
  Preparing metadata (setup.py) ... done
WARNING: google-cloud-containeranalysis 2.6.0 does not provide the extra 'libcst'

Even an install from pypi fails:

➜ pip install -U "google-cloud-containeranalysis[libcst]"
Requirement already satisfied: google-cloud-containeranalysis[libcst] in ./testvenv/lib/python3.10/site-packages (2.6.0)
WARNING: google-cloud-containeranalysis 2.6.0 does not provide the extra 'libcst'

Weird. I definitely see it in setup.py. I’ll play with it after bigquery-storage and grafeas.

So the libcst extra works fine with python-google-cloud-redis:

  https://github.com/googleapis/python-redis/blob/863c2e1259aa79c9bb3e2cf916c5dba511b1b80d/setup.py#L39

But it doesn't work with the same code in python-google-cloud-containeranalysis:

  https://github.com/googleapis/python-containeranalysis/blob/978b085e9d8527479329b31784a2d82bec7f1432/setup.py#L37

That's super weird. The lines look identical in both.

It’s a typo; upstream wrote

> extras_requires=…

instead of

> extras_require=…

in setup.py, and setuptools swallows and ignores the wrong keyword without complaining.

This fixes it (in %prep):

> sed -r -i 's/(extras_require)s=/\1=/' setup.py

Could you please report this upstream and patch it downstream?

Oh.
My.
Gosh.

I stared at that setup.py forever and couldn't find the bug. 🤦🏻‍♂️ Good eye!

PR made upstream and noted in the spec.

Spec URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02912567-python-google-cloud-containeranalysis/python-google-cloud-containeranalysis.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mhayden/python-google-cloud/fedora-rawhide-x86_64/02912567-python-google-cloud-containeranalysis/python-google-cloud-containeranalysis-2.6.0-1.fc36.src.rpm

Thanks! Package approved. One trivial spec file typo found; see re-review below.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== Issues =====

- In this line:

    # Upstream has a bug that prevents the libcst exta from installing properly.

  there is a typo (“exta” for “extra”).

  But comments in typos are allowed, of course!


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License 2.0", "*No copyright*
     Apache License 2.0", "Apache License 2.0 [generated file]", "*No
     copyright* [generated file]". 79 files have unknown license. Detailed
     output of licensecheck in /home/reviewer/2012987-python-google-cloud-
     containeranalysis/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/lib/python3.10/site-
     packages/google(python3-google-cloud-billing, python3-google-cloud-
     bigquery, python3-google-cloud-kms, python3-google-cloud-build,
     python3-google-cloud-bigquery-datatransfer, python3-google-cloud-
     redis, python3-google-cloud-appengine-admin, python3-protobuf,
     python3-google-cloud-automl, python3-google-resumable-media,
     python3-google-cloud-iam, python3-googleapis-common-protos,
     python3-google-cloud-access-approval, python3-google-api-core,
     python3-google-cloud-apigee-connect, python3-google-cloud-access-
     context-manager, python3-google-cloud-billing-budgets, python3-google-
     cloud-functions, python3-google-cloud-container, python3-google-cloud-
     firestore, python3-google-cloud-os-config, python3-google-cloud-
     storage, python3-google-cloud-private-ca, python3-google-cloud-org-
     policy, python3-google-cloud-core, python3-google-cloud-bigtable,
     python3-google-cloud-api-gateway, python3-grpc-google-iam-v1,
     python3-google-cloud-asset, python3-google-cloud-spanner),
     /usr/lib/python3.10/site-packages/google/cloud(python3-google-cloud-
     billing, python3-google-cloud-bigquery, python3-google-cloud-kms,
     python3-google-cloud-build, python3-google-cloud-bigquery-
     datatransfer, python3-google-cloud-redis, python3-google-cloud-
     appengine-admin, python3-google-cloud-automl, python3-google-cloud-
     iam, python3-google-cloud-access-approval, python3-google-cloud-
     billing-budgets, python3-google-cloud-apigee-connect, python3-google-
     cloud-functions, python3-google-cloud-container, python3-google-cloud-
     firestore, python3-google-cloud-os-config, python3-google-cloud-
     storage, python3-google-cloud-private-ca, python3-google-cloud-org-
     policy, python3-google-cloud-core, python3-google-cloud-bigtable,
     python3-google-cloud-api-gateway, python3-google-cloud-asset,
     python3-google-cloud-spanner), /usr/lib/python3.10/site-
     packages/google/cloud/devtools(python3-google-cloud-build)

     Ownership of Python namespace package directories is correctly shared.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 92160 bytes in 14 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.

     $ rpm -qL -p results/python3-google-cloud-containeranalysis-2.6.0-1.fc36.noarch.rpm 
     /usr/lib/python3.10/site-packages/google_cloud_containeranalysis-2.6.0.dist-info/LICENSE

[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-google-cloud-containeranalysis , python3-google-cloud-
     containeranalysis+libcst
[x]: Package functions as described.

     (based on tests passing)

[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: python3-google-cloud-containeranalysis-2.6.0-1.fc36.noarch.rpm
          python3-google-cloud-containeranalysis+libcst-2.6.0-1.fc36.noarch.rpm
          python-google-cloud-containeranalysis-2.6.0-1.fc36.src.rpm
python3-google-cloud-containeranalysis+libcst.noarch: W: spelling-error Summary(en_US) Metapackage -> Meta package, Meta-package, Prepackage
python3-google-cloud-containeranalysis+libcst.noarch: W: spelling-error Summary(en_US) containeranalysis -> container analysis, container-analysis, transcontinental
python3-google-cloud-containeranalysis+libcst.noarch: W: spelling-error Summary(en_US) libcst -> glibbest
python3-google-cloud-containeranalysis+libcst.noarch: W: spelling-error %description -l en_US metapackage -> meta package, meta-package, prepackage
python3-google-cloud-containeranalysis+libcst.noarch: W: spelling-error %description -l en_US libcst -> glibbest
python3-google-cloud-containeranalysis+libcst.noarch: W: spelling-error %description -l en_US containeranalysis -> container analysis, container-analysis, transcontinental
python3-google-cloud-containeranalysis+libcst.noarch: W: no-documentation
python-google-cloud-containeranalysis.src: W: patch-not-applied Patch0: python-google-cloud-containeranalysis-mock.patch
python-google-cloud-containeranalysis.src: W: patch-not-applied Patch1: python-google-cloud-containeranalysis-libcst.patch
3 packages and 0 specfiles checked; 0 errors, 9 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Source checksums
----------------
https://github.com/googleapis/python-containeranalysis/archive/v2.6.0/python-containeranalysis-2.6.0.tar.gz :
  CHECKSUM(SHA256) this package     : d379dec8321ad29eac22211d6d1d5e06fd395e9e8f984f610fdb15ba1de19c73
  CHECKSUM(SHA256) upstream package : d379dec8321ad29eac22211d6d1d5e06fd395e9e8f984f610fdb15ba1de19c73


Requires
--------
python3-google-cloud-containeranalysis (rpmlib, GLIBC filtered):
    (python3.10dist(google-api-core) < 3~~dev0 with python3.10dist(google-api-core) >= 1.26)
    (python3.10dist(google-api-core[grpc]) < 3~~dev0 with python3.10dist(google-api-core[grpc]) >= 1.26)
    (python3.10dist(grafeas) < 2~~dev0 with python3.10dist(grafeas) >= 1)
    (python3.10dist(grpc-google-iam-v1) < 0.13~~dev0 with python3.10dist(grpc-google-iam-v1) >= 0.12.3)
    python(abi)
    python3.10dist(packaging)
    python3.10dist(proto-plus)

python3-google-cloud-containeranalysis+libcst (rpmlib, GLIBC filtered):
    python(abi)
    python3-google-cloud-containeranalysis
    python3.10dist(libcst)



Provides
--------
python3-google-cloud-containeranalysis:
    python-google-cloud-containeranalysis
    python3-google-cloud-containeranalysis
    python3.10-google-cloud-containeranalysis
    python3.10dist(google-cloud-containeranalysis)
    python3dist(google-cloud-containeranalysis)

python3-google-cloud-containeranalysis+libcst:
    python-google-cloud-containeranalysis+libcst
    python3-google-cloud-containeranalysis+libcst
    python3.10-google-cloud-containeranalysis+libcst
    python3.10dist(google-cloud-containeranalysis[libcst])
    python3dist(google-cloud-containeranalysis[libcst])



Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 2012987 --mock-options=--enablerepo=local
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, Generic, Python
Disabled plugins: SugarActivity, Haskell, Ocaml, fonts, Perl, Java, PHP, R, C/C++
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

> I stared at that setup.py forever and couldn't find the bug. 🤦🏻‍♂️ Good eye!

An eye that spots things like this is a blessing and a curse! https://xkcd.com/1015/

Oh no, the typo disease is spreading. 😱 Thanks again, Ben. I'll correct that on import.

Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/37369

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-google-cloud-containeranalysis

In rawhide! https://bodhi.fedoraproject.org/updates/FEDORA-2021-13b260f9dd