Bug 2013063

Thank you for the report. There are two issues behind this:

1. Blivet doesn't fully support the new LVM system.devices config file that LVM introduced in 9 Beta. We have a partial workaround, but full support is not yet available in 9 and this is causing the issue you see. The proposed patch fixes this issue so I'm closing this as a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1967212

2. The problem is also in the way you are running the tests. By using "make test" in your script you are running the test suite against the code extracted from the downloaded SRPM without applied patches -- one of the patches we have in RHEL is to force use the libblockdev-lvm plugin instead of libblockdev-lvm-dbus. Only the LVM DBus plugin is affected by the issue described above so this should not be reproducible when running against installed version of blivet. We have a special script for running blivet test suite against the installed version in gating, see https://src.osci.redhat.com/rpms/python-blivet/blob/rhel-9.0.0/f/tests/unit_testing.sh

*** This bug has been marked as a duplicate of bug 1967212 ***

Hi

Hit a error when testing, please help to check if it's expected 


======================================================================
ERROR: test_get_related_disks (devicetree_test.DeviceTreeTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/root/rpmbuild/BUILD/blivet-3.4.0/tests/devicetree_test.py", line 424, in test_get_related_disks
    sdb.format = get_format("lvmpv", device=sdb.path)
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/devices/storage.py", line 780, in <lambda>
    lambda d, f: d._set_format(f),
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/devices/storage.py", line 738, in _set_format
    raise errors.DeviceError("device is too small for new format")
blivet.errors.DeviceError: device is too small for new format

[root@storageqe-67 test_blivet_package]# lsblk
NAME                        MAJ:MIN RM   SIZE RO TYPE MOUNTPOINTS
sda                           8:0    0 558.9G  0 disk 
├─sda1                        8:1    0     1G  0 part /boot
└─sda2                        8:2    0 557.9G  0 part 
  ├─rhel_storageqe--67-root 253:0    0    70G  0 lvm  /
  ├─rhel_storageqe--67-swap 253:1    0  15.6G  0 lvm  [SWAP]
  └─rhel_storageqe--67-home 253:2    0 472.3G  0 lvm  /home
sdb                           8:16   1     0B  0 disk 

[root@storageqe-67 test_blivet_package]# lsscsi 
[0:0:0:0]    disk    Generic- SD/MMC CRW       1.00  /dev/sdb 
[1:0:0:0]    disk    HP       EG000600JWJNP    HPD1  /dev/sda 
[1:0:1:0]    enclosu HPE      Smart Adapter    2.62  -        
[1:2:0:0]    storage HPE      P408i-a SR Gen10 2.62  -        


the sdb is usb CRW, it make the test failed, do you think we need fixed it or remove CRW before testing ?

(In reply to guazhang from comment #2)
> 
> the sdb is usb CRW, it make the test failed, do you think we need fixed it
> or remove CRW before testing ?

The sdb drive with 0 size is causing the issue, but this needs to fixed in the test: https://github.com/storaged-project/blivet/pull/995

Hi

Still hit the error with python3-blivet-3.4.0-11.el9.noarch,libblockdev-2.25-11.el9.x86_64

python3 tests/run_tests.py

======================================================================
ERROR: test_resize (formats_test.lvmpv_test.LVMPVTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.9/site-packages/gi/overrides/BlockDev.py", line 1075, in wrapped
    ret = orig_obj(*args, **kwargs)
  File "/usr/lib64/python3.9/site-packages/gi/overrides/BlockDev.py", line 499, in lvm_pvcreate
    return _lvm_pvcreate(device, data_alignment, metadata_size, extra)
gi.repository.GLib.GError: g-dbus-error-quark: Waiting for 'PvCreate' method of the '/com/redhat/lvmdbus1/Manager' object to finish failed: Failed to get Complete property of the / object: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: Method "Get" with signature "ss" on interface "org.freedesktop.DBus.Properties" doesn't exist
 (19)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/rpmbuild/BUILD/blivet-3.4.0/tests/formats_test/lvmpv_test.py", line 32, in test_resize
    self.fmt.create()
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/formats/__init__.py", line 517, in create
    self._create(**kwargs)
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/formats/lvmpv.py", line 150, in _create
    blockdev.lvm.pvcreate(self.device, data_alignment=self.data_alignment, extra=[ea_yes])
  File "/usr/lib64/python3.9/site-packages/gi/overrides/BlockDev.py", line 1101, in wrapped
    raise transform[1](msg)
gi.overrides.BlockDev.LVMError: Waiting for 'PvCreate' method of the '/com/redhat/lvmdbus1/Manager' object to finish failed: Failed to get Complete property of the / object: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: Method "Get" with signature "ss" on interface "org.freedesktop.DBus.Properties" doesn't exist


======================================================================
ERROR: test_size (formats_test.lvmpv_test.LVMPVTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.9/site-packages/gi/overrides/BlockDev.py", line 1075, in wrapped
    ret = orig_obj(*args, **kwargs)
  File "/usr/lib64/python3.9/site-packages/gi/overrides/BlockDev.py", line 499, in lvm_pvcreate
    return _lvm_pvcreate(device, data_alignment, metadata_size, extra)
gi.repository.GLib.GError: g-dbus-error-quark: Waiting for 'PvCreate' method of the '/com/redhat/lvmdbus1/Manager' object to finish failed: Failed to get Complete property of the / object: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: Method "Get" with signature "ss" on interface "org.freedesktop.DBus.Properties" doesn't exist
 (19)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/root/rpmbuild/BUILD/blivet-3.4.0/tests/formats_test/lvmpv_test.py", line 18, in test_size
    self.fmt.create()
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/formats/__init__.py", line 517, in create
    self._create(**kwargs)
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/root/rpmbuild/BUILD/blivet-3.4.0/blivet/formats/lvmpv.py", line 150, in _create
    blockdev.lvm.pvcreate(self.device, data_alignment=self.data_alignment, extra=[ea_yes])
  File "/usr/lib64/python3.9/site-packages/gi/overrides/BlockDev.py", line 1101, in wrapped
    raise transform[1](msg)
gi.overrides.BlockDev.LVMError: Waiting for 'PvCreate' method of the '/com/redhat/lvmdbus1/Manager' object to finish failed: Failed to get Complete property of the / object: GDBus.Error:org.freedesktop.DBus.Error.UnknownMethod: Method "Get" with signature "ss" on interface "org.freedesktop.DBus.Properties" doesn't exist

Turns out we need some additional changes to make the LVM devices file support work with the LVM DBus API. I have an upstream pull request ready, but because blivet doesn't use LVM DBus API on RHEL I consider this a low priority and we can move the bug to 9.1.

upstream PR: https://github.com/storaged-project/blivet/pull/1010

After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.

We plan to do a rebase of blivet in 9.2 which will include the fix in comment #5, I am reopening this for tracking the issue, but it shouldn't require any additional changes.

After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.