Bug 2013775

Summary:	criu-devel does not depend on protobuf-c-devel even though it references header files from it
Product:	[Fedora] Fedora	Reporter:	Severin Gehwolf <sgehwolf>
Component:	criu	Assignee:	Adrian Reber <adrian>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	adrian, avagin, rstoyanov1
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	criu-3.16.1-2.fc34 criu-3.16.1-2.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-10-27 02:08:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Severin Gehwolf 2021-10-13 17:41:52 UTC

Description of problem:
criu-devel installs criu header files. One of those header files reference a header file from protobuf-c-devel, yet criu-devel doesn't express a dependency on it.

Version-Release number of selected component (if applicable):
criu-devel-3.16-2.fc36.x86_64

How reproducible:
100%

Steps to Reproduce:
$ mock -r fedora-rawhide-x86_64 --install criu-devel
$ mock -r fedora-rawhide-x86_64 --shell
<mock-chroot> sh-5.1# rpm -qf /usr/include/criu/rpc.pb-c.h
criu-devel-3.16-2.fc36.x86_64
<mock-chroot> sh-5.1# grep 'protobuf-c\.h' /usr/include/criu/rpc.pb-c.h
#include <protobuf-c/protobuf-c.h>

Actual results:
$ # rpm -q --requires criu-devel
/usr/bin/pkg-config
criu = 3.16-2.fc36
libcriu.so.2()(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1

Expected results:
$ # rpm -q --requires criu-devel
/usr/bin/pkg-config
protobuf-c-devel
criu = 3.16-2.fc36
libcriu.so.2()(64bit)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1

Additional info:
Libraries which depend on criu-devel for building may fail to build because of that. A work-around is to manually install that protobuf-c-devel dependency.

Comment 1 Adrian Reber 2021-10-13 17:48:03 UTC

Thanks for the report. We will fix it soon. This bug probably also exists in RHEL.

Comment 2 Adrian Reber 2021-10-14 05:42:54 UTC

Maybe doing it upstream using pkgconfig requires would be even better.

Comment 3 Fedora Update System 2021-10-18 17:06:45 UTC

FEDORA-2021-9da5b062e2 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9da5b062e2

Comment 4 Fedora Update System 2021-10-18 17:07:14 UTC

FEDORA-2021-a99d4e8753 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a99d4e8753

Comment 5 Fedora Update System 2021-10-19 00:48:38 UTC

FEDORA-2021-a99d4e8753 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-a99d4e8753`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a99d4e8753

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2021-10-19 10:32:32 UTC

FEDORA-2021-7a364d3533 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-7a364d3533

Comment 7 Fedora Update System 2021-10-19 10:45:03 UTC

FEDORA-2021-87bfbe7d33 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-87bfbe7d33

Comment 8 Fedora Update System 2021-10-19 16:13:12 UTC

FEDORA-2021-87bfbe7d33 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-87bfbe7d33`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-87bfbe7d33

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-10-20 13:47:56 UTC

FEDORA-2021-7a364d3533 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-7a364d3533`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-7a364d3533

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-10-27 02:08:59 UTC

FEDORA-2021-87bfbe7d33 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2021-10-29 23:08:54 UTC

FEDORA-2021-7a364d3533 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.