Bug 2013837

Summary: Improve REX error reporting when uploading script
Product: Red Hat Satellite Reporter: Paul Dudley <pdudley>
Component: Remote ExecutionAssignee: satellite6-bugs <satellite6-bugs>
Status: CLOSED ERRATA QA Contact: Peter Ondrejka <pondrejk>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 6.9.0CC: aruzicka, lstejska
Target Milestone: 6.11.0Keywords: Triaged
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: tfm-rubygem-smart_proxy_remote_execution_ssh-0.5.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-07-05 14:30:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Paul Dudley 2021-10-13 20:54:13 UTC 
Component versions:
satellite-6.9.6.1-1.el7sat.noarch
tfm-rubygem-foreman_remote_execution-4.2.3.1-1.el7sat.noarch

Problem:
When initial file upload encounters messages from stderr REX task sends this message:
~~~
1: Error initializing command: RuntimeError - Unable to upload file to /var/tmp/foreman-ssh-cmd-77a1b01f-74c9-4a93-818e-c0023724c1a0/script on remote system: exit code: PIPE
2: Exit status: EXCEPTION
~~~

This was due to a profile.d script that could have been executed better, here:
~~~
[root@rhel8new ~]# cat /etc/profile.d/test.sh
echo "This is a test message" >&2
~~~

The stderr redirection causes SCP to see the message on login, and this seems to be the reason for the REX failure. For example:
~~~
[root@satellite ~]# scp testscript root.com:/var/tmp/testscript
This is a test message
testscript                                100%   10    11.8KB/s   00:00    
~~~

The root cause is resolved by executing the profile script better. This request is to ask that REX provide more transparency as to the cause of the issue in such a case.
Comment 1 Adam Ruzicka 2022-04-20 13:21:20 UTC 
This seems to be fixed by the move away from net/ssh in smart_proxy_remote_execution_ssh-0.5.0.
Comment 2 Peter Ondrejka 2022-05-02 11:15:31 UTC 
Verified on Satellite 6.11 snap 18. Having the above test script, the rex job does output the redirected message, which doesn't prevent it from executing successfully.
Comment 5 errata-xmlrpc 2022-07-05 14:30:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.11 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:5498