Bug 2014035
Summary: | engine-backup failed in case of "/tmp" doesn't have enough space , no warning is provided to the user regarding out-of-space | ||
---|---|---|---|
Product: | [oVirt] ovirt-engine | Reporter: | Tzahi Ashkenazi <tashkena> |
Component: | Backup-Restore.Engine | Assignee: | Yedidyah Bar David <didi> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Guilherme Santos <gdeolive> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | --- | CC: | bugs |
Target Milestone: | ovirt-4.5.0 | Flags: | pm-rhel:
ovirt-4.5?
|
Target Release: | 4.5.0 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | ovirt-engine-4.5.0 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2022-04-28 09:26:34 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Tzahi Ashkenazi
2021-10-14 10:41:40 UTC
This bug is not very easy to fix, because the pg_dump log goes to the same temporary space of the dump itself, so if this space is exhausted, the log will have no indication either. You can already see this in the example in comment 0 - there are no errors from it. In theory we can try various complex things like keeping it in memory, or elsewhere, or pre-allocate space for the log, but not sure it's worth it. Some other options: - We can add a generic error message, always. - We can check free space on the tmpdir after failures, and error if it's (close to) full. - We can guess that the free space needed is, say, at least 30% of the db size or so, and warn/err/abort if it's not enough. That's just a guess, though - the dump is compressed, and the compression ratio depends on the actual data. We can check the size using 'pg_database_size' (so also from remote), which in the case referenced in comment 0 returned around 19GB. *** Bug 2010075 has been marked as a duplicate of this bug. *** (In reply to Yedidyah Bar David from comment #1) which in the case referenced in comment 0 returned around 19GB. the original size of the DWH db was 33GB when I opened the BZ after I have run on the DWH table > "ovirt_engine_history" > vacuum full analyze in order to decrease the size of the DWH db. (In reply to Tzahi Ashkenazi from comment #3) > (In reply to Yedidyah Bar David from comment #1) > > which in the case referenced in comment 0 returned around 19GB. > > the original size of the DWH db was 33GB when I opened the BZ > after I have run on the DWH table > "ovirt_engine_history" > vacuum full > analyze > in order to decrease the size of the DWH db. This makes sense - I suppose after a full vacuum, 'du' and 'pg_database_size' should be quite similar. We can go with either a generic message or just check free space on error and issue the specific error message. This bugzilla is included in oVirt 4.5.0 release, published on April 20th 2022. Since the problem described in this bug report should be resolved in oVirt 4.5.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |