Bug 201476

Summary:	Review Request: perl-DateTime-Format-HTTP
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Patrice Dumas <pertusus>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/DateTime-Format-HTTP
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-08-07 01:25:46 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 201480

Description Chris Weyl 2006-08-05 23:58:32 UTC

SRPM URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-HTTP-0.36-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-HTTP.spec

Description:
This module provides functions that deal with the date formats used by the
HTTP protocol (and then some).

Comment 1 Patrice Dumas 2006-08-06 12:55:38 UTC

Blocker:
- For t/pod99.t missing BuildRequires: perl(File::Find::Rule)

Remarks:
- the Summary could be more precise, like
HTTP protocol date conversion routines

- no need to 
  mv LICENCE LICENSE
  it is the spec file that must be american english

Otherwise
* rpmlint is silent
* free software, licences included
* meets packaging guidelines
* spec legible
* match upstream
8f40176f012e293743ffbdb42791e40c  ./DateTime-Format-HTTP-0.36.tar.gz
* sane provides:
Provides: perl(DateTime::Format::HTTP) = 0.36
* %files right

If you fix (or explain) the BuildRequires I'll approve

Comment 2 Chris Weyl 2006-08-06 16:23:48 UTC

Additional BuildRequires added; summary updated.

SRPM URL:
http://home.comcast.net/~ckweyl/perl-DateTime-Format-HTTP-0.36-2.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-HTTP.spec

Comment 3 Patrice Dumas 2006-08-06 20:25:03 UTC

The issues have been solved, so

APPROVED

Comment 4 Chris Weyl 2006-08-07 01:25:46 UTC

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4,FC-5)
+Close bug

Thanks for the review! :)