Bug 201477
| Summary: | Review Request: perl-DateTime-Format-Mail | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Weyl <cweyl> |
| Component: | Package Review | Assignee: | Robin Norwood <robin.norwood> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | robin.norwood |
| Target Milestone: | --- | Keywords: | Reopened |
| Target Release: | --- | Flags: | wtogami:
fedora-cvs+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/DateTime-Format-Mail | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2007-07-27 23:19:24 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779, 201480 | ||
|
Description
Chris Weyl
2006-08-06 00:03:48 UTC
A blocker: - For t/pod99.t missing BuildRequires: perl(File::Find::Rule) 4 remarks: - no need to mv LICENCE LICENSE it is the spec file that must be american english - in the man page there is a reference to t/invalid and t/sample_dates, so it may be relevant to package t/ in %doc - I have the habit to add a trailing / to directories in %files for example notes could be notes/ - it may be relevant to contact the upstream about version strings, and try to convince him to have version strings in ascii ascending order (relevant for other DateTime modules) Otherwise * rpmlint warning, may be ignored W: perl-DateTime-Format-Mail strange-permission filter-requires.sh 0755 * free software, licences included * meets packaging guidelines * spec legible * match upstream d3940d6b387b75de0332201db1685e7d ./DateTime-Format-Mail-0.30.tar.gz * sane provides: Provides: perl(DateTime::Format::Mail) = 0.30 * %files right If you fix (or explain) the BuildRequires I'll approve SRPM URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-Mail-0.30-2.fc5.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-DateTime-Format-Mail.spec (In reply to comment #1) > A blocker: > > - For t/pod99.t missing BuildRequires: perl(File::Find::Rule) Addressed above. > 4 remarks: > - no need to > mv LICENCE LICENSE > it is the spec file that must be american english Agreed, but easier to find this way, I think (particularly in an automated fashion). > - in the man page there is a reference to t/invalid and > t/sample_dates, so it may be relevant to package t/ in > %doc Point well taken; added to %doc > - I have the habit to add a trailing / to directories in %files > for example notes could be notes/ Appears directory ownership is maintained properly with this in %doc; changed. > - it may be relevant to contact the upstream about version > strings, and try to convince him to have version strings in ascii > ascending order (relevant for other DateTime modules) I'll drop them a note. The version being filtered here is pretty old, so it might not even be relevant in most cases anymore. > Otherwise [...snip...] > If you fix (or explain) the BuildRequires I'll approve Updated above! :) The remaining issue is fixed, so APPROVED +Import to CVS +Add to owners.list +Bump release, build for devel +devel build succeeds +Request branching (FC-4, FC-5) +Close bug Thanks for the review! Please update: Owner: Robin Norwood <rnorwood> Thanks! And after you change the owner... Package Change Request ====================== Package Name: perl-DateTime-Format-Mail New Branches: EL-4 EL-5 (I assume it's easier for you cvs guys to do both at once. I can file another request if it would be more convenient for you) I don't think this ticket should have been opened; setting back to CLOSED NEXTRELEASE. |