Bug 201485
| Summary: | Review Request: openbabel - Chemistry software file format converter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominik 'Rathann' Mierzejewski <dominik> |
| Component: | Package Review | Assignee: | Paul F. Johnson <paul> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | cweyl |
| Target Milestone: | --- | Flags: | kevin:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-09 23:03:54 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Dominik 'Rathann' Mierzejewski
2006-08-06 00:59:22 UTC
Summary: The IUPAC International Chemical Identifier (InChI^TM) library
The piece in brackets should just read TM. ^TM is causing problems on my
buildsys in mock
For both the main and subpackage
Requires: %{name} = %{version}-%{release}
Needs pkgconfig as well.
%files
%attr(755,root,root) %{_libdir}/%{name}/*.so
Should you not be just claiming the %{name} directory?
rpmlint results openbabel : clean openbabel-devel : W : no docs openbabel-debuginfo : clean inchi : clean inchi-devel : W : no docs inchi-debuginfo : not generated (should it have been?) srpm : rpmlint results openbabel : clean openbabel-devel : W : no docs openbabel-debuginfo : clean inchi : clean inchi-devel : W : no docs inchi-debuginfo : not generated (should it have been?) srpm : clean mock comes up clean once I change the ^TM to just TM in the spec file (this though could just be my system). Once you've addressed the other small issues in #1, I'll do the full review. http://rpm.greysector.net/extras/openbabel.spec http://rpm.greysector.net/extras/openbabel-2.0.2-2.src.rpm - ^TM removed - pkgconfig Req: added - simplified file lists - inchi-debuginfo isn't generated, because all the debuginfo is in openbabel-debuginfo 2.0.2-2 fails to build File not found by glob : /var/tmp/openbabel-2.0.2-2-root-build/usr/lib/libinchi.so.* File not found : /var/tmp/openbabel-2.0.2-2-root-build/usr/lib/include/inchi File not found : /var/tmp/openbabel-2.0.2-2-root-build/usr/lib/libinchi.so This is outside of mock Fixed. I uncommented the defines at the top by accident. Uploaded with the same release, as there's no functional change. I've commented the two defines (_with_perl and _with_python) at the top but still get the same files not being packaged. %defines can't be commented (rpm wart). Instead of doing #%define, do #define or similar. That's why I told you to comment them with #% (hash, percent) explicitly. Good No dupes Compiles cleanly No permission issues No directory ownership problems rpmlint happy packages can compile against it without a problem (xdrawchem used as a test) Has documentation Licences fine Group okay Has R pkgconfig for the devel package APPROVED Package imported and built for devel, FC-4 and FC-5 branches requested. Package Change Request ====================== Package Name: openbabel New Branches: EL-5 cvs done. |