Bug 201493

Summary: Review Request: perl-Module-Starter-PBP
Product: [Fedora] Fedora Reporter: Chris Weyl <cweyl>
Component: Package ReviewAssignee: Patrice Dumas <pertusus>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: pertusus
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Module-Starter-PBP
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-08-08 20:00:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 201491    
Bug Blocks: 163779    

Description Chris Weyl 2006-08-06 07:57:23 UTC
SRPM URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP-0.000003-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP.spec

Description:
This module implements a simple approach to creating modules and their support
files, based on the Module::Starter approach.

When used as a Module::Starter plugin, this module allows you to specify a
simple directory of templates which are filled in with module-specific
information, and thereafter form the basis of your new module.

The default templates that this module initially provides are based on the
recommendations in the book "Perl Best Practices".

Comment 1 Chris Weyl 2006-08-06 07:58:48 UTC
*** Bug 201492 has been marked as a duplicate of this bug. ***

Comment 2 Chris Weyl 2006-08-06 08:32:54 UTC
Update to include an explict requires on perl(Module::Starter::Simple); this
requires was blocked from autodep as it was of the form "use base
Module::Starter::Simple;"

SRPM URL:
http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP-0.000003-2.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP.spec

Comment 3 Patrice Dumas 2006-08-08 14:16:47 UTC
Missing BuildRequires for perl(Test::More)

Comment 4 Chris Weyl 2006-08-08 14:55:57 UTC
perl(Test::More) is a core module, but easy enough to include.

SRPM URL:
http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP-0.000003-3.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Module-Starter-PBP.spec

Comment 5 Patrice Dumas 2006-08-08 15:08:19 UTC
* rpmlint is silent
* package named according to guidelines
* free software, licences not included
* meets packaging guidelines
* spec legible
* source match upstream
2e39d69cd77f64721a875d903a632be3  Module-Starter-PBP-v0.0.3.tar.gz
* sane provides
Provides: perl(Module::Starter::PBP)
* %files right

APPROVED 

Comment 6 Chris Weyl 2006-08-08 20:00:33 UTC
+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
+Close bug

Thanks for the review! :)