Bug 201494 (perl-Smart-Comments)

Summary:	Review Request: perl-Smart-Comments
Product:	[Fedora] Fedora	Reporter:	Chris Weyl <cweyl>
Component:	Package Review	Assignee:	Patrice Dumas <pertusus>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	pertusus
Target Milestone:	---	Flags:	jwboyer: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://search.cpan.org/dist/Smart-Comments
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-08-06 16:15:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Chris Weyl 2006-08-06 08:25:51 UTC

SRPM URL: http://home.comcast.net/~ckweyl/perl-Smart-Comments-1.000002-1.fc5.src.rpm
SPEC URL: http://home.comcast.net/~ckweyl/perl-Smart-Comments.spec

Description:
Smart comments provide an easy way to insert debugging and tracking code into
a program. They can report the value of a variable, track the progress of a
loop, and verify that particular assertions are true.

Best of all, when you're finished debugging, you don't have to remove them.
Simply commenting out the use Smart::Comments line turns them back into
regular comments. Leaving smart comments in your code is smart because if you
needed them once, you'll almost certainly need them again later.

Comment 1 Patrice Dumas 2006-08-06 13:50:57 UTC

A wrong buildrequires
BuildRequires:  perl(version)
crept in...

Comment 2 Patrice Dumas 2006-08-06 14:02:16 UTC

Ooops sorry perl-version is really a package !!

Comment 3 Patrice Dumas 2006-08-06 14:10:08 UTC

* rpmlint is silent
* package named according to guidelines
* free software, without licence files included
* meets packaging guidelines
* spec legible
* source match upstream
658df11ea3e1090a4c673b50860449b3  ./Smart-Comments-v1.0.2.tar.gz
* sane provides
Provides: perl(Smart::Comments)
* %files right

APPROVED

Comment 4 Chris Weyl 2006-08-06 16:15:17 UTC

+Import to CVS
+Add to owners.list
+Bump release, build for devel
+devel build succeeds
+Request branching (FC-4, FC-5)
+Close bug

Thanks for the review! :)

Comment 5 Chris Weyl 2007-04-19 22:44:27 UTC

Please branch for EL-4, EL-5.