Bug 2015306

Summary: list-type missing in oauth.config.openshift.io for identityProviders breaking Server Side Apply
Product: OpenShift Container Platform Reporter: OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component: oauth-apiserverAssignee: Emily Moss <emoss>
Status: CLOSED ERRATA QA Contact: Yash Tripathi <ytripath>
Severity: low Docs Contact:
Priority: medium    
Version: 4.8CC: aos-bugs, mfojtik, slaznick, surbania
Target Milestone: ---   
Target Release: 4.9.z   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2040407 (view as bug list) Environment:
Last Closed: 2022-01-10 08:50:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1992592    
Bug Blocks: 2040407    

Comment 3 liyao 2021-11-04 06:10:25 UTC
Tested in fresh cluster 4.9.0-0.nightly-2021-11-03-204841

Check the CRD and it's found missing atomic list-type is NOT there, seems it's not bumped, moving to ASSIGNED to double check. 

$ oc get CustomResourceDefinition oauths.config.openshift.io -o yaml | grep -A5 -B5 templates
                      description: type identifies the identity provider type for
                        this entry.
                      type: string
                  type: object
                type: array
              templates:
                description: templates allow you to customize pages like the login
                  page.
                properties:
                  error:
                    description: error is the name of a secret that specifies a go
                      template to use to render error pages during the authentication

Comment 4 Sergiusz Urbaniak 2021-11-08 07:01:12 UTC
reviewed-in-sprint: not enough capacity to work on this bugzilla.

Comment 7 Sergiusz Urbaniak 2021-11-26 07:25:27 UTC
I’m adding UpcomingSprint, because I was occupied by fixing bugs with higher priority/severity, developing new features with higher priority, or developing new features to improve stability at a macro level. I will revisit this bug next sprint.

Comment 11 Yash Tripathi 2021-12-31 00:56:16 UTC
Verified on 4.9.0-0.nightly-2021-12-23-045233 by using the following steps
1. oc get CustomResourceDefinition oauths.config.openshift.io -o yaml | rg "x-kubernetes-list-type"
/**snipped**/
         type:
                      description: type identifies the identity provider type for
                        this entry.
                      type: string
                  type: object
                type: array
                x-kubernetes-list-type: atomic
/**snipped**/
2. cat test.yaml
apiVersion: config.openshift.io/v1
kind: OAuth
metadata:
  name: cluster
  labels:
    test-label: test
  managedFields:
  - manager: kubectl
    operation: Apply
    apiVersion: v1
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:labels:
          f:test-label: {}
spec:
  tokenConfig:
    accessTokenInactivityTimeout: 400s
secret: "test"
redirectURIs:
 - "http://www.example.com/"
grantMethod: prompt

3. oc apply -f test.yaml

Observation:
The x-kubernetes-list-type: atomic present in oauths.config.openshift.io CRD shows that server-side apply should work, and that is verified by applying the specified manifest

Comment 14 errata-xmlrpc 2022-01-10 08:50:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.9.13 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:0029

Comment 15 Red Hat Bugzilla 2023-09-15 01:16:20 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days