Bug 2018468

Summary: In an upgraded cluster hco.spec.featureGates.sriovLiveMigration value is not updated to true
Product: Container Native Virtualization (CNV) Reporter: Debarati Basu-Nag <dbasunag>
Component: InstallationAssignee: Simone Tiraboschi <stirabos>
Status: CLOSED ERRATA QA Contact: Debarati Basu-Nag <dbasunag>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.9.0CC: cnv-qe-bugs, kmajcher, stirabos
Target Milestone: ---   
Target Release: 4.9.2   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hco-bundle-registry-container-v4.9.2-4 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-01-19 17:49:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Debarati Basu-Nag 2021-10-29 12:04:47 UTC
Description of problem: for 4.9 fresh installation, by default hco.spec.featureGates.sriovLiveMigration is true. However on an upgraded cluster the value is not updated post upgrade. User needs to set it manually.


Version-Release number of selected component (if applicable):
Seen in 4.8.2->4.9 upgraded clusters

How reproducible:
100%

Steps to Reproduce:
1. Deploy a 4.8.z cluster.
2. Upgrade ocp and then cnv to latest 4.9 build
3. Check hco.spec.featureGates.sriovLiveMigration value is false.

Actual results:
==============
[cnv-qe-jenkins@c01-482c-lqqx4-executor ~]$ kubectl get clusterversion -A
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.9.4     True        False         4h1m    Cluster version is 4.9.4
[cnv-qe-jenkins@c01-482c-lqqx4-executor ~]$ kubectl get csv -A
NAMESPACE                              NAME                                        DISPLAY                       VERSION              REPLACES                                    PHASE
openshift-cnv                          kubevirt-hyperconverged-operator.v4.9.0     OpenShift Virtualization      4.9.0                kubevirt-hyperconverged-operator.v4.8.2     Succeeded
openshift-local-storage                local-storage-operator.4.9.0-202110182323   Local Storage                 4.9.0-202110182323   local-storage-operator.4.8.0-202110121407   Succeeded
openshift-operator-lifecycle-manager   packageserver                               Package Server                0.17.0                                                           Succeeded
openshift-storage                      noobaa-operator.v4.9.0                      NooBaa Operator               4.9.0                                                            Succeeded
openshift-storage                      ocs-operator.v4.9.0                         OpenShift Container Storage   4.9.0                ocs-operator.v4.8.4                         Succeeded
[cnv-qe-jenkins@c01-482c-lqqx4-executor ~]$ 
===========================
featureGates:
      sriovLiveMigration: false
      withHostPassthroughCPU: false
===========================

On a freshly deployed cluster:
===========================
 featureGates:
      sriovLiveMigration: true
      withHostPassthroughCPU: false
===========================

Expected results:
hco.spec.featureGates.sriovLiveMigration should be set to true post upgrade to 4.9.

Additional info:
Please note: On updating hco.spec.featureGates.sriovLiveMigration, it gets set to right value and that gets propagated to kubevirt.

Comment 1 Debarati Basu-Nag 2022-01-14 22:04:23 UTC
Validated against 4.9.2-27: registry-proxy.engineering.redhat.com/rh-osbs/iib:155517
against 4.9.1:
==============
   featureGates:
      sriovLiveMigration: false
      withHostPassthroughCPU: false
    infra: {}
==============
after upgrade to 4.9.2-27:
==============
  featureGates:
      sriovLiveMigration: true
      withHostPassthroughCPU: false
==============

Comment 7 errata-xmlrpc 2022-01-19 17:49:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.9.2 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2022:0191