Bug 2018657

Summary: volume_raid_info detects the wrong data type when the volume created is raid10
Product: Red Hat Enterprise Linux 8 Reporter: ChanghuiZhong <czhong>
Component: libstoragemgmtAssignee: Tony Asleson <tasleson>
Status: CLOSED ERRATA QA Contact: ChanghuiZhong <czhong>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: ---Keywords: Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard:
Fixed In Version: libstoragemgmt-1.9.1-3.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2023804 (view as bug list) Environment:
Last Closed: 2022-05-10 15:21:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version: 1.9.3
Embargoed:
Bug Depends On:    
Bug Blocks: 2023804    

Description ChanghuiZhong 2021-10-30 07:15:04 UTC
Description of problem:

[root@storageqe-07 ~]# lsmcli -u megaraid:// list --type='VOLUMES'
ID                               | Name             | SCSI VPD 0x83                    | Size         | Disabled | Pool ID        | System ID  | Disk Paths
-----------------------------------------------------------------------------------------------------------------------------------------------------------
600605b00281191025f19fff44047047 | VD 0             | 600605b00281191025f19fff44047047 | 145999527936 | No       | SV03104747:DG0 | SV03104747 | /dev/sda  
600605b002811910290e1e1f1bc92463 | VD 1: lsm_raid10 | 600605b002811910290e1e1f1bc92463 | 291999055872 | No       | SV03104747:DG1 | SV03104747 | /dev/sdan 
[root@storageqe-07 ~]# 

[root@storageqe-07 ~]# lsmcli -u megaraid:// volume-raid-info --vol=600605b002811910290e1e1f1bc92463
Traceback (most recent call last):
  File "/usr/lib64/python3.6/site-packages/lsm/lsmcli/cmdline.py", line 72, in cmd_line_wrapper
    cli.process(c)
  File "/usr/lib64/python3.6/site-packages/lsm/lsmcli/cmdline.py", line 2077, in process
    self.args.func(self.args)
  File "/usr/lib64/python3.6/site-packages/lsm/lsmcli/cmdline.py", line 1885, in volume_raid_info
    lsm_vol.id, *self.c.volume_raid_info(lsm_vol))])
  File "/usr/lib64/python3.6/site-packages/lsm/_common.py", line 153, in _present
    return getattr(self.proxied_obj, _proxy_method_name)(*args, **kwargs)
  File "/usr/lib64/python3.6/site-packages/lsm/_common.py", line 600, in inner
    type_compare(func.__name__, types[0], r)
  File "/usr/lib64/python3.6/site-packages/lsm/_common.py", line 559, in type_compare
    type_compare(method_name, exp, act)
  File "/usr/lib64/python3.6/site-packages/lsm/_common.py", line 571, in type_compare
    str(type(act_val))))
TypeError: volume_raid_info call expected: <class 'int'> got: <class 'float'> 
[root@storageqe-07 ~]# 

Version-Release number of selected component (if applicable):
libstoragemgmt-1.9.1-1.el8
libstoragemgmt-1.9.2-4.el9

How reproducible:
100%

Steps to Reproduce:
1.lsmcli -u megaraid:// volume-raid-create --name='lsm_raid10'         --disk=PCYHYLVE --disk=PCYJRHBE --disk=D0A9PA8097CF --disk=D0A9PA8097EV --raid-type='RAID10'

2.lsmcli -u megaraid:// volume-raid-info --vol=600605b002811910290e6e48169fce39


Actual results:
Unable to show the volume raid information,and detected that the volume id's data type is float

Expected results:
Success to show the volume raid information

Additional info:

Comment 3 Tony Asleson 2021-11-05 18:47:40 UTC
Please let me know which version of storcli you're testing with.

Comment 4 ChanghuiZhong 2021-11-06 10:19:41 UTC
(In reply to Tony Asleson from comment #3)
> Please let me know which version of storcli you're testing with.

Hi,Tony

storcli version is storcli-1.23.02-1.noarch.rpm

================================================================================
 Package          Architecture    Version             Repository           Size
================================================================================
Installing:
 storcli          noarch          1.23.02-1           Storage-QE          4.6 M


Thanks

Comment 5 Tony Asleson 2021-11-08 17:32:34 UTC
I'm unable to reproduce using the exact same version or newer versions.

./megaraid_lsmplugin volume-raid-info --vol 600605b00a579620291c11cf076e92d2
Volume ID                        | RAID Type | Strip Size | Disk Count | Minimum I/O Size | Optimal I/O Size
------------------------------------------------------------------------------------------------------------
600605b00a579620291c11cf076e92d2 | RAID10    | 262144     | 4          | 262144           | 524288.0

# rpm -qa | grep storcli
storcli-1.23.02-1.noarch


Please supply the output of
/opt/MegaRAID/storcli/storcli64 /c0/v0 show all J

Thanks

Comment 6 Tony Asleson 2021-11-08 18:10:58 UTC
I was able to re-create, removing request info

Comment 7 ChanghuiZhong 2021-11-09 07:42:17 UTC
I test on this server (storageqe-07.sqe.lab.eng.bos.redhat.com), 
if you want to do more investigation, I can reserve this machine for you


the boot disk:
[root@storageqe-07 ~]# /opt/MegaRAID/storcli/storcli64 /c0/v0 show all J
{
"Controllers":[
{
	"Command Status" : {
		"Controller" : 0,
		"Status" : "Success",
		"Description" : "None"
	},
	"Response Data" : {
		"/c0/v0" : [
			{
				"DG/VD" : "0/0",
				"TYPE" : "RAID0",
				"State" : "Optl",
				"Access" : "RW",
				"Consist" : "Yes",
				"Cache" : "NRWTD",
				"Cac" : "-",
				"sCC" : "ON",
				"Size" : "135.972 GB",
				"Name" : ""
			}
		],
		"PDs for VD 0" : [
			{
				"EID:Slt" : "252:0",
				"DID" : 9,
				"State" : "Onln",
				"DG" : 0,
				"Size" : "135.972 GB",
				"Intf" : "SAS",
				"Med" : "HDD",
				"SED" : "N",
				"PI" : "N",
				"SeSz" : "512B",
				"Model" : "CBRCA146C3ETS0 N",
				"Sp" : "U",
				"Type" : "-"
			}
		],
		"VD0 Properties" : {
			"Strip Size" : "128 KB",
			"Number of Blocks" : 285155328,
			"Span Depth" : 1,
			"Number of Drives Per Span" : 1,
			"Write Cache(initial setting)" : "WriteBack",
			"Disk Cache Policy" : "Disabled",
			"Encryption" : "None",
			"Data Protection" : "None",
			"Active Operations" : "None",
			"Exposed to OS" : "Yes",
			"Creation Date" : "03-03-2020",
			"Creation Time" : "11:08:47 PM",
			"Emulation type" : "default",
			"Is LD Ready for OS Requests" : "Yes",
			"SCSI NAA Id" : "600605b00281191025f19fff44047047"
		}
	}
}
]
}
[root@storageqe-07 ~]# 


new craete raid10:
[root@storageqe-07 ~]# /opt/MegaRAID/storcli/storcli64 /c0/v1 show all J
{
"Controllers":[
{
	"Command Status" : {
		"Controller" : 0,
		"Status" : "Success",
		"Description" : "None"
	},
	"Response Data" : {
		"/c0/v1" : [
			{
				"DG/VD" : "1/1",
				"TYPE" : "RAID10",
				"State" : "Optl",
				"Access" : "RW",
				"Consist" : "No",
				"Cache" : "NRWTD",
				"Cac" : "-",
				"sCC" : "ON",
				"Size" : "271.945 GB",
				"Name" : "lsm_raid10"
			}
		],
		"PDs for VD 1" : [
			{
				"EID:Slt" : "252:1",
				"DID" : 13,
				"State" : "Onln",
				"DG" : 1,
				"Size" : "135.972 GB",
				"Intf" : "SAS",
				"Med" : "HDD",
				"SED" : "N",
				"PI" : "N",
				"SeSz" : "512B",
				"Model" : "CBRCA146C3ETS0 N",
				"Sp" : "U",
				"Type" : "-"
			},
			{
				"EID:Slt" : "252:2",
				"DID" : 12,
				"State" : "Onln",
				"DG" : 1,
				"Size" : "135.972 GB",
				"Intf" : "SAS",
				"Med" : "HDD",
				"SED" : "N",
				"PI" : "N",
				"SeSz" : "512B",
				"Model" : "CBRCA146C3ETS0 N",
				"Sp" : "U",
				"Type" : "-"
			},
			{
				"EID:Slt" : "252:3",
				"DID" : 8,
				"State" : "Onln",
				"DG" : 1,
				"Size" : "135.972 GB",
				"Intf" : "SAS",
				"Med" : "HDD",
				"SED" : "N",
				"PI" : "N",
				"SeSz" : "512B",
				"Model" : "MBD2147RC       ",
				"Sp" : "U",
				"Type" : "-"
			},
			{
				"EID:Slt" : "252:4",
				"DID" : 11,
				"State" : "Onln",
				"DG" : 1,
				"Size" : "135.972 GB",
				"Intf" : "SAS",
				"Med" : "HDD",
				"SED" : "N",
				"PI" : "N",
				"SeSz" : "512B",
				"Model" : "MBD2147RC       ",
				"Sp" : "U",
				"Type" : "-"
			}
		],
		"VD1 Properties" : {
			"Strip Size" : "128 KB",
			"Number of Blocks" : 570310656,
			"Span Depth" : 2,
			"Number of Drives Per Span" : 2,
			"Write Cache(initial setting)" : "WriteBack",
			"Disk Cache Policy" : "Disabled",
			"Encryption" : "None",
			"Data Protection" : "None",
			"Active Operations" : "None",
			"Exposed to OS" : "Yes",
			"Creation Date" : "09-11-2021",
			"Creation Time" : "03:35:34 AM",
			"Emulation type" : "default",
			"Is LD Ready for OS Requests" : "Yes",
			"SCSI NAA Id" : "600605b002811910291ca906595b076e"
		}
	}
}
]
}
[root@storageqe-07 ~]#

Comment 8 ChanghuiZhong 2021-11-11 16:07:32 UTC
Confirm that libstoragemgmt-1.9.1-2.el8 has fixed this issue

# rpm -qa | grep libstoragemgmt
libstoragemgmt-megaraid-plugin-1.9.1-2.el8.noarch
libstoragemgmt-1.9.1-2.el8.x86_64
python3-libstoragemgmt-1.9.1-2.el8.x86_64


# lsmcli -u megaraid:// volume-raid-info --vol=600605b002811910291fb49c702bd5ca
Volume ID                        | RAID Type | Strip Size | Disk Count | Minimum I/O Size | Optimal I/O Size
------------------------------------------------------------------------------------------------------------
600605b002811910291fb49c702bd5ca | RAID10    | 131072     | 4          | 131072           | 262144

Comment 12 ChanghuiZhong 2021-11-16 03:18:08 UTC
test pass with libstoragemgmt-1.9.1-3.el8

# rpm -qa | grep libstoragemgmt
libstoragemgmt-1.9.1-3.el8.x86_64
python3-libstoragemgmt-1.9.1-3.el8.x86_64
libstoragemgmt-megaraid-plugin-1.9.1-3.el8.noarch

:: [ 22:11:49 ] :: [   PASS   ] :: Command 'lsmcli -u megaraid+ssl:// volume-raid-create --name='lsm_raid10'         --disk=PCYHYLVE --disk=PCYJRHBE --disk=D0A9PA8097CF --disk=D0A9PA8097EV         --raid-type='RAID10'' (Expected 0, got 0)
:: [ 22:11:49 ] :: [   PASS   ] :: Command 'lsmcli -u megaraid+ssl:// list --type='VOLUMES'' (Expected 0, got 0)
:: [ 22:11:50 ] :: [   PASS   ] :: Command 'lsmcli -u megaraid+ssl:// volume-raid-info --vol=600605b002811910292597a48f26db92 ' (Expected 0, got 0)

Comment 15 errata-xmlrpc 2022-05-10 15:21:48 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (libstoragemgmt bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:2035