Bug 2018974

Summary: [MTV] cdi-Importer & migration pods and all related resources should be removed when the Plan is Removed
Product: Migration Toolkit for Virtualization Reporter: Amos Mastbaum <amastbau>
Component: ControllerAssignee: Sam Lucidi <slucidi>
Status: ASSIGNED --- QA Contact: Ilanit Stein <istein>
Severity: high Docs Contact: Avital Pinnick <apinnick>
Priority: high    
Version: 2.2.0CC: fdupont, jcall, mguetta
Target Milestone: ---   
Target Release: Future   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2022654 (view as bug list) Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 2022654    

Description Amos Mastbaum 2021-11-01 12:00:26 UTC
Description of problem:

Deleting a Plan (ui+API) doesn't remove the migration importer & migration PODS

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1.Run A successful migration and delete it

Actual results:
cdi-import and the conversion pods are not removed.

Expected results:
cdi-import and the conversion pods should be removed.

Additional info:

Comment 1 Sam Lucidi 2021-11-09 01:05:51 UTC
After talking this over with Jeff, it's clear to me that we can't proceed with the finalizer-based solution I proposed. Jeff mentioned that MTC had the same problem they attempted a finalizer-based solution as well, but finalizers are inherently fraught with issues (race conditions preventing resources from being deleted, etc), and that approach was abandoned. Unfortunately, there's no alternative that would let us archive the plan upon deletion. We should document that the user must archive the plan before deleting it if they want the plan's resources to be removed, and perhaps we could have the UI warn before allowing an unarchived Plan to be deleted.

Comment 2 Ilanit Stein 2021-11-12 10:07:25 UTC
Removed the Blocker bug for MTV-2.2.
UI bug:
Bug 2022651 - [UI] Add the Delete migration plan message that the related resources will remain

Doc bug:
Bug 2022654 - [Doc] cdi-Importer & migration pods and all related resources are not removed when the Plan is Removed

Comment 3 Ilanit Stein 2021-11-16 19:16:05 UTC
When this bug is implemented the Delete Migration plan message in Bug 2022651 will need to change to reflect that deleting the migration plan will delete related resources.