Bug 2019012

Summary:	[mptcpd] stop mptcp service, mptcp settings are still there
Product:	Red Hat Enterprise Linux 9	Reporter:	xmu
Component:	mptcpd	Assignee:	Davide Caratti <dcaratti>
Status:	CLOSED NOTABUG	QA Contact:	xmu
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	9.0	Keywords:	Triaged
Target Milestone:	rc	Flags:	pm-rhel: mirror+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-02-17 10:13:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description xmu 2021-11-01 13:36:49 UTC

Description of problem:

[root@hp-dl380pg8-12 src]# ip mptcp endpoint
[root@hp-dl380pg8-12 src]# ip mptcp limits
add_addr_accepted 0 subflows 0

[root@hp-dl380pg8-12 ~]# systemctl start mptcp
[root@hp-dl380pg8-12 ~]# ip mptcp endpoint
10.73.130.145 id 1 subflow dev eno1
2620:52:0:4982:a2d3:c1ff:fefb:bbbc id 2 subflow dev eno1
[root@hp-dl380pg8-12 ~]# ip mptcp limits
add_addr_accepted 4 subflows 4
[root@hp-dl380pg8-12 ~]# systemctl stop mptcp

[root@hp-dl380pg8-12 ~]# ip mptcp endpoint  <<<<  
10.73.130.145 id 1 subflow dev eno1
2620:52:0:4982:a2d3:c1ff:fefb:bbbc id 2 subflow dev eno1
[root@hp-dl380pg8-12 ~]# ip mptcp limits  <<<< 
add_addr_accepted 4 subflows 4


Version-Release number of selected component (if applicable):
mptcpd-0.8-1.el9.x86_64

How reproducible:
always

Steps to Reproduce:
1. 
systemctl start mptcp
systemctl stop mptcp
ip mptcp endpoint
ip mptcp limits

2.
3.

Actual results:
[root@hp-dl380pg8-12 ~]# ip mptcp endpoint    
10.73.130.145 id 1 subflow dev eno1
2620:52:0:4982:a2d3:c1ff:fefb:bbbc id 2 subflow dev eno1
[root@hp-dl380pg8-12 ~]# ip mptcp limits   
add_addr_accepted 4 subflows 4

Expected results:
[root@hp-dl380pg8-12 src]# ip mptcp endpoint
[root@hp-dl380pg8-12 src]# ip mptcp limits
add_addr_accepted 0 subflows 0

Additional info:

Comment 1 Davide Caratti 2022-07-28 15:23:46 UTC

same happens with upstream mptcpd. Changing this behavior potentially causes all MPTCP to close all subflows (except the initial one that negotiated MPC): maybe it's something we don't actually want. Repurposing for 9.2, but we might actually want to close this as NOTABUG *if* invalid endpoints are flushed when the mptcpd service is started

Comment 3 xmu 2023-02-17 03:37:45 UTC

(In reply to Davide Caratti from comment #1)
> same happens with upstream mptcpd. Changing this behavior potentially causes
> all MPTCP to close all subflows (except the initial one that negotiated
> MPC): maybe it's something we don't actually want. Repurposing for 9.2, but
> we might actually want to close this as NOTABUG *if* invalid endpoints are
> flushed when the mptcpd service is started

Davide,
I agree to close the bug as NOTABUG. Thanks!

Comment 4 Davide Caratti 2023-02-17 10:13:01 UTC

(In reply to xmu from comment #3)

[...]

> Davide,
> I agree to close the bug as NOTABUG. Thanks!

thanks!