Bug 2019206

Summary:	golang-github-prometheus should allow for all commandline options
Product:	[Fedora] Fedora	Reporter:	redhatuser
Component:	golang-github-prometheus	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	34	CC:	eclipseo, go-sig
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	golang-github-prometheus-2.32.1-1.fc36 golang-github-prometheus-2.32.1-1.fc34 golang-github-prometheus-2.32.1-1.fc35 golang-github-prometheus-2.32.1-1.el8	Doc Type:	---
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-16 20:51:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description redhatuser 2021-11-01 20:25:23 UTC

Description of problem:
prometheus.conf and prometheus.service do not support adding additional commandline options. For example, the --storage.tsdb.retention.time option defaults to 15days unless updated.

Version-Release number of selected component (if applicable):
2.30.0-2.fc34.x86_64

How reproducible:
always

Steps to Reproduce:
1. install golang-github-prometheus-2.30.0-2.fc34.x86_64
2. observe only a few options specified in /usr/lib/systemd/system/prometheus.service with nothing for additional commandline options

Actual results:
Commandline options such as --storage.tsdb.retention.time cannot be modified and are stuck at defaults without manually editing the systemd unit and reloading systemctl daemon. This is painful for diskless hosts

Expected results:


Additional info:
Maybe add a $OPTIONS variable as part of the ExecStart in the systemd unit, so that a user can choose to specify additional commandline options in /etc/sysconfig/prometheus without much effort. Thanks

Comment 1 Fedora Update System 2022-01-16 20:50:07 UTC

FEDORA-2022-f3b531a9cc has been submitted as an update to Fedora 36. https://bodhi.fedoraproject.org/updates/FEDORA-2022-f3b531a9cc

Comment 2 Fedora Update System 2022-01-16 20:51:46 UTC

FEDORA-2022-f3b531a9cc has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 3 Fedora Update System 2022-01-16 21:57:45 UTC

FEDORA-2022-077084b1cb has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2022-077084b1cb

Comment 4 Fedora Update System 2022-01-16 21:57:56 UTC

FEDORA-2022-3f5f3fa356 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2022-3f5f3fa356

Comment 5 Fedora Update System 2022-01-17 01:33:07 UTC

FEDORA-EPEL-2022-d652ca9a79 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-d652ca9a79

Comment 6 Fedora Update System 2022-01-17 02:01:00 UTC

FEDORA-2022-3f5f3fa356 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-3f5f3fa356`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-3f5f3fa356

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2022-01-17 02:16:16 UTC

FEDORA-2022-077084b1cb has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2022-077084b1cb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2022-077084b1cb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2022-01-18 01:54:21 UTC

FEDORA-EPEL-2022-d652ca9a79 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-d652ca9a79

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2022-01-25 01:03:18 UTC

FEDORA-2022-077084b1cb has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2022-01-25 01:10:57 UTC

FEDORA-2022-3f5f3fa356 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2022-01-26 00:59:48 UTC

FEDORA-EPEL-2022-d652ca9a79 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.