Bug 2022030

Summary:	Validations callback doesn't properly record details about about validation executions failing due to unreachable hosts
Product:	Red Hat OpenStack	Reporter:	Jiri Podivin <jpodivin>
Component:	validations-common	Assignee:	Jiri Podivin <jpodivin>
Status:	CLOSED WORKSFORME	QA Contact:	nlevinki <nlevinki>
Severity:	low	Docs Contact:
Priority:	low
Version:	17.1 (Wallaby)	CC:	gchamoul, mbultel
Target Milestone:	Alpha	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2023-02-22 15:27:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jiri Podivin 2021-11-10 15:36:14 UTC

Description of problem:
When validation targets a host that is unreachable, but still present in the inventory, it fails and displays the reason in the immediate output after execution, and within the complete display of validations history.

However, when requesting details of the execution, no information or explanatory output is displayed, unless the '--full' flag is provided.




Version-Release number of selected component (if applicable):
16, 17 and builds from current (10-11-2021) master of the validations-libs and validations-common repos.

How reproducible:
Always

Steps to Reproduce:
1. execute validation targeting unreachable host
2. attempt to view the validation results after execution fails


Actual results:
No output is shown.

Expected results:
Reason for failure is displayed. 

Additional info:
Issue should be easy to fix, in the validations-common callback, the validations-json.py, providing method for the case of unreachable host.

Alternatively, validations-libs GetHistory.takeAction method could be refactored to accept results without elements in the 'validation_output' list.
Although I wouldn't consider it to be an ideal outcome.

Comment 1 Jiri Podivin 2021-12-13 12:03:59 UTC

The work on this is delayed until after the callback reorganization is finished.