Bug 202289
| Summary: | doesn't recognize evolution | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthias Clasen <mclasen> | ||||
| Component: | evolution | Assignee: | Matthew Barnes <mbarnes> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | |||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | ||||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2006-09-08 03:38:34 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 150223 | ||||||
| Attachments: |
|
||||||
|
Description
Matthias Clasen
2006-08-12 06:33:38 UTC
ok, so looking through this tangled weave, bug-buddy seems to get the application name indirectly from g_get_prgname(), and this seems to be set to "evolution-2.8" in evolution by passing this string to gnome_program_init() as app_id. Can I propose that we a) don't install an evolution-2.8 binary with an evolution symlink, but just an evolution binary b) pass the string "evolution" to gnome_program_init In evolution/shell/main.c we have:
program = gnome_program_init (PACKAGE "-" BASE_VERSION, ...);
To satisfy part (b) we could just change it to:
program = gnome_program_init (PACKAGE, ...);
Is part (a) then really necessary for bug-buddy to behave correctly?
(Just trying to avoid messing with Makefiles if there's an easier way.)
A separate bug related problem is that bug-buddy seems to think that the human-readable name of the package "evolution" is Calendar. $ bug-buddy --package=evolution Thank you for helping us improving our software. Please fill your suggestions/error information for Calendar application. I'm guessing this is because it's scanning .desktop files looking for the first entry that invokes "evolution", and we have separate menu items for each Evolution component. Calendar just happens to come first. $ grep evolution /usr/share/applications/* | head -n1 redhat-evolution-calendar.desktop:Exec=evolution --component=calendar $ grep Name= /usr/share/applications/redhat-evolution-calendar.desktop Name=Calendar This needs to be a separate bug report, but just wanted to follow up on my last comment with a brain storm. If bug-buddy can extract the program name indirectly from g_get_prgname(), could it not also extract the human-readable application name indirectly from g_get_application_name()? The application name in GLib should be localized, so maybe bug-buddy wouldn't have to go sifting through .desktop files at all. I'll investigate this. That'll be more work, since the data is collected in the libgnomui segv_setup function, and then passed to gnome_segv, which passes it on to bug-buddy Regarding the binary name, thats probably not necessary. The important part is that g_get_ptrname returns the same name that is in the .desktop file. I've filed an upstream bug about related bug-buddy issues here: http://bugzilla.gnome.org/show_bug.cgi?id=353250 Created attachment 135058 [details] Patch to apply the change described in comment #2 This should be in tomorrow's Rawhide as evolution-2.7.92-6.fc6. Seems to work for me. |