Bug 2022907
| Summary: | Review Request: openssl3 - openssl 3.0 for EPEL8 (and possibly older Fedora releases) | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | davide, markus.falb, ngompa13, package-review |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-11-19 00:37:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michel Lind
2021-11-12 23:13:46 UTC
Taking this review. dropping epoch in https://gitlab.com/michel-slm/openssl3/-/commit/b9a3ae826849e8a0dd40744c63973252616548bd per Neal's suggestion, as this is a new package Conflicts with base packages are not allowed in EPEL, so you're going to need to make adjustments to eliminate the conflicts in all the generated packages. That includes renaming the binaries to have a "3" suffix, adjusting all the file paths to not conflict, etc. You can see an incomplete example of this for the EPEL7 openssl11 package: https://src.fedoraproject.org/rpms/openssl11/blob/db04e041f681575aab2a322512dd612c53b1106f/f/openssl11.spec#_420-456 In your case, you'll also need to deal with the Perl stuff too, since it's different in OpenSSL 3. (In reply to Neal Gompa from comment #3) > Conflicts with base packages are not allowed in EPEL, so you're going to > need to make adjustments to eliminate the conflicts in all the generated > packages. > > That includes renaming the binaries to have a "3" suffix, adjusting all the > file paths to not conflict, etc. > > You can see an incomplete example of this for the EPEL7 openssl11 package: > https://src.fedoraproject.org/rpms/openssl11/blob/ > db04e041f681575aab2a322512dd612c53b1106f/f/openssl11.spec#_420-456 > > In your case, you'll also need to deal with the Perl stuff too, since it's > different in OpenSSL 3. Thanks, I'll rework this @Neal ok, updated now, borrowed the renaming code from openssl11. Confirmed that all the packages can now be installed in parallel. delta: https://gitlab.com/michel-slm/openssl3/-/commit/334ce5921b82294622c2a198b6b5f6c186c0a767 Installed: openssl3-3.0.0-3.el8.1.x86_64 openssl3-debuginfo-3.0.0-3.el8.1.x86_64 openssl3-debugsource-3.0.0-3.el8.1.x86_64 openssl3-devel-3.0.0-3.el8.1.x86_64 openssl3-libs-3.0.0-3.el8.1.x86_64 openssl3-libs-debuginfo-3.0.0-3.el8.1.x86_64 Installed: keyutils-libs-devel-1.5.10-9.el8.x86_64 krb5-devel-1.18.2-14.el8.x86_64 libcom_err-devel-1.45.6-2.el8.x86_64 libkadm5-1.18.2-14.el8.x86_64 libselinux-devel-2.9-5.el8.x86_64 libsepol-devel-2.9-3.el8.x86_64 libverto-devel-0.3.0-5.el8.x86_64 openssl-devel-1:1.1.1k-4.el8.x86_64 pcre2-devel-10.32-2.el8.x86_64 pcre2-utf16-10.32-2.el8.x86_64 pcre2-utf32-10.32-2.el8.x86_64 zlib-devel-1.2.11-17.el8.x86_64 Instead of using "%exclude" to exclude files from all subpackages, please delete them in %install phase. That keeps it compatible with latest versions of RPM which do not allow that behavior anymore. Oh, just realized I have two excludes left. Yanked. https://gitlab.com/michel-slm/openssl3/-/commit/b2de50c5285f46693912b932a1fbd8cfad83f0de Review notes: - Packaging follows naming guidelines - Package licensing is indicated correctly - Packaging builds and installs - Packages do not conflict with base RHEL packages - No serious issues from rpmlint PACKAGE APPROVED. thanks! $ fedpkg request-repo openssl3 2022907 https://pagure.io/releng/fedora-scm-requests/issue/37609 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/openssl3 $ fedpkg request-branch epel8 https://pagure.io/releng/fedora-scm-requests/issue/37626 FEDORA-EPEL-2021-ff6e908f7e has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-ff6e908f7e FEDORA-EPEL-2021-ff6e908f7e has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. |