Bug 2023085

- package name is OK
I think the name is OK, but I expect users will want to say 'dnf install xq'. So please add Provides:xq.

- license is acceptable for Fedora (MIT)
- license is specified correctly
- latest version:
Please update to 0.0.6 (released 20h ago ;))

- builds and installs OK
- seems to work as expected
- the standard go template is used
- BR/P/R look OK (apart from the note above…)

Suggestion:
install -m 0755 -vd                     %{buildroot}%{_bindir}
install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
→
install -Dpvt %{buildroot}%{_bindir}/ %{gobuilddir}/bin/*

rpmlint:
golang-github-sibprogrammer-xq.src: W: spelling-error Summary(en_US) jq -> j, q, sq
golang-github-sibprogrammer-xq.src: W: spelling-error %description -l en_US jq -> j, q, sq
golang-github-sibprogrammer-xq.src:56: W: macro-in-%changelog %autochangelog
golang-github-sibprogrammer-xq.x86_64: W: spelling-error Summary(en_US) jq -> j, q, sq
golang-github-sibprogrammer-xq.x86_64: W: spelling-error %description -l en_US jq -> j, q, sq
golang-github-sibprogrammer-xq.x86_64: W: no-manual-page-for-binary xq
golang-github-sibprogrammer-xq-devel.noarch: W: spelling-error Summary(en_US) jq -> j, q, sq
golang-github-sibprogrammer-xq-devel.noarch: W: spelling-error %description -l en_US jq -> j, q, sq
golang-github-sibprogrammer-xq-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/sibprogrammer/xq/.goipath
5 packages and 0 specfiles checked; 0 errors, 9 warnings.
All bogus.

Package is APPROVED. Please see some notes above.

Thanks for reviewing Zbigniew!

> - package name is OK
> I think the name is OK, but I expect users will want to say 'dnf install xq'. So please add Provides:xq.

I did it wrong. Package should be named xq.spec directly, as with other go packages and as the name of the BZ shows.

> install -m 0755 -vd                     %{buildroot}%{_bindir}
> install -m 0755 -vp %{gobuilddir}/bin/* %{buildroot}%{_bindir}/
> →
> install -Dpvt %{buildroot}%{_bindir}/ %{gobuilddir}/bin/*

This comes from go2rpm, maybe the change needs to go to that package so everyone applies the same.

I updated the spec with correct name:

Spec URL: https://mikel.olasagasti.info/tmp/fedora/xq.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/xq-0.0.6-1.fc35.src.rpm

I don't think the name changing changes the review, so I'm requesting the repo. If you think I should create a nwe BZ or alike let me know.

> This comes from go2rpm, maybe the change needs to go to that package so everyone applies the same.

Oh, OK. Yeah, then it's better to leave it as is.

> I updated the spec with correct name:
> I don't think the name changing changes the review, so I'm requesting the repo. If you think I should create a nwe BZ or alike let me know.

Yep, it's all good.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/xq

FEDORA-2021-dcc8f652f2 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-dcc8f652f2

FEDORA-2021-594822c195 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-594822c195 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-594822c195

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-dcc8f652f2 has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-dcc8f652f2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-dcc8f652f2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2021-594822c195 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

FEDORA-2021-dcc8f652f2 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.