Bug 202319
Summary: | Review Request: perl-Data-Compare - Compare perl data structures | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jose Pedro Oliveira <jose.p.oliveira.oss> |
Component: | Package Review | Assignee: | Chris Weyl <cweyl> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-08-16 14:41:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 202318 | ||
Bug Blocks: | 163779 |
Description
Jose Pedro Oliveira
2006-08-12 18:58:35 UTC
+ package meets naming and packaging guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + source files match upstream: 874a13f201c6948e84867f82d950907a Data-Compare-0.13.tar.gz 874a13f201c6948e84867f82d950907a Data-Compare-0.13.tar.gz.srpm + latest version is being packaged. + BuildRequires are proper. package builds in mock ( ). + rpmlint is silent. + final provides and requires are sane: == provides perl(Data::Compare) = 0.13 perl(Data::Compare::Plugins::Scalar::Properties) = 1.0 perl-Data-Compare = 0.13-1.fc5 == requires perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Data::Compare) perl(Exporter) perl(File::Find::Rule) perl(strict) perl(vars) perl(warnings) + no shared libraries are present. + package is not relocatable. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + %clean is present. + All tests successful. Files=7, Tests=76, 1 wallclock secs ( 0.55 cusr + 0.20 csys = 0.75 CPU) %check is present and all tests pass: + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. + not a web app. APPROVED Thanks for the review. Imported and built for FC-5 and devel. |