Bug 2023514

Summary:	Review Request: package-notes - Generate a linker script to insert .note.package section
Product:	[Fedora] Fedora	Reporter:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Component:	Package Review	Assignee:	Sandro Mani <manisandro>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	manisandro, package-review
Target Milestone:	---	Flags:	manisandro: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	package-notes-0.4-1.fc36	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-21 17:05:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Zbigniew Jędrzejewski-Szmek 2021-11-15 22:45:04 UTC

Spec URL: http://in.waw.pl/~zbyszek/fedora/package-notes.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/package-notes-0.4~0.git33c3dfa-1.20211115git33c3dfa.fc36.src.rpm
Description:
This package provides a generator of linker scripts that insert
a section with a note with a JSON payload that describes the
package the binary was built for.

For https://fedoraproject.org/wiki/Changes/Package_information_on_ELF_objects.

Fedora Account System Username: zbyszek

Note: I packages a snapshot version because there are some outstanding patches. The version will change to 0.4 before this is actually built in Fedora.

Comment 1 Sandro Mani 2021-11-16 12:36:55 UTC

- Requires are sane
- Provides are sane
- License field is correct
- Might want to add %doc README.md
- Might want to add %license debian/copyright, as no other LICENSE exists? Ideally add a matching LICENSE upstream.
- Spec is sane
- No real issues signaled by rpmlint

Approved

Comment 2 Zbigniew Jędrzejewski-Szmek 2021-11-16 16:28:46 UTC

> Might want to add %doc README.md

I looked at it, and it doesn't contain anything useful really (some basic packaging instructinos, which
we don't need in a package).

> Might want to add %license debian/copyright, as no other LICENSE exists?

Yeah, we'll need to probably add some license text for clarity. But CC-0 doesn't require the
text to be present. Maybe a link instead.

Comment 3 Zbigniew Jędrzejewski-Szmek 2021-11-21 17:05:28 UTC

Built in rawhide. We might want to backport this to other branches, but we need to figure out more details first.