Bug 202398

Okay, I'll give you a review.

MUST ITEMS:
 * rpmlint doesn't show anything
 * package is named good
 * ! improper spec file name, change it to python-musicbrainz2.spec
 * package meets Packaging Guidelines
 * package is licensed with open-source compatible license (BSD)
 * license file is included in %doc
 * spec file is written in American English
 * spec file is legible
 * upstream md5sum matches md5sum of the source used to build the
package (2ff59193f357c84e9e7b2f89356c0939)
 * BR is listed properly
 * there is no locales
 * there is no need to ldconfig
 * package is not designed to be relocatable
 * package own directories correctly
 * permissions are set correctly
 * package has a good %clean section
 * package handles macros properly
 * there is no need to -doc subpackage
 * %doc doesn't affect runtime
 * there is no need to -devel subpackage
 * package doesn't contain any .la files
 * no gui

WHAT TO DO:
 * correct spec file name, only to show that it is correct ;)
 * package owns test command, so you should add %check section
to spec file and run %{__python} setup.py test in it

If you do what I mention above, I'll approve this package.

> WHAT TO DO:
>  * correct spec file name, only to show that it is correct ;)

The spec file is renamed on the web site so that I can keep multiple revisions
online.  The spec file inside the SRPM is named according to the guidelines.

>  * package owns test command, so you should add %check section
> to spec file and run %{__python} setup.py test in it

Done.  In addition, I noticed that there are a couple of more packages that are
Required for full functionality.

Spec: 
http://repo.ocjtech.us/misc/fedora/development/SRPMS/python-musicbrainz2-0.3.1-2.fc6.spec
SRPM:
http://repo.ocjtech.us/misc/fedora/development/SRPMS/python-musicbrainz2-0.3.1-2.fc6.src.rpm

%changelog
* Wed Aug 16 2006 Jeffrey C. Ollie <jeff> - 0.3.1-2
- Add Requires for python-ctypes and libmusicbrainz.
- Add check section.

 

(In reply to comment #2)
> The spec file is renamed on the web site so that I can keep multiple revisions
> online.  The spec file inside the SRPM is named according to the guidelines.
Right.

Okay, now everything looks fine.
Approved.

Thanks for the review... sorry for the late acknowledgement.  Imported into CVS
and built....

Package Change Request
======================
Package Name: python-musicbrainz2
Updated Fedora Owners: alexlan

cvs done.

(In reply to comment #5)
> Package Change Request
> ======================
> Package Name: python-musicbrainz2
> Updated Fedora Owners: alexlan

Hi Jeffrey: I thought you were going to make me a co-maintainer... ;)  That's
fine to make me a primary maintainer, would you consider remaining as a
co-maintainer?

(In reply to comment #7)
> (In reply to comment #5)
> > Package Change Request
> > ======================
> > Package Name: python-musicbrainz2
> > Updated Fedora Owners: alexlan
> 
> Hi Jeffrey: I thought you were going to make me a co-maintainer... ;)  That's
> fine to make me a primary maintainer, would you consider remaining as a
> co-maintainer?

Oops... yes I did not mean to drop myself as a maintainer :)  Please submit a
request to add myself back.

(In reply to comment #8)
> > Hi Jeffrey: I thought you were going to make me a co-maintainer... ;)  That's
> > fine to make me a primary maintainer, would you consider remaining as a
> > co-maintainer?
> 
> Oops... yes I did not mean to drop myself as a maintainer :)  Please submit a
> request to add myself back.

Even easier: I just added myself as a co-maintainer (and approved myself), now I
can orphan the package and you can (re-)claim it.

(In reply to comment #9)

> > Oops... yes I did not mean to drop myself as a maintainer :)  Please submit a
> > request to add myself back.
> 
> Even easier: I just added myself as a co-maintainer (and approved myself), now I
> can orphan the package and you can (re-)claim it.

i.e. in pkgdb:

https://admin.fedoraproject.org/pkgdb/packages/name/python-musicbrainz2