Bug 2024433

Summary:	CustomNoUpgrade should not fire no-upgrade failures
Product:	OpenShift Container Platform	Reporter:	OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component:	Test Framework	Assignee:	Pierre Prinetti <pprinett>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pierre Prinetti <pprinett>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.9	CC:	bleanhar, wking
Target Milestone:	---
Target Release:	4.9.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-12-07 17:52:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1998029
Bug Blocks:

Comment 1 W. Trevor King 2021-11-18 05:25:46 UTC

To help out CI-search and Sippy, this should fix 4.9 failures like [1]:

: [sig-arch][Early] Managed cluster should start all core operators [Skipped:Disconnected] [Suite:openshift/conformance/parallel]
Run #0: Failed	1s
  fail [github.com/onsi/ginkgo.0-origin.0+incompatible/internal/leafnodes/runner.go:113]: Nov 18 03:53:11.275: Some cluster operators are not ready: kube-apiserver (Upgradeable=False FeatureGates_RestrictedFeatureGates_TechPreviewNoUpgrade: FeatureGatesUpgradeable: "TechPreviewNoUpgrade" does not allow updates)

[1]: https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-ci-4.9-e2e-aws-techpreview/1461167575890137088

Comment 3 Pierre Prinetti 2021-12-07 16:45:12 UTC

Tentatively setting to VERIFIED.

Comment 4 W. Trevor King 2021-12-07 17:52:17 UTC

Doesn't need to get linked to an errata, so I'm closing CURRENTRELEASE.  Evidence that this backport improved things:

  $ w3m -dump -cols 200 'https://search.ci.openshift.org/?maxAge=48h&type=junit&search=cluster+operators+are+not+ready:+kube-apiserver.*Upgradeable=False' | grep 'failures match' | sort
  ...no hits..

while taking a deeper history to reach back before the backport landed gives plenty of hits:

  $ w3m -dump -cols 200 'https://search.ci.openshift.org/?maxAge=336h&type=junit&search=cluster+operators+are+not+ready:+kube-apiserver.*Upgradeable=False' | grep 'failures match' | sort
  periodic-ci-openshift-release-master-ci-4.9-e2e-aws-techpreview (all) - 42 runs, 86% failed, 78% of failures match = 67% impact
  periodic-ci-openshift-release-master-ci-4.9-e2e-aws-techpreview-serial (all) - 42 runs, 93% failed, 77% of failures match = 71% impact
  ...