Bug 2025318
| Summary: | Review Request: godot-cpp-devel - Godot native C++ interface | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dennis Payne <dulsi> | ||||
| Component: | Package Review | Assignee: | Sandro Mani <manisandro> | ||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | manisandro, package-review | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2022-01-17 00:45:28 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 201449, 2010111 | ||||||
| Attachments: |
|
||||||
|
Description
Dennis Payne
2021-11-21 16:48:12 UTC
Can you add a comment explaining the reason for ExcludeArch? I should go back and add that to gdnativegamerzilla. The package has file "%{_libdir}/libgodot-cpp.linux.release.64.a". On a 32 bit platform that would be .32.a but I don't know a simple way to specify that in the spec file. Also I don't know that it can generate successfully for 32 platforms. The sample SConstruct that was adapted for gdnativegamerzilla has "only support 64 at this time..". I suspect it would work on a 32-bit platform but have not tested it.
I'd just add it this as a comment and yes, then also gdnativegamerzilla needs to have ExcludeArch. What about other arches? I don't know. I was trying to find a list of architectures and which are 32 bits but my searches failed me. I figure if it is 64 bit I'll try it and if it doesn't compile I'll exclude it. Created attachment 1846800 [details]
godot-cpp-devel.spec
In case you still want to pursue this, here is a spec which builds on all arches (using cmake rather than scons).
Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=80136367 This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |