Bug 2025494
| Summary: | Capsule sync task failed to refresh repo that doesn't have feed url with "bad argument (expected URI object or URI string)" error | |||
|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Hao Chang Yu <hyu> | |
| Component: | Capsule - Content | Assignee: | satellite6-bugs <satellite6-bugs> | |
| Status: | CLOSED ERRATA | QA Contact: | Vladimír Sedmík <vsedmik> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 6.10.0 | CC: | aeladawy, ahumbe, huali, jbhatia, jpasqual, jsherril, ldelouw, osousa, pratshar, rcavalca, saydas, vdeshpan, wclark | |
| Target Milestone: | 6.11.0 | Keywords: | Regression, Triaged | |
| Target Release: | Unused | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | katello-4.3.0-1.el7sat | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 2030448 (view as bug list) | Environment: | ||
| Last Closed: | 2022-07-05 14:30:29 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
As a workaround for this bug, you could either: 1. For any repository being synced to a capsule that does not have a url, navigate to products > click a product > click a repository set some dummy url such as "http://example.com/repo". Note you do not need to sync the repository, just having the url set should workaround the bug OR 2. Apply this patch: https://github.com/Katello/katello/pull/9803.patch restart all satellite services (In reply to Justin Sherrill from comment #2) > As a workaround for this bug, you could either: > > 1. For any repository being synced to a capsule that does not have a url, > navigate to products > click a product > click a repository > > set some dummy url such as "http://example.com/repo". Note you do not need > to sync the repository, just having the url set should workaround the bug > > > OR > > 2. Apply this patch: https://github.com/Katello/katello/pull/9803.patch > > restart all satellite services If the dummy URL workaround is being used, then any CV that contains that repo, should be republished and promoted or else the sync will fail with this error: "undefined method `pulp_href' for nil:NilClass" A solution article is on it's way but meanwhile, I dropped the note here. There is a hotfix available for Satellite 6.10.1, attached to the clone of this BZ for that version at https://bugzilla.redhat.com/show_bug.cgi?id=2030448#c4 Verified on 7.0 snap 10 - Capsule synced successfully without any errors, packages are present on the capsule side. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: Satellite 6.11 Release), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2022:5498 |
Description of problem: There are 2 issues here: 1) The "needs_updates?" will always be "true" so Satellite will always try to refresh the repos in the Capsule. 2) Capsule sync task failed to refresh custom repository without feed url: --------------------------------------------- 5: Actions::Pulp3::Orchestration::Repository::RefreshRepos (skipped) [ 6.90s / 6.41s ] Error: ArgumentError bad argument (expected URI object or URI string) --- - "/opt/rh/rh-ruby27/root/usr/share/ruby/uri/common.rb:739:in `URI'" - "/opt/theforeman/tfm/root/usr/share/gems/gems/katello-4.1.1.39/app/services/katello/pulp3/repository/yum.rb:15:in `remote_options'" - "/opt/theforeman/tfm/root/usr/share/gems/gems/katello-4.1.1.39/app/services/katello/pulp3/repository.rb:197:in `compute_remote_options'" - "/opt/theforeman/tfm/root/usr/share/gems/gems/katello-4.1.1.39/app/services/katello/pulp3/repository_mirror.rb:37:in `needs_updates?'" - "/opt/theforeman/tfm/root/usr/share/gems/gems/katello-4.1.1.39/app/services/katello/pulp3/repository.rb:167:in `mirror_needs_updates?'" - "/opt/theforeman/tfm/root/usr/share/gems/gems/katello-4.1.1.39/app/lib/actions/katello/capsule_content/refresh_repos.rb:43:in `block in invoke_external_task'" - "/opt/theforeman/tfm/root/usr/share/gems/gems/activerecord-6.0.3.7/lib/active_record/relation/delegation.rb:87:in `each'" - "/opt/theforeman/tfm/root/usr/share/gems/gems/activerecord-6.0.3.7/lib/active_record/relation/delegation.rb:87:in `each'" -------------------------------------------- Below should be the offending lines In /opt/theforeman/tfm/root/usr/share/gems/gems/katello-4.1.1.39/app/services/katello/pulp3/repository_mirror.rb def needs_updates? remote = fetch_remote return true if remote.blank? options = repo_service.compute_remote_options <=============== It seems like "self.compute_remote_options" should be used here options.keys.any? { |key| remote.send(key) != options[key] } end In "/opt/theforeman/tfm/root/usr/share/gems/gems/katello-4.1.1.39/app/services/katello/pulp3/repository/yum.rb", def remote_options options = common_remote_options uri = URI(root.url) <========================== This will gives error if root repo has no feed. unless root.upstream_authentication_token.blank? options.merge!(sles_auth_token: root.upstream_authentication_token) end options.merge!(url: uri.to_s, policy: root.download_policy) end Steps to Reproduce: 1. Create a custom repo without feed and manually upload content to it. 2. Create a CV add the custom repo to the CV. 3. Publish and Promote the CV which should trigger a capsule sync task. 4. The capsule sync task should finish without error. 5. Upload new content to the custom repo. 6. Publish and Promote the CV again. Actual results: Capsule sync task failed to refresh repos with "bad argument (expected URI object or URI string)" error. Expected results: No error. Only refresh repos as needed