Bug 2025989

As the fix for the below bug is planned to be added only on MTV-2.3,
Please document that there are cases (mentioned in the list below) where a validation message could be VM will not be migrated,
however the VM will be migrated, though this message.

 
+++ This bug was initially created as a clone of Bug #2025977 +++

Description of problem:
The validation service is currently defining 10 rules as Critical, with the assessment text of "The VM will not be migrated”. This is mainly for compatibility with VMIO, which blocked the migrations. Now that we’re not using VMIO with 2.2, it needs to be changed.

This list of rules (by Peter McGowan) is mentioned below [1], 
along with the expected behavior (by Sam Lucidi).

Based on that these changes are required:
1. Remove from all those messages the phrase  "The VM will not be migrated.", except for the Invalid name case.
2. Mark as "Critical" all the cases disk transfer is likely to fail.


[1] MTV-2.2.0 validation rules
============================== 
disk_interface_type.rego:        "assessment": "The disk interface type is not supported by OpenShift Virtualization (only sata, virtio_scsi and virtio interface types are currently supported). The VM will not be migrated."

This does not block migrations, the destination VM will have a virtio disk if the source interface is not recognized.
 
disk_status.rego:        "assessment": "One or more of the VM's disks has an illegal or locked status condition. The VM will not be migrated."

The MTV controller will let the migration proceed, but the disk transfer is likely to fail.
 
disk_storage_type.rego:        "assessment": "The VM has a disk with a storage type other than 'image', and this is not currently supported by OpenShift Virtualization. The VM will not be migrated."
 
The MTV controller will let the migration proceed, but the disk transfer is likely to fail.

illegal_images.rego:        "assessment": "The VM has one or more snapshots with disks in ILLEGAL state. This is not currently supported by OpenShift Virtualization. The VM will not be migrated."
 
The MTV controller will let the migration proceed, but the disk transfer is likely to fail.

name.rego:        "assessment": "The VM name must comply with the DNS subdomain name format defined in RFC 1123. The name can contain lowercase letters (a-z), numbers (0-9), and hyphens (-), up to a maximum of 64 characters. The first and last characters must be alphanumeric. The name must not contain uppercase letters, spaces, periods (.), or special characters. The VM will not be migrated."
 
This is a blocker.

nic_interface_type.rego:        "assessment": "The NIC interface type is not supported by OpenShift Virtualization (only e1000, rtl8139 and virtio interface types are currently supported). The VM will not be migrated."
 
This does not block migrations, the destination VM will have a virtio NIC if the source interface type is not recognized.

nic_pci_passthrough.rego:        "assessment": "The VM is using a vNIC profile configured for host device passthrough, which is not currently supported by OpenShift
Virtualization. The VM will not be migrated."
 
This does not block migrations. MTV will create the VM with an SRIOV NIC, but the destination network will need to be set up correctly.

usb.rego:        "assessment": "The VM has USB support enabled, but USB devices are not currently supported by OpenShift Virtualization. The VM will not be migrated."
 
This does not block migrations, though any attached USB devices are not going to be present on the destination VM.

vm_status.rego:        "assessment": "The VM's status is not 'up' or 'down'. The VM will not be migrated."
 
This does not block migrations, though migration of that VM might get stuck waiting if the VM refuses to power off for some reason.

watchdog.rego:        "assessment": "The VM is configured with a watchdog device, which is not currently supported by OpenShift Virtualization. The VM will not be migrated."

This does not block migrations, though the watchdog device will not be present on the destination VM.

Version-Release number of selected component (if applicable):
MTV-2.2

Additional info:
The fix for this bug is: 
https://github.com/konveyor/forklift-validation/pull/38