Bug 2026693

Summary: Migration Controller pod crashes on entering invalid route to “Expose route host to image registry” in UI
Product: Migration Toolkit for Containers Reporter: ssingla
Component: ControllerAssignee: Jaydip Gabani <jgabani>
Status: CLOSED WONTFIX QA Contact: Xin jiang <xjiang>
Severity: medium Docs Contact: Avital Pinnick <apinnick>
Priority: medium    
Version: 1.5.2CC: ernelson, rjohnson
Target Milestone: ---   
Target Release: 1.5.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 2027196 (view as bug list) Environment:
Last Closed: 2021-12-16 21:45:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2027196    

Description ssingla 2021-11-25 14:06:13 UTC
Description of problem: 

Migration Controller pod goes to “CrashLoopBackoff” when invalid route is entered from the “Expose route host to image registry” 

Version-Release number of selected component (if applicable):

MTC 1.5.2
SOURCE CLUSTER: AWS 3.11 MTC 1.5.2
TARGET CLUSTER: AWS 4.5 MTC 1.5.2

How reproducible:
Always

Steps to reproduce:

1. Login to the MTC UI and Go to the “Clusters” page.
2. Edit the source-cluster and provide any random value to “Expose route host to image registry”. For Ex: docker-registry-abc.com 
3. Click on “Update Cluster”
4. Login to the target cluster and check the migration-controller pod

Actual result:


It goes to “CrashLoopBackOff” state


Expected result:

It should not crash and properly validate the registry route


Additional Info:

{"level":"info","ts":1637847331.6560373,"logger":"cluster","msg":"CR","migCluster":"host","conditions":{"conditions":[{"type":"Ready","status":"True","category":"Required","message":"The cluster is ready.","lastTransitionTime":"2021-11-25T10:09:27Z"}]}}
{"level":"info","ts":1637847331.9475632,"logger":"cluster","msg":"CR","migCluster":"source-cluster","conditions":{"conditions":[{"type":"Ready","status":"True","category":"Required","message":"The cluster is ready.","lastTransitionTime":"2021-11-25T10:11:57Z"}]}}
E1125 13:35:31.947725       1 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)
goroutine 579 [running]:
k8s.io/apimachinery/pkg/util/runtime.logPanic(0x231a3a0, 0x3b945a0)
	/remote-source/app/vendor/k8s.io/apimachinery/pkg/util/runtime/runtime.go:74 +0x95
k8s.io/apimachinery/pkg/util/runtime.HandleCrash(0x0, 0x0, 0x0)

Comment 2 Erik Nelson 2021-12-16 21:45:46 UTC
Closing as WONTFIX as we are no longer planning a 1.5.4 release given its proximity with the 1.7 release, which is the date that 1.5 will fall out of support (2/16/22).